[Bug 30567] New: Create manual invoice with FR currency format show the incorrect format
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567 Bug ID: 30567 Summary: Create manual invoice with FR currency format show the incorrect format Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: the-minh.luong@inlibro.com QA Contact: testopia@bugs.koha-community.org When creating a manual invoice with CurrencyFormat = FR , it shows the incorrect format. To test: 1- Go in Administration->Debit types 2- Click on New debit type 3- Fill the form: Code: USEDBOOK Default amount: 0.50 Description: Used book Can be manually invoiced: Yes Can be sold: Optionnal 4- Save 5- Go in Patrons 6- Go in a patron's page 7- Go in the "Accounting" section 8- Click on "Create manual invoice" 9- Fill the form 10- Choose the created debit (Used book) 11- Notice that the format is incorrect (0,50 instead of 0.50) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567 The Minh Luong <the-minh.luong@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567 --- Comment #1 from The Minh Luong <the-minh.luong@inlibro.com> --- Created attachment 133413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133413&action=edit Bug 30567: Create manual invoice with FR currency format show the correct format This patch correct the format of the price when creating a manual invoice with CurrencyFormat = FR To test: 1- Go in Administration->Debit types 2- Click on New debit type 3- Fill the form: Code: USEDBOOK Default amount: 0.50 Description: Used book Can be manually invoiced: Yes Can be sold: Optionnal 4- Save 5- Go in Patrons 6- Go in a patron's page 7- Go in the "Accounting" section 8- Click on "Create manual invoice" 9- Fill the form 10- Choose the created debit (Used book) 11- Notice that the format is incorrect (0,50 instead of 0.50) 12 - Apply the patch 13- We now see the correct format -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567 The Minh Luong <the-minh.luong@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567 The Minh Luong <the-minh.luong@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Acquisitions |Fines and fees -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |the-minh.luong@inlibro.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can confirm the bug and the patch fixes it, but I am worried about side effects of this change to Price.pm. Are we sure it has no undesired effects in other places? We'll also need unit tests for this to PQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok, with the patch the display format also changes to . instead of , - so this is not what we want. You can see this for example under administration > debit types. The rule is that input fields should always have ., but the display format depends on CurrencyFormat. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Trivial patch Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133413|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 135737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135737&action=edit Bug 30567: Fix price formatting when adding a manual invoice with CurrencyFormat FR In input fields we always use the decimal . while the display format uses the decimal separtor definded by CurrencyFormat. When adding a manual invoice without this patch, the amount is shown with comma, but it should be . in the input field. To test: 1- Go in Administration->Debit types 2- Click on New debit type 3- Fill the form: Code: USEDBOOK Default amount: 0.50 Description: Used book Can be manually invoiced: Yes 4- Save 5- Go to any patron account 6- Go to the "Accounting" tab 7- Click on "Create manual invoice" 8- Fill the form 9- Choose the created debit (Used book) 10- Verify that the format is incorrect (0,50 instead of 0.50) 11- Apply the patch 12- Verify the amount is now using the correct format -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I hope it's ok - I had an idea what could be wrong here and have written up an alternate patch. I'd really like to see this fixed :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135737|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 136335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136335&action=edit Bug 30567: Fix price formatting when adding a manual invoice with CurrencyFormat FR In input fields we always use the decimal . while the display format uses the decimal separtor definded by CurrencyFormat. When adding a manual invoice without this patch, the amount is shown with comma, but it should be . in the input field. To test: 1- Go in Administration->Debit types 2- Click on New debit type 3- Fill the form: Code: USEDBOOK Default amount: 0.50 Description: Used book Can be manually invoiced: Yes 4- Save 5- Go to any patron account 6- Go to the "Accounting" tab 7- Click on "Create manual invoice" 8- Fill the form 9- Choose the created debit (Used book) 10- Verify that the format is incorrect (0,50 instead of 0.50) 11- Apply the patch 12- Verify the amount is now using the correct format Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Severity|enhancement |normal Text to go in the| |This fixes the price release notes| |formatting when | |CurrencyFormat = FR. When | |adding a manual invoice, | |the amount input field was | |shown with a comma for | |debit types with default | |amounts, but it should be a | |decimal point. (For input | |fields we always use the | |decimal point and the | |display format uses the | |decimal separator defined | |by CurrencyFormat.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136335|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137059&action=edit Bug 30567: Fix price formatting when adding a manual invoice with CurrencyFormat FR In input fields we always use the decimal . while the display format uses the decimal separtor definded by CurrencyFormat. When adding a manual invoice without this patch, the amount is shown with comma, but it should be . in the input field. To test: 1- Go in Administration->Debit types 2- Click on New debit type 3- Fill the form: Code: USEDBOOK Default amount: 0.50 Description: Used book Can be manually invoiced: Yes 4- Save 5- Go to any patron account 6- Go to the "Accounting" tab 7- Click on "Create manual invoice" 8- Fill the form 9- Choose the created debit (Used book) 10- Verify that the format is incorrect (0,50 instead of 0.50) 11- Apply the patch 12- Verify the amount is now using the correct format Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Assignee|the-minh.luong@inlibro.com |katrin.fischer@bsz-bw.de QA Contact|testopia@bugs.koha-communit |jonathan.druart+koha@gmail. |y.org |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.04 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.04 |22.11.00, 22.05.04, released in| |21.11.11 CC| |arthur.suzuki@biblibre.com Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- pushed to 21.11.x for 21.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- If it applies, please backport. It's a TT filter change, but if the bug is in the version it's a bigger issue for users. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567 --- Comment #13 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I confirm we found this bug in 21.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.04, |22.11.00, 22.05.04, released in|21.11.11 |21.11.11, 21.05.18 --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 21.05.x branch for 21.05.18 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org