[Bug 19041] New: footerjs = 1 removed by bug 17855
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19041 Bug ID: 19041 Summary: footerjs = 1 removed by bug 17855 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 17855 From commit 0492fcf87f170846d1e6c8683916a56cb67ce9a7 Bug 17855: Onboarding tool +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt @@ -1,5 +1,3 @@ -[% USE Koha %] -[% SET footerjs = 1 %] +[% USE Koha %] has been re-added by commit 151cdcd133d8618a3faf9b47723d66ac3dc71b4e Bug 18673: News author does not display on staff client home page But not the footerjs = 1 Reading the code I guess we lost the confirmation message when deleting a news item. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19041 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17418, 16058 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Regression introduced by bug 17855. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16058 [Bug 16058] Add a button to delete an individual news item https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 [Bug 17418] Move staff client home page JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19041 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19041 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19041 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19041 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65538&action=edit Bug 19041: (bug 17855 follow-up) Fix regression on bug 16058 From commit 0492fcf87f170846d1e6c8683916a56cb67ce9a7 Bug 17855: Onboarding tool +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt @@ -1,5 +1,3 @@ -[% USE Koha %] -[% SET footerjs = 1 %] +[% USE Koha %] has been re-added by commit 151cdcd133d8618a3faf9b47723d66ac3dc71b4e Bug 18673: News author does not display on staff client home page But not the footerjs = 1 Test plan:
From the main page of the staff interface, delete a news item Without this patch applied you will not get a JS confirmation message
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19041 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19041 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19041 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65538|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 65546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65546&action=edit [SIGNED-OFF] Bug 19041: (bug 17855 follow-up) Fix regression on bug 16058 From commit 0492fcf87f170846d1e6c8683916a56cb67ce9a7 Bug 17855: Onboarding tool +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt @@ -1,5 +1,3 @@ -[% USE Koha %] -[% SET footerjs = 1 %] +[% USE Koha %] has been re-added by commit 151cdcd133d8618a3faf9b47723d66ac3dc71b4e Bug 18673: News author does not display on staff client home page But not the footerjs = 1 Test plan:
From the main page of the staff interface, delete a news item Without this patch applied you will not get a JS confirmation message
Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19041 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19041 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65546|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 65548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65548&action=edit Bug 19041: (bug 17855 follow-up) Fix regression on bug 16058 From commit 0492fcf87f170846d1e6c8683916a56cb67ce9a7 Bug 17855: Onboarding tool +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt @@ -1,5 +1,3 @@ -[% USE Koha %] -[% SET footerjs = 1 %] +[% USE Koha %] has been re-added by commit 151cdcd133d8618a3faf9b47723d66ac3dc71b4e Bug 18673: News author does not display on staff client home page But not the footerjs = 1 Test plan:
From the main page of the staff interface, delete a news item Without this patch applied you will not get a JS confirmation message
Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Trivial fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19041 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19041 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org