[Bug 21340] New: Add spans with classes around callnumbers in OPAC for additional styling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21340 Bug ID: 21340 Summary: Add spans with classes around callnumbers in OPAC for additional styling Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21340 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21340 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21340 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 78596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78596&action=edit Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21340 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21340 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78596|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 78850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78850&action=edit Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well. Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21340 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78850|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 78852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78852&action=edit Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well. Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21340 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78852|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 78853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78853&action=edit Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well. Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter vk <petter@libriotech.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21340 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78853|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 78855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78855&action=edit Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well. Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter vk <petter@libriotech.no> Signed-off-by: Petter vk <petter@libriotech.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21340 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78855|0 |1 is obsolete| | --- Comment #6 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 78857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78857&action=edit Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well. Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter vk <petter@libriotech.no> Signed-off-by: Petter vk <petter@libriotech.no> Signed-off-by: Petter vk <petter@libriotech.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21340 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78857|0 |1 is obsolete| | --- Comment #7 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 78866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78866&action=edit Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well. Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Petter vk <petter@libriotech.no> Signed-off-by: Petter vk <petter@libriotech.no> Signed-off-by: Petter vk <petter@libriotech.no> Signed-off-by: Petter vk <petter@libriotech.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21340 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |Signed Off --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- As you can see by the excessive signed-off-by's below, I'm pretty sure Petter is experiencing this ByWater Sandboxes not signing off problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21340 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78866|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 79180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79180&action=edit Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well. Signed-off-by: Petter <petter@libriotech.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21340 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe a silly question, but how do you make the callnumber show up in the result list? I tried OPACItemsResultsDisplay, but that didn't work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21340 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Turns out it helps when your items actually have callnumbers :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21340 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21340 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79180|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 79354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79354&action=edit Bug 21340: Add spans with classes around callnumbers in OPAC for additional styling It would be nice if the callnumber portion of the callnumber + label was in a span, and it also makes sense to wrap the entire callnumber string in a span as well. Signed-off-by: Petter <petter@libriotech.no> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21340 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21340 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org