[Bug 30633] New: Move OPACHoldingsDefaultSortField to table settings configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Bug ID: 30633 Summary: Move OPACHoldingsDefaultSortField to table settings configuration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Depends on: 29648 Now that the sorting of a table can be defined in administration > table settings, we should move OPACHoldingsDefaultSortField there and remove the pref. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30634 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30634 [Bug 30634] Allow to define primary and secondary sorting criteria for item table in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Bug 30633 depends on bug 29648, which changed state. Bug 29648 Summary: Make KohaTable tables 'default length' and 'default sort' configurable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catrina@bywatersolutions.co | |m --- Comment #1 from Catrina Berka <catrina@bywatersolutions.com> --- Does 23.05 include the ability to sort the holdingst table? There is no sort capability on that table in 22.11 so the system preference is still needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35319 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36640 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk --- Comment #2 from Aude Charillon <aude.charillon@openfifth.co.uk> --- I believe making this happen would solve bug 35319 - Default sorting of the holdings table with OPACHoldingsDefaultSortField is broken? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Ray Delahunty <r.delahunty@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart@gmail.com Severity|enhancement |normal Assignee|oleonard@myacpl.org |jonathan.druart@gmail.com --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Feature introduced by bug 16552, accidentally removed by bug 16759. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- I can work on this if we get one tester and one QAer in advance for quick inclusion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- *** Bug 35319 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35319 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6552, 16759 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6552 [Bug 6552] searching, add, save record failed https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 [Bug 16759] Make OPAC holdings table configurable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|6552 |16552 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6552 [Bug 6552] searching, add, save record failed https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552 [Bug 16552] Add the ability to change the default holdings sort -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 --- Comment #6 from Ray Delahunty <r.delahunty@arts.ac.uk> --- We don't have server access but assuming this is testable in a sandbox, I'll try for the first signoff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41010 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41010 [Bug 41010] Incorrect show_priority condition in opac-detail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40982 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40982 [Bug 40982] Basket: Orders table — "Modify" and "Cancel order" columns missing or displayed incorrectly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187856&action=edit Bug 30633: Prepare the ground Make the OPAC holdings table ready to use visibility based on column's names. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187857&action=edit Bug 30633: Hide columns when needed We can use the force_visibility flag to hide column when they are empty or should not be displayed because of syspref. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187858&action=edit Bug 30633: Add default_sort_order to table settings So we can pick a column from the table settings http://localhost:8081/cgi-bin/koha/admin/columns_settings.pl#biblio-detail%7... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187859&action=edit Bug 30633: Remove OPACHoldingsDefaultSortField It's no longer needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- I am suggesting to remove OPACHoldingsDefaultSortField and have the default sort order option available for this table in the table settings. With OpacLocationBranchToDisplay (introduced by bug 35006) it might improve the situation and answer the different needs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187856|0 |1 is obsolete| | --- Comment #12 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 187886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187886&action=edit Bug 30633: Prepare the ground Make the OPAC holdings table ready to use visibility based on column's names. Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187857|0 |1 is obsolete| | --- Comment #13 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 187887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187887&action=edit Bug 30633: Hide columns when needed We can use the force_visibility flag to hide column when they are empty or should not be displayed because of syspref. Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187858|0 |1 is obsolete| | --- Comment #14 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 187888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187888&action=edit Bug 30633: Add default_sort_order to table settings So we can pick a column from the table settings http://localhost:8081/cgi-bin/koha/admin/columns_settings.pl#biblio-detail%7... Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187859|0 |1 is obsolete| | --- Comment #15 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 187889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187889&action=edit Bug 30633: Remove OPACHoldingsDefaultSortField It's no longer needed Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu Status|Needs Signoff |Signed Off --- Comment #16 from Michaela Sieber <michaela.sieber@kit.edu> --- Tested in Sandbox and additionally with ktd. Testplan: - search for a biblio with multiple items, e.g. biblionumber=211 - change the items so that they have different home libraries, current libraries, itemtypes, collections, and so on ... - try different variations of sysprefs OPACHoldingsDefaultSortField and check that the sort order in the opac is always by item type - apply patch - Go to system preferences and verify that OPACHoldingsDefaultSortField does not exist any more - Go to table settings and check the new drop down for default sort order - try different variations of the default sort order settings and verify that the holdings table in the opac is sorted correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clemens.tubach@kit.edu QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I'm happy to QA this, but we need someone to test and signoff on bug 41010 first to unblock this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38080 CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41042 --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- Michaela found a bug when testing this, I opened bug 41042. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41042 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41042 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41042 [Bug 41042] Table setting 'default sort order' not available for existing installations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 --- Comment #19 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 188067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188067&action=edit Bug 30633: Default to 'Item type' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 188068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188068&action=edit Bug 30633: Default to 'Current library' if item_level_itypes is off We cannot set the default value in the yaml file dynamically. This is not ideal but we are going to modify the default "Item type" if item-level_itypes is off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187886|0 |1 is obsolete| | --- Comment #21 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 188069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188069&action=edit Bug 30633: Prepare the ground Make the OPAC holdings table ready to use visibility based on column's names. Signed-off-by: Michaela <michaela.sieber@kit.edu> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187887|0 |1 is obsolete| | --- Comment #22 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 188070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188070&action=edit Bug 30633: Hide columns when needed We can use the force_visibility flag to hide column when they are empty or should not be displayed because of syspref. Signed-off-by: Michaela <michaela.sieber@kit.edu> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187888|0 |1 is obsolete| | --- Comment #23 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 188071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188071&action=edit Bug 30633: Add default_sort_order to table settings So we can pick a column from the table settings http://localhost:8081/cgi-bin/koha/admin/columns_settings.pl#biblio-detail%7... Signed-off-by: Michaela <michaela.sieber@kit.edu> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187889|0 |1 is obsolete| | --- Comment #24 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 188072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188072&action=edit Bug 30633: Remove OPACHoldingsDefaultSortField It's no longer needed Signed-off-by: Michaela <michaela.sieber@kit.edu> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188067|0 |1 is obsolete| | --- Comment #25 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 188073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188073&action=edit Bug 30633: Default to 'Item type' Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188068|0 |1 is obsolete| | --- Comment #26 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 188074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188074&action=edit Bug 30633: Default to 'Current library' if item_level_itypes is off We cannot set the default value in the yaml file dynamically. This is not ideal but we are going to modify the default "Item type" if item-level_itypes is off. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 --- Comment #27 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Hmm, 1) OPAC datatables.js lacks force_visibility - The OPAC version doesn't have _dt_force_visibility() function like staff interface, so are we sure this is working for the OPAC? 2) Could we perhaps use the following for ordering instead of relying on indexes that may well change with future work: // Find column by name instead of index let current_location_col = holdingst_table_settings.columns.findIndex( c => c.columnname == 'item_current_location' ); holdingst_table_settings.default_sort_order = current_location_col; 3) We need to make it clear in the release notes that the preference content is not migrated into the dt configs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 --- Comment #28 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 188192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188192&action=edit Bug 30633: Remove force_visibility flag It's not available at the OPAC, and we actually don't need it: we don't save/restore DT's state. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off Depends on|40982 | Text to go in the| |Restore the ability to release notes| |define a default sort order | |for the holdings table at | |the OPAC. | |It replaces the system | |preference | |"OPACHoldingsDefaultSortFie | |ld" that had been broken | |for a while. Note that its | |value is not migrated. --- Comment #29 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Martin Renvoize (ashimema) from comment #27)
Hmm,
1) OPAC datatables.js lacks force_visibility - The OPAC version doesn't have _dt_force_visibility() function like staff interface, so are we sure this is working for the OPAC?
Indeed, it's not needed at the OPAC. force_visibility has been introduced to force visiblity to restore DT's state. And it is not available for OPAC tables.
2) Could we perhaps use the following for ordering instead of relying on indexes that may well change with future work:
// Find column by name instead of index let current_location_col = holdingst_table_settings.columns.findIndex( c => c.columnname == 'item_current_location' ); holdingst_table_settings.default_sort_order = current_location_col;
Maybe, I don't know. We are storing/manipulating the index in the yaml and the DB for default_sort_order. We could try and see if it's possible to remove the index completely and use the column's names everywhere, but that's for another day :)
3) We need to make it clear in the release notes that the preference content is not migrated into the dt configs
Added something to the release notes. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40982 [Bug 40982] Basket: Orders table — "Modify" and "Cancel order" columns missing or displayed incorrectly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 --- Comment #30 from Michaela Sieber <michaela.sieber@kit.edu> --- (In reply to Jonathan Druart from comment #29)
(In reply to Martin Renvoize (ashimema) from comment #27)
2) Could we perhaps use the following for ordering instead of relying on indexes that may well change with future work:
// Find column by name instead of index let current_location_col = holdingst_table_settings.columns.findIndex( c => c.columnname == 'item_current_location' ); holdingst_table_settings.default_sort_order = current_location_col;
Maybe, I don't know. We are storing/manipulating the index in the yaml and the DB for default_sort_order. We could try and see if it's possible to remove the index completely and use the column's names everywhere, but that's for another day :)
Hey Martin and Jonathan, we would very much appreciate it if the column's names would be used. If you want to put this topic on the roadmap for 26.05, I'm happy to take care of testing it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188069|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188286&action=edit Bug 30633: Prepare the ground Make the OPAC holdings table ready to use visibility based on column's names. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188070|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188287&action=edit Bug 30633: Hide columns when needed We can use the force_visibility flag to hide column when they are empty or should not be displayed because of syspref. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188071|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188288&action=edit Bug 30633: Add default_sort_order to table settings So we can pick a column from the table settings http://localhost:8081/cgi-bin/koha/admin/columns_settings.pl#biblio-detail%7... Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188072|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188289&action=edit Bug 30633: Remove OPACHoldingsDefaultSortField It's no longer needed Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188073|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188290&action=edit Bug 30633: Default to 'Item type' Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188074|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188291&action=edit Bug 30633: Default to 'Current library' if item_level_itypes is off We cannot set the default value in the yaml file dynamically. This is not ideal but we are going to modify the default "Item type" if item-level_itypes is off. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188192|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188292&action=edit Bug 30633: Remove force_visibility flag It's not available at the OPAC, and we actually don't need it: we don't save/restore DT's state. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 --- Comment #38 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks everyone, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 --- Comment #39 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 --- Comment #40 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #41 from Fridolin Somers <fridolin.somers@biblibre.com> --- Feels like this is a too big change for 24.11.x LTS I prefer not backport to avoid side effects. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org