[Bug 35708] New: System parameter AutoRenewalNotices defaults to deprecated option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 Bug ID: 35708 Summary: System parameter AutoRenewalNotices defaults to deprecated option Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: anke.bruns@gwdg.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When installing Koha, the deprecated option "(Deprecated) according to --send-notices cron switch" is set by default in the system preference "AutoRenewalNotices". It would be nicer to have another option as default, e.g. "according to patron messaging preferences" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 Anke Bruns <anke.bruns@gwdg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |anke.bruns@gwdg.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 Anke Bruns <anke.bruns@gwdg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.11 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 Anke Bruns <anke.bruns@gwdg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anke.bruns@gwdg.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 --- Comment #1 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 164394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164394&action=edit Bug: 35708: Update default system preference for AutoRenewalNotices Test plan: 1. Apply test plan and restart everything 2. Confirm AutoRenewalNotices defaults to patron messaging preferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164394|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 164397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164397&action=edit Bug: 35708: Update default system preference for AutoRenewalNotices Test plan: 1. Apply test plan and restart everything 2. Confirm AutoRenewalNotices defaults to patron messaging preferences Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |NEW INSTALLATIONS ONLY. release notes| |This sets the default value | |for the AutoRenewalNotices | |system preference to | |"according to patron | |messaging preferences". | |(The previous default value | |was deprecated - | |"(Deprecated) according to | |--send-notices cron | |switch".) --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Check the system preference AutoRenewalNotices - note that the default is "(Deprecated) according to --send-notices cron switch". 2. Apply the patch. 3. Reset everything (like it is a new installation): reset_all 4. Note that the AutoRenewalNotices system preference is now set to "according to patron messaging preferences". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA Patch complexity|--- |Trivial patch QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov CC| |emily.lamancusa@montgomeryc | |ountymd.gov Assignee|anke.bruns@gwdg.de |blawlor@clamsnet.org --- Comment #4 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Hi Brendan, thanks for catching that! Can you please amend your patch to remove the change to updatedatabase.pl? That file is only used for upgrading existing systems older than version 21.05 - it does not generally get edited anymore. The update to sysprefs.sql is all you need in this case. :) For future reference, this wiki page is a good starting point for making changes to system preferences - https://wiki.koha-community.org/wiki/System_Preferences And if you're curious, a little history about updatedatabase.pl and how we make database updates now - https://wiki.koha-community.org/wiki/Database_updates#History -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 --- Comment #5 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 164437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164437&action=edit Bug 35708: Update default system preference for AutoRenewalNotices Test plan: 1. Apply test plan and restart everything 2. Confirm AutoRenewalNotices defaults to patron messaging preferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164397|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 --- Comment #6 from Brendan Lawlor <blawlor@clamsnet.org> --- (In reply to Emily Lamancusa from comment #4) I had doubts about editing that file after I sent it. Thanks for the info Emily! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164437|0 |1 is obsolete| | --- Comment #7 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 164438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164438&action=edit Bug 35708: Update default system preference for AutoRenewalNotices Test plan: 1. Apply test plan and restart everything 2. Confirm AutoRenewalNotices defaults to patron messaging preferences Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Thanks for the quick turnaround! Looks good now - passing QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Good catch, thanks Brendan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.06 released in| | --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply clean to 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org