https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29820 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29820 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129202&action=edit Bug 29820: Set paging option using boolean instead of string Bug 28450, "Make Account summary print tables configurable," added DataTables to the print summary view. The updated page includes the wrong option: "paging": "false", It should be: "paging": false, Because DataTables expects that option to be boolean (true or false). To test, apply the patch and check out to a patron who has more than 20 checkouts and more than 20 holds. - From the toolbar, click Print -> Print summary. - On the acount summary page, confirm that the "Items checked out" and "Pending holds" tables show ALL entries, not just the first 20. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29820 Mohd Hafiz Yusoff <mhby87@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Mohd Hafiz Yusoff <mhby87@gmail.com> --- Created attachment 129202 [details] [review] Bug 29820: Set paging option using boolean instead of string Bug 28450, "Make Account summary print tables configurable," added DataTables to the print summary view. The updated page includes the wrong option: "paging": "false", It should be: "paging": false, Because DataTables expects that option to be boolean (true or false). To test, apply the patch and check out to a patron who has more than 20 checkouts and more than 20 holds. - From the toolbar, click Print -> Print summary. - On the acount summary page, confirm that the "Items checked out" and "Pending holds" tables show ALL entries, not just the first 20. Signed-off-by: Mohd Hafiz Yusoff <mhby87@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29820 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129202|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 129220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129220&action=edit Bug 29820: Set paging option using boolean instead of string Bug 28450, "Make Account summary print tables configurable," added DataTables to the print summary view. The updated page includes the wrong option: "paging": "false", It should be: "paging": false, Because DataTables expects that option to be boolean (true or false). To test, apply the patch and check out to a patron who has more than 20 checkouts and more than 20 holds. - From the toolbar, click Print -> Print summary. - On the acount summary page, confirm that the "Items checked out" and "Pending holds" tables show ALL entries, not just the first 20. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29820 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29820 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes.