[Bug 12823] New: Add some hints for Host and Database when hovering their labels
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 Bug ID: 12823 Summary: Add some hints for Host and Database when hovering their labels Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt@gmail.com Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl This report deals with a specific QA remark on point 6536 ("Database field not obvious for SRU servers"). Since this could be done in various ways, I prefer to put it under a separate report. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 31154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31154&action=edit Bug 12823: Add some hints for Host and Database when hovering their labels When adding or editing a SRU server, the red Required text will be appended with another hint how to fill these fields. Test plan: Add/Edit SRU server. Hover over the Hostname and Database label. Add/Edit Z39.50 server. Hover again. No additional text. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6536 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add some hints for Host and |Add some hints for Host, |Database when hovering |Database and SRU search |their labels |fields mappings -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- I am extending this report with QA remark 3 on bug 6536 (Hint to define the SRU search field mappings). The proposed path will warn a user that saves a SRU server without those mappings. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 31155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31155&action=edit Bug 12823: Hint to define the SRU search field mappings This is a follow report for report 6536 (SRU search targets). It will alert a user that saves a SRU server without field mappings. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31155|0 |1 is obsolete| | --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 31156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31156&action=edit Bug 12823: Hint to define the SRU search field mappings This is a follow report for report 6536 (SRU search targets). It will alert a user that saves a SRU server without field mappings. Test plan: Add a Z#9.50 server. No confirm message. Add a SRU server without field mappings. Cancel the confirm. Add one field mapping. No confirm message. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31156|0 |1 is obsolete| | --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 31157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31157&action=edit Bug 12823: Hint to define the SRU search field mappings This is a follow-up for report 6536 (SRU search targets). It will alert a user that saves a SRU server without field mappings. Test plan: Add a Z39.50 server. No confirm message. Add a SRU server without field mappings. Cancel the confirm. Add one field mapping. No confirm message. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Follow-up coming for qa tools warnings. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31154|0 |1 is obsolete| | --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 31228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31228&action=edit Bug 12823: Add some hints for Host and Database when hovering their labels When adding or editing a SRU server, the red Required text will be appended with another hint how to fill these fields. Test plan: Add/Edit SRU server. Hover over the Hostname and Database label. Add/Edit Z39.50 server. Hover again. No additional text. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31157|0 |1 is obsolete| | --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 31229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31229&action=edit Bug 12823: Hint to define the SRU search field mappings This is a follow-up for report 6536 (SRU search targets). It will alert a user that saves a SRU server without field mappings. Test plan: Add a Z39.50 server. No confirm message. Add a SRU server without field mappings. Cancel the confirm. Add one field mapping. No confirm message. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to M. de Rooy from comment #6)
Follow-up coming for qa tools warnings. Resolved.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_18_candidate CC| |tomascohen@gmail.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- I think a more standard and more usable solution for the hints would be to use <div class="hint"></div>. See memberentrygen.tt for an example. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31228|0 |1 is obsolete| | Attachment #31229|0 |1 is obsolete| | --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 33981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33981&action=edit Bug 12823: Add some hints for Host and Database When adding or editing a SRU server, this patch adds a hint, positioned under the Hostname field. It also moves similar information for SRU options and XSLT into hints. Test plan: Add/Edit SRU server. Look at Hostname, SRU options and XSLT. Add/Edit Z39.50 server. No hints for Hostname and SRU options. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 --- Comment #12 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 33982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33982&action=edit Bug 12823: Alert about defining the SRU search field mappings This is a follow-up for report 6536 (SRU search targets). It will alert a user that saves a SRU server without field mappings. Test plan: Add a Z39.50 server. No confirm message. Add a SRU server without field mappings. Cancel the confirm. Add one field mapping. No confirm message. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Owen Leonard from comment #10)
I think a more standard and more usable solution for the hints would be to use <div class="hint"></div>. See memberentrygen.tt for an example.
Thanks for your feedback. Simplified the patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_18_candidate | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33981|0 |1 is obsolete| | --- Comment #14 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 34690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34690&action=edit [SIGNED OFF] Bug 12823: Add some hints for Host and Database When adding or editing a SRU server, this patch adds a hint, positioned under the Hostname field. It also moves similar information for SRU options and XSLT into hints. Test plan: Add/Edit SRU server. Look at Hostname, SRU options and XSLT. Add/Edit Z39.50 server. No hints for Hostname and SRU options. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33982|0 |1 is obsolete| | --- Comment #15 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 34691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34691&action=edit [SIGNED OFF] Bug 12823: Alert about defining the SRU search field mappings This is a follow-up for report 6536 (SRU search targets). It will alert a user that saves a SRU server without field mappings. Test plan: Add a Z39.50 server. No confirm message. Add a SRU server without field mappings. Cancel the confirm. Add one field mapping. No confirm message. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34690|0 |1 is obsolete| | Attachment #34691|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34695&action=edit [PASSED QA] Bug 12823: Add some hints for Host and Database When adding or editing a SRU server, this patch adds a hint, positioned under the Hostname field. It also moves similar information for SRU options and XSLT into hints. Test plan: Add/Edit SRU server. Look at Hostname, SRU options and XSLT. Add/Edit Z39.50 server. No hints for Hostname and SRU options. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34696 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34696&action=edit [PASSED QA] Bug 12823: Alert about defining the SRU search field mappings This is a follow-up for report 6536 (SRU search targets). It will alert a user that saves a SRU server without field mappings. Test plan: Add a Z39.50 server. No confirm message. Add a SRU server without field mappings. Cancel the confirm. Add one field mapping. No confirm message. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #19 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #20 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 --- Comment #21 from Mason James <mtj@kohaaloha.com> --- (In reply to Mason James from comment #20)
Pushed to 3.16.x, will be in 3.16.7
Oops, I accidentally introduced a merge bug in the .tt file, with this patchset I'm going to revert this for the 3.16.8 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org