[Bug 31479] New: Provide an option to skip the test for atomic updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Bug ID: 31479 Summary: Provide an option to skip the test for atomic updates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Since t/00-check-atomic-updates.t was fixed in Bug 31108, if there are any atomic updates left when building a package manually, the test and build will fail. Koha providers like Catalyst may keep atomic updates when building packages for customisations. Sometimes these are just temporary, while we wait for custom work to get upstreamed (in which case we can remove the atomic updates), but sometimes these are necessary customisations which must be kept for the library. So an option to skip this test when building a custom package would be useful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31108 Assignee|chris@bigballofwax.co.nz |aleisha@catalyst.net.nz Change sponsored?|--- |Sponsored Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 139934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139934&action=edit Bug 31479: Option to skip t/00-check-atomic-updates.t when building custom packages This enhancement adds an option to skip the check for leftover atomic updates when building custom packages. This is particularly useful for Koha providers or anyone else building Koha packages manually. In practice, this could be run like: sudo CUSTOM_PACKAGE=1 ./debian/build-git-snapshot -r ~/debian -v 21.11.01git -d This test plan should all take place within the shell. 0. sudo koha-shell kohadev 1. Run prove t/00-check-atomic-updates.t and confirm the test passes 2. Add a fake atomic update to installer/data/mysql/atomicupdate/ . You can use the example from https://wiki.koha-community.org/wiki/Database_updates#How_to_write_an_atomic... 3. Run prove t/00-check-atomic-updates.t and notice the test fails 4. Set the CUSTOM_PACKAGE environment variable so we can test this. You can either set on the commandline (using export) or in /etc/environment (remember to run source /etc/environment so the changes are accessed) 5. Run prove t/00-check-atomic-updates.t and the test should now pass. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds an release notes| |option to skip the check | |for leftover atomic updates | |when building custom | |packages. This is | |particularly useful for | |Koha providers or anyone | |else building Koha packages | |manually. | | | |In practice, | |this could be run like: | |sudo CUSTOM_PACKAGE=1 | |./debian/build-git-snapshot | |-r ~/debian -v 21.11.01git | |-d -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds an |This enhancement adds an release notes|option to skip the check |option to skip the check |for leftover atomic updates |for leftover atomic updates |when building custom |when building custom |packages. This is |packages. This is |particularly useful for |particularly useful for |Koha providers or anyone |Koha providers or anyone |else building Koha packages |else building Koha packages |manually. |manually. | | |In practice, |In practice, |this could be run like: |this could be run like: |sudo CUSTOM_PACKAGE=1 |sudo CUSTOM_PACKAGE=1 |./debian/build-git-snapshot |./debian/build-git-snapshot |-r ~/debian -v 21.11.01git |-r ~/debian -v 21.11.01git |-d |-d -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139934|0 |1 is obsolete| | --- Comment #2 from Mason James <mtj@kohaaloha.com> --- Created attachment 150036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150036&action=edit Bug 31479: Option to skip t/00-check-atomic-updates.t when building custom packages This enhancement adds an option to skip the check for leftover atomic updates when building custom packages. This is particularly useful for Koha providers or anyone else building Koha packages manually. In practice, this could be run like: sudo CUSTOM_PACKAGE=1 ./debian/build-git-snapshot -r ~/debian -v 21.11.01git -d This test plan should all take place within the shell. 0. sudo koha-shell kohadev 1. Run prove t/00-check-atomic-updates.t and confirm the test passes 2. Add a fake atomic update to installer/data/mysql/atomicupdate/ . You can use the example from https://wiki.koha-community.org/wiki/Database_updates#How_to_write_an_atomic... 3. Run prove t/00-check-atomic-updates.t and notice the test fails 4. Set the CUSTOM_PACKAGE environment variable so we can test this. You can either set on the commandline (using export) or in /etc/environment (remember to run source /etc/environment so the changes are accessed) 5. Run prove t/00-check-atomic-updates.t and the test should now pass. Sponsored-by: Catalyst IT Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #3 from Mason James <mtj@kohaaloha.com> --- signing off, looks good to me :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150036|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 150388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150388&action=edit Bug 31479: Option to skip t/00-check-atomic-updates.t when building custom packages This enhancement adds an option to skip the check for leftover atomic updates when building custom packages. This is particularly useful for Koha providers or anyone else building Koha packages manually. In practice, this could be run like: sudo CUSTOM_PACKAGE=1 ./debian/build-git-snapshot -r ~/debian -v 21.11.01git -d This test plan should all take place within the shell. 0. sudo koha-shell kohadev 1. Run prove t/00-check-atomic-updates.t and confirm the test passes 2. Add a fake atomic update to installer/data/mysql/atomicupdate/ . You can use the example from https://wiki.koha-community.org/wiki/Database_updates#How_to_write_an_atomic... 3. Run prove t/00-check-atomic-updates.t and notice the test fails 4. Set the CUSTOM_PACKAGE environment variable so we can test this. You can either set on the commandline (using export) or in /etc/environment (remember to run source /etc/environment so the changes are accessed) 5. Run prove t/00-check-atomic-updates.t and the test should now pass. Sponsored-by: Catalyst IT Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com Status|Pushed to master |Needs documenting --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Enhancement - not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Nothing to add to the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org