http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7917 CC| |hagud@orex.es Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 35818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35818&action=edit Bug 13695: Add ISBD to OpacExportOptions This patch adds 'isbd' as an export option on the system preferences. Note this patch doesn't add the feature. To test: - On master, search for the OpacExportOptions syspref => FAIL: There is no ISBD option. - Apply the patch - Search for the OpacExportOptions syspref => SUCCESS: There is a new ISBD option. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 35820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35820&action=edit Bug 13695: Add ISBD export option for the OPAC cart and lists This patch adds the option to download records from the cart, and lists in the ISBD format from the OPAC. To test (cart): - Apply the patch - Add several records to your OPAC cart. - Go to your cart, and choose 'Download' => SUCCESS: There's an ISBD option - Dowload and open the exported records => SUCCESS: The file contains the ISBD format for the records on the cart To test (lists): - Add several records to a list (i did it from the cart ;-)) - Open the list - Choose 'Download list' => SUCCESS: There's an ISBD option - Download and open the exported records => SUCCESS: The file contains the ISBD format for the records on the list. - Sign off :-D Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13642 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35819|0 |1 is obsolete| | --- Comment #6 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 36135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36135&action=edit Bug 13695: Add ISBD export option to OPAC (detail) This patch adds the option to export a record (from within the OPAC record detail page) in the ISBD format. To test: - Enable ISBD on the OpacExportOptions syspref - Look for a record on your opac - On the detail page, notice there's a new ISBD option for 'Save record' - Choose ISBD => SUCCESS: a file containing the ISBD format for the record is downloaded Sponsored-by: Orex Digital Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695 --- Comment #8 from Hugo Agud <hagud@orex.es> --- We have applied the patch and it works, but we have found some issues 1. charset issues with utf8 2. issues with html labels _____________________________ Barcelona institucions 2000 DirecciÛ: ¡ngel Fern·ndez MartÌnez, Francesc GalmÈs i DÌaz-Plaja ; col∑laboradors: M. Dulce de Torres Ruiz de Porras ... [et al.] - Barcelona: DiputaciÛ de Barcelona;Ajuntament de Barcelona - 696 p. ; 21 cm - Paper <br/><br/><label>ISBN: </label>8477947376 <br/><br/><label>LCCN: </label>2478 <br/><br/><label>Subjects--Topical Terms: </label><br/>Barcelona (ProvÌncia) -- Directoris -- 2000<br/>Barcelona (ProvÌncia) -- Guies -- 2000 <br/><br/><label>Universal Decimal Class. No.: </label>061.1(460.23) ___________________________________ We have modified a little the patch changing txt to html and all these issues are fixed, the user may copy and paste to txt or keep it in html. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695 --- Comment #10 from Hugo Agud <hagud@orex.es> --- (In reply to Jonathan Druart from comment #9)

(In reply to Hugo Agud from comment #8)

...

We have applied the patch and it works, but we have found some issues

Hugo, I don't reproduce the encoding issue (pmvers Encode: 2.60). Is it expected to retrieve a file with the html tag? IMO the ISBD generated file should be a simple text file, don't you think?

Yes txt is desirable of course, we just did that change becasue we were in a hurry to push to the server. We faced problems with diacritics (spanish), I will chech the encoding againg, thanks for the tip -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #11)

Tomas, I would like to get your opinion on this. Shouldn't we create a new pref for the ISBD export or remove the html tags?

As the patch author I might not be the best to say. I always expect the ISBD (In reply to Jonathan Druart from comment #11)

Tomas, I would like to get your opinion on this. Shouldn't we create a new pref for the ISBD export or remove the html tags?

I don't think we should tweak the generated ISBD. If such was the case, then we might have a bug on the ISBD generating code, that makes people use HTML code to trick the browser, instead of showing the ISBD card as-is. I don't favour adding new sysprefs for this kind of thing. At least no at a first sight of the problem. I'll try to read a bit more about the ISBD code to figure what is the expected behaviour. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36134|0 |1 is obsolete| | Attachment #36135|0 |1 is obsolete| | Attachment #36136|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37304&action=edit [PASSED QA] Bug 13695: Add ISBD to OpacExportOptions This patch adds 'isbd' as an export option on the system preferences. Note this patch doesn't add the feature. To test: - On master, search for the OpacExportOptions syspref => FAIL: There is no ISBD option. - Apply the patch - Search for the OpacExportOptions syspref => SUCCESS: There is a new ISBD option. Sponsored-by: Orex Digital Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37306&action=edit [PASSED QA] Bug 13695: Add ISBD export option for the OPAC cart and lists This patch adds the option to download records from the cart, and lists in the ISBD format from the OPAC. To test (cart): - Apply the patch - Add several records to your OPAC cart. - Go to your cart, and choose 'Download' => SUCCESS: There's an ISBD option - Dowload and open the exported records => SUCCESS: The file contains the ISBD format for the records on the cart To test (lists): - Add several records to a list (i did it from the cart ;-)) - Open the list - Choose 'Download list' => SUCCESS: There's an ISBD option - Download and open the exported records => SUCCESS: The file contains the ISBD format for the records on the list. - Sign off :-D Sponsored-by: Orex Digital Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. -- You are receiving this mail because: You are watching all bug changes.