http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11663 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |frederic@tamil.fr --- Comment #1 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 24974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24974&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11663 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24974|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 24978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24978&action=edit Bug 11663: Bootstap opac holding tab improperly displayed when opacbookbag syspref is disabled Bootstap theme opac holding tab is improperly displayed when opacbookbag syspref is disabled, and virtualshelf is enabled. This is due to the fact that in this situation basket.js is loaded (for virtual shelves), but some JS variables are not defined in template since opacbookbag is disabled. To reproduce this bug: - Choose bootstrap OPAC theme - Enable virtualsheves syspref - Disable opacbookbag syspref - Open a biblio record in OPAC detail page - You will observe that items holding tabs are not displayed as tabs but as a buletted list Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11663 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24978|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 24982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24982&action=edit [PASSED QA] Bug 11663: Bootstap opac holding tab improperly displayed when opacbookbag syspref is disabled Bootstap theme opac holding tab is improperly displayed when opacbookbag syspref is disabled, and virtualshelf is enabled. This is due to the fact that in this situation basket.js is loaded (for virtual shelves), but some JS variables are not defined in template since opacbookbag is disabled. To reproduce this bug: - Choose bootstrap OPAC theme - Enable virtualsheves syspref - Disable opacbookbag syspref - Open a biblio record in OPAC detail page - You will observe that items holding tabs are not displayed as tabs but as a buletted list Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes QA script and all tests. Confirmed display problem exists without the patch and is solved by it. Ideally we would avoid having the cart messages in the template when the feature is deactivated, but this is ok for now. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11663 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.07 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11663 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 12422 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.