[Bug 38174] New: Self Checkout renders alert for each checkout in session instead of just most recent checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38174 Bug ID: 38174 Summary: Self Checkout renders alert for each checkout in session instead of just most recent checkout Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: blawlor@clamsnet.org QA Contact: testopia@bugs.koha-community.org In self checkout, if a patron scans a stack of books one at a time, an additional blue alert-info box is rendered for each new checkout. When this list becomes long it can push the barcode input down so far that it goes off screen which can be confusing for patrons. When not using batch checkout, self checkout should only render an alert-info box for the most recent scan. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38174 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |blawlor@clamsnet.org |ity.org | CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38174 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38174 --- Comment #1 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 172774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172774&action=edit Bug 38174: Fix self checkout alerts for non batch checkouts This patch adds a check for batch_checkouts_allowed to SCO. If not using batch checkout, only the most recent chekout should be rendered as an alert, instead of all the new issues for the session. This makes the input box consitently render in the same position. To replicate: 1. Login as self_checkout to localhost:8080/cgi-bin/koha/sco/sco-main.pl 2. Login as a patron to make self checkouts 3. Check many items out and notice an additional alert is rendered for each checkout, eventually pushing the barcode input off screen. To test: 1. Apply patch and restart_alll 2. Login as a patron to make self checkouts 3. Check many items out 4. Notice only the most recent checkout is rendered as an info alert 5. Confirm the Checkouts table below still loads all checkouts 6. In Admin set BatchCheckouts to 'Allow' 7. Set SCOBatchCheckoutsValidCategories to 'Select all' 8. Login to sco as a patron and enter a newline delimited list of barcodes 9. Confirm that an alert is rendered for each checkout in the batch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38174 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32256 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256 [Bug 32256] Self checkout batch mode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38174 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38174 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172774|0 |1 is obsolete| | --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 175856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175856&action=edit Bug 38174: Fix self checkout alerts for non batch checkouts This patch adds a check for batch_checkouts_allowed to SCO. If not using batch checkout, only the most recent chekout should be rendered as an alert, instead of all the new issues for the session. This makes the input box consitently render in the same position. To replicate: 1. Login as self_checkout to localhost:8080/cgi-bin/koha/sco/sco-main.pl 2. Login as a patron to make self checkouts 3. Check many items out and notice an additional alert is rendered for each checkout, eventually pushing the barcode input off screen. To test: 1. Apply patch and restart_alll 2. Login as a patron to make self checkouts 3. Check many items out 4. Notice only the most recent checkout is rendered as an info alert 5. Confirm the Checkouts table below still loads all checkouts 6. In Admin set BatchCheckouts to 'Allow' 7. Set SCOBatchCheckoutsValidCategories to 'Select all' 8. Login to sco as a patron and enter a newline delimited list of barcodes 9. Confirm that an alert is rendered for each checkout in the batch Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38174 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38174 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175856|0 |1 is obsolete| | --- Comment #3 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 176838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176838&action=edit Bug 38174: Fix self checkout alerts for non batch checkouts This patch adds a check for batch_checkouts_allowed to SCO. If not using batch checkout, only the most recent chekout should be rendered as an alert, instead of all the new issues for the session. This makes the input box consitently render in the same position. To replicate: 1. Login as self_checkout to localhost:8080/cgi-bin/koha/sco/sco-main.pl 2. Login as a patron to make self checkouts 3. Check many items out and notice an additional alert is rendered for each checkout, eventually pushing the barcode input off screen. To test: 1. Apply patch and restart_alll 2. Login as a patron to make self checkouts 3. Check many items out 4. Notice only the most recent checkout is rendered as an info alert 5. Confirm the Checkouts table below still loads all checkouts 6. In Admin set BatchCheckouts to 'Allow' 7. Set SCOBatchCheckoutsValidCategories to 'Select all' 8. Login to sco as a patron and enter a newline delimited list of barcodes 9. Confirm that an alert is rendered for each checkout in the batch Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38174 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |me@paulderscheid.xyz |y.org | Summary|Self Checkout renders alert |Self checkout renders alert |for each checkout in |for each checkout in |session instead of just |session instead of just |most recent checkout |most recent checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38174 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38174 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38174 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #5 from Christopher Brannon <cbrannon@cdalibrary.org> --- Can this be backported to 24.11? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38174 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38174 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38174 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Depends on bug not in 22.11.x Not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38174 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #8 from Brendan Lawlor <blawlor@clamsnet.org> --- Just a bug fix. No functional changes, no documentation needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org