[Bug 36372] New: Allow privileged users to set the 'record source' on cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Bug ID: 36372 Summary: Allow privileged users to set the 'record source' on cataloguing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl This would be handy, as right now it can only be set through an API request. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | CC| |tomascohen@gmail.com Depends on| |31791 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 --- Comment #1 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- +1 that would be handy! Also, tomas forgot to mention, the api may set the record source upon creation of a record (which is great) but there is no way to change it (even with the api) once it's created. Then the only way to change it is through a direct access to the database. In some use-cases it may be needed that a librarian "unlock" a record to let a fellow edit the record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 --- Comment #2 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 166161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166161&action=edit Bug 36372: provide an interface to set the source of a record from the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen@gmail.com |arthur.suzuki@biblibre.com QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36884 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Isn't it a done by Bug 35919 ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35919 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 --- Comment #4 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to Fridolin Somers from comment #3)
Isn't it a done by Bug 35919 ?
it is not, Bug 35919 provides all the logic but no interface. Which this bug does (based on the logic provided by bug 35919). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Lauren Denny <lauren_denny@sil.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauren_denny@sil.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 --- Comment #5 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 168054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168054&action=edit Bug 36372 : trigger a record indexing when the record source is set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 --- Comment #6 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 168195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168195&action=edit Bug 36372 : Cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166161|0 |1 is obsolete| | Attachment #168054|0 |1 is obsolete| | Attachment #168195|0 |1 is obsolete| | --- Comment #7 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 168338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168338&action=edit Bug 36372: provide an interface to set the source of a record from the staff interface Test plan : - apply Cypress patch - running cypress patch in ktd will fail - apply both code patches, cypress tests will pass - open any record in the staff interface - with superlibrarian user, click on the "Edit" button group. - you should be able to click on the "Set record source" below the "Edit record button". - you will be given a form to choose between any defined record source. If none defined there would be a link to configure the record sources. - change a users permissions to have cataloguing permissions but without the "set_record_source" permissions. - login as this forementionned user and go to any record view. - the "Set record source" button should now be greyed out and not possible to click.# -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 --- Comment #8 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 168339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168339&action=edit Bug 36372: trigger a record indexing when the record source is set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 --- Comment #9 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 168340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168340&action=edit Bug 36372: Cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36884 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36884 [Bug 36884] Make it possible to use the record_source as a criteria for a search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168338|0 |1 is obsolete| | --- Comment #10 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 168430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168430&action=edit Bug 36372: provide an interface to set the source of a record from the staff interface Test plan : - apply Cypress patch - running cypress patch in ktd will fail - apply both code patches, cypress tests will pass - open any record in the staff interface - with superlibrarian user, click on the "Edit" button group. - you should be able to click on the "Set record source" below the "Edit record button". - you will be given a form to choose between any defined record source. If none defined there would be a link to configure the record sources. - change a users permissions to have cataloguing permissions but without the "set_record_source" permissions. - login as this forementionned user and go to any record view. - the "Set record source" button should now be greyed out and not possible to click.# -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168340|0 |1 is obsolete| | --- Comment #11 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 168510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168510&action=edit Bug 36372: Cypress tests Signed-off-by: Janusz Kaczmarek <januszop@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168430|0 |1 is obsolete| | --- Comment #12 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 168511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168511&action=edit Bug 36372: provide an interface to set the source of a record from the staff interface Test plan : - apply Cypress patch - running cypress patch in ktd will fail - apply both code patches, cypress tests will pass - open any record in the staff interface - with superlibrarian user, click on the "Edit" button group. - you should be able to click on the "Set record source" below the "Edit record button". - you will be given a form to choose between any defined record source. If none defined there would be a link to configure the record sources. - change a users permissions to have cataloguing permissions but without the "set_record_source" permissions. - login as this forementionned user and go to any record view. - the "Set record source" button should now be greyed out and not possible to click.# Signed-off-by: Janusz Kaczmarek <januszop@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168339|0 |1 is obsolete| | --- Comment #13 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 168512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168512&action=edit Bug 36372: trigger a record indexing when the record source is set Signed-off-by: Janusz Kaczmarek <januszop@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |januszop@gmail.com --- Comment #14 from Janusz Kaczmarek <januszop@gmail.com> --- Post test remarks: 0) Works as declared. 1) To make cypress test happy for the second run, I had to manually delete Poop source created in the first run. 2) It was necessary to apply interactively "trigger a record indexing when the record source is set" only after "provide an interface to set the source of a record from the staff interface" was already applied. Otherwise an error results. 3) QA scripts unhappy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Bug 36372 depends on bug 31791, which changed state. Bug 31791 Summary: Add the ability to lock records to prevent modification through the Koha staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168510|0 |1 is obsolete| | Attachment #168511|0 |1 is obsolete| | Attachment #168512|0 |1 is obsolete| | --- Comment #15 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 168897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168897&action=edit Bug 36372: Cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 --- Comment #16 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 168898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168898&action=edit Bug 36372: provide an interface to set the source of a record from the staff interface Test plan : - apply Cypress patch - running cypress patch in ktd will fail - apply both code patches, cypress tests will pass - open any record in the staff interface - with superlibrarian user, click on the "Edit" button group. - you should be able to click on the "Set record source" below the "Edit record button". - you will be given a form to choose between any defined record source. If none defined there would be a link to configure the record sources. - change a users permissions to have cataloguing permissions but without the "set_record_source" permissions. - login as this forementionned user and go to any record view. - the "Set record source" button should now be greyed out and not possible to click.# -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 --- Comment #17 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 168899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168899&action=edit Bug 36372: trigger a record indexing when the record source is set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 --- Comment #18 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 168900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168900&action=edit Bug 36372: (QA follow-up) perltidy cataloguing/record_source.pl, fix permissions issues, add html filters to new template# -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 --- Comment #19 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Hi, I have re-uploaded the patch in the correct order + made a followup patch to fix the issues from the qa scripts. Can anyone make signoff again? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168900|0 |1 is obsolete| | --- Comment #20 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 168902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168902&action=edit Bug 36372: (QA follow-up) perltidy cataloguing/record_source.pl, fix permissions issues, add html filters to new template# -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #21 from Janusz Kaczmarek <januszop@gmail.com> --- Arthur, it does not work for me. After clicking the button "Set record source" from /cgi-bin/koha/cataloguing/record_source.pl?biblionumber=111, I'm getting: /cgi-bin/koha/cataloguing/record_source.pl?biblionumber=&record_source_id=4&save=Set+record+source Note, without biblionumber. And in record_source.pl you are not checking if the $biblionumber is present and correct nor if Koha::Biblios->find gave you a valid object. As a result my ktd exploded with: Can't call method "metadata" on an undefined value at /kohadevbox/koha/cataloguing/record_source.pl line 45 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 --- Comment #22 from Janusz Kaczmarek <januszop@gmail.com> --- After the recent correction of 2024-07-12 13:01 UTC it seems to work. But there is a serious issue with deleting the record source--when you delete a record source already used in some records, it seem delete also biblio_metadata rows linked with that biblio_metadata.record_source_id. The biblio and biblioitems rows remain, but biblio_metadata is gone. Could you confirm it please? Is it universal problem or is it connected only with some local circumstances? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37419 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37419 [Bug 37419] Deleting the record source deletes the associated biblio_metadata rows. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37258 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168897|0 |1 is obsolete| | Attachment #168898|0 |1 is obsolete| | Attachment #168899|0 |1 is obsolete| | Attachment #168902|0 |1 is obsolete| | --- Comment #23 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 169268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169268&action=edit Bug 36372: Cypress tests Signed-off-by: Janusz Kaczmarek <januszop@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 --- Comment #24 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 169269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169269&action=edit Bug 36372: provide an interface to set the source of a record from the staff interface Test plan : - apply Cypress patch - running cypress patch in ktd will fail - apply both code patches, cypress tests will pass - open any record in the staff interface - with superlibrarian user, click on the "Edit" button group. - you should be able to click on the "Set record source" below the "Edit record button". - you will be given a form to choose between any defined record source. If none defined there would be a link to configure the record sources. - change a users permissions to have cataloguing permissions but without the "set_record_source" permissions. - login as this forementionned user and go to any record view. - the "Set record source" button should now be greyed out and not possible to click.# Signed-off-by: Janusz Kaczmarek <januszop@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 --- Comment #25 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 169270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169270&action=edit Bug 36372: trigger a record indexing when the record source is set Signed-off-by: Janusz Kaczmarek <januszop@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 --- Comment #26 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 169271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169271&action=edit Bug 36372: (QA follow-up) perltidy cataloguing/record_source.pl, fix permissions issues, add html filters to new template# Signed-off-by: Janusz Kaczmarek <januszop@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 --- Comment #27 from Janusz Kaczmarek <januszop@gmail.com> --- Signed-off, but still some issues with tidiness: WARN cataloguing/record_source.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 2) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 --- Comment #28 from Janusz Kaczmarek <januszop@gmail.com> --- Arthur, just another remark. It seems that the template cataloguing/record_source.tt was prepared to display the current record source if already set. But it is not shown because the current record source (current_source.record_source_id) is not passed in the template call. The following change would be a possible fix: diff --git a/cataloguing/record_source.pl b/cataloguing/record_source.pl index 1005e1aa1f..61579ef5d6 100755 --- a/cataloguing/record_source.pl +++ b/cataloguing/record_source.pl @@ -62,6 +62,7 @@ my $record_sources = Koha::RecordSources->search(); $template->param( biblio => $biblio, record_sources => $record_sources, + current_source => { record_source_id => $biblio->metadata->record_source_id }, ); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 --- Comment #29 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 169542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169542&action=edit Bug 36372: (QA followup) pass current record-source to template while editing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169542|0 |1 is obsolete| | --- Comment #30 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 169831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169831&action=edit Bug 36372: (QA followup) pass current record-source to template while editing Signed-off-by: Janusz Kaczmarek <januszop@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169268|0 |1 is obsolete| | Attachment #169269|0 |1 is obsolete| | Attachment #169270|0 |1 is obsolete| | Attachment #169271|0 |1 is obsolete| | Attachment #169831|0 |1 is obsolete| | --- Comment #31 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172369&action=edit Bug 36372: Cypress tests Signed-off-by: Janusz Kaczmarek <januszop@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 --- Comment #32 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172370&action=edit Bug 36372: provide an interface to set the source of a record from the staff interface Test plan : - apply Cypress patch - running cypress patch in ktd will fail - apply both code patches, cypress tests will pass - open any record in the staff interface - with superlibrarian user, click on the "Edit" button group. - you should be able to click on the "Set record source" below the "Edit record button". - you will be given a form to choose between any defined record source. If none defined there would be a link to configure the record sources. - change a users permissions to have cataloguing permissions but without the "set_record_source" permissions. - login as this forementionned user and go to any record view. - the "Set record source" button should now be greyed out and not possible to click.# Signed-off-by: Janusz Kaczmarek <januszop@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 --- Comment #33 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172371&action=edit Bug 36372: Fix style issues in dropdown Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #34 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- A few remarks: * I don't think we should introduce a new set of .pl+.tt this should be handled in a simple modal. * The new page style is weird. Maybe a side-effect of the move to Bootstrap 5, cannot tell. * The form for setting the record source is sending a GET (should be post) * The form for setting the record source is not passing a CSRF token It otherwise works as expected. My follow-up just makes it look the same as the rest of the dropdown (again, bootstrap 5 change side-effect). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Koha collecto <koha@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@collecto.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 --- Comment #35 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 176743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176743&action=edit Bug 36372: (QA follow-up) moving specific .pl and .tt to a modal. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 --- Comment #36 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 176744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176744&action=edit Bug 36372: (QA follow-up) fix Cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #37 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Hello, It's been a while :) I've made the advised changes and moved everything to a modal and to detail.pl script. Best wishes for 2025, Arthur -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #38 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- have a bit of reworking to do on this one (squashing) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 --- Comment #39 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- I will have to squash because after rework, some new pl and tt were removed (made as a modal instead). QA scripts complaining, have to squash and push-force. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172369|0 |1 is obsolete| | Attachment #172370|0 |1 is obsolete| | Attachment #172371|0 |1 is obsolete| | Attachment #176743|0 |1 is obsolete| | Attachment #176744|0 |1 is obsolete| | --- Comment #40 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 177467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177467&action=edit Bug 36372: Cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 --- Comment #41 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 177468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177468&action=edit Bug 36372: provide an interface to set the source of a record from the staff interface Test plan : - apply Cypress patch - running cypress patch in ktd will fail - apply code patches, cypress tests will pass - open any record in the staff interface - with superlibrarian user, click on the "Edit" button group. - you should be able to click on the "Set record source" below the "Edit record button". - you will be given a form to choose between any defined record source. If none defined there would be a link to configure the record sources. - change a users permissions to have cataloguing permissions but without the "set_record_source" permissions. - login as this forementionned user and go to any record view. - the "Set record source" button should now be greyed out and not possible to click. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 --- Comment #42 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Squashed done, sorry for squashing but had to do it to make qa scripts happy. Waiting for signoff/qa -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177467|0 |1 is obsolete| | --- Comment #43 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 178705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178705&action=edit Bug 36372: Cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177468|0 |1 is obsolete| | --- Comment #44 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 178706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178706&action=edit Bug 36372: provide an interface to set the source of a record from the staff interface Test plan : - apply Cypress patch - running cypress patch in ktd will fail - apply code patches, cypress tests will pass - open any record in the staff interface - with superlibrarian user, click on the "Edit" button group. - you should be able to click on the "Set record source" below the "Edit record button". - you will be given a form to choose between any defined record source. If none defined there would be a link to configure the record sources. - change a users permissions to have cataloguing permissions but without the "set_record_source" permissions. - login as this forementionned user and go to any record view. - the "Set record source" button should now be greyed out and not possible to click. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37258 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37258 [Bug 37258] Locked records can still be modified/deleted by an unauthorized librarian with merge and in advanced editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 --- Comment #45 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- rebased on top of tidy commits using auto-rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Clemens Tubach <clemens.tubach@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clemens.tubach@kit.edu --- Comment #46 from Clemens Tubach <clemens.tubach@kit.edu> --- (In reply to Arthur Suzuki from comment #44)
Created attachment 178706 [details] [review] Bug 36372: provide an interface to set the source of a record from the staff interface
Test plan : - apply Cypress patch - running cypress patch in ktd will fail - apply code patches, cypress tests will pass - open any record in the staff interface - with superlibrarian user, click on the "Edit" button group. - you should be able to click on the "Set record source" below the "Edit record button". - you will be given a form to choose between any defined record source. If none defined there would be a link to configure the record sources. - change a users permissions to have cataloguing permissions but without the "set_record_source" permissions. - login as this forementionned user and go to any record view. - the "Set record source" button should now be greyed out and not possible to click.
After applying the code patch, cypress tests (Catalogue/Detail_spec.ts) fail again -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Bug 36372 depends on bug 37419, which changed state. Bug 37419 Summary: Deleting the record source deletes the associated biblio_metadata rows https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37419 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42625 CC| |andrew@bywatersolutions.com --- Comment #47 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- See Bug 42625, which adds the ability to set record source via batch modification templates. The code here would still be simpler for changing the source on just one record. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org