https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17647 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14598 Assignee|chris@bigballofwax.co.nz |tomascohen@gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17647 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 57576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57576&action=edit Bug 17647: Remove itemtype-related CancelReceipt.t warnings This patch makes t/db_dependent/Acquisition/CancelReceipt.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Acquisition/CancelReceipt.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Acquisition/CancelReceipt.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17647 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57576|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57591&action=edit Bug 17647: Remove itemtype-related CancelReceipt.t warnings This patch makes t/db_dependent/Acquisition/CancelReceipt.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Acquisition/CancelReceipt.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Acquisition/CancelReceipt.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17647 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17647 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes.