[Bug 8210] New: Headings in OPAC bib details should link to authority record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 Priority: P5 - low Change sponsored?: --- Bug ID: 8210 Assignee: jcamins@cpbibliography.com Summary: Headings in OPAC bib details should link to authority record Severity: enhancement Classification: Unclassified OS: All Reporter: jcamins@cpbibliography.com Hardware: All Status: ASSIGNED Version: master Component: OPAC Depends on: 5888 Product: Koha There should be a link to used authority records from the bibliographic details display. This is already done in 5888 for the "normal" display. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8212 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 11359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11359&action=edit Bug 8210: add links to authorities to headings in OPAC At the moment, there is no way to get to an authority record from a bib record that uses it other than doing a new search on the authority file. This patch adds a link (a cute little magnifying glass) to linked authority records on the OPAC detail view for MARC21 and NORMARC with XSLT enabled. A follow-up patch will add the link to regular mode. Because UNIMARC handles authorities differently, the link is not added to the XSLT. Test plan: 1) Set OPACXSLTDetailsDisplay to 'default' 2) View a record that has some headings that are linked to authority records in the OPAC (easiest way to find a record like that is to edit a record and add some headings using the thesaurus plugin) 3) Observe the cute little magnifying glass links to the authority. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 11474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11474&action=edit screenshot Hi Jared, features works nicely. Only request I have is a little space between the magnifying glass and the term. I think we are also missing a space between the relator code and the term, but this can go on a separate bug. I love that the icon has a class, so I can hide it if a library doesn't like it: .authlink {display:none;} -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11359|0 |1 is obsolete| | --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 11480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11480&action=edit Bug 8210: add links to authorities to headings in OPAC At the moment, there is no way to get to an authority record from a bib record that uses it other than doing a new search on the authority file. This patch adds a link (a cute little magnifying glass) to linked authority records on the OPAC detail view for MARC21 and NORMARC with XSLT enabled. A follow-up patch will add the link to regular mode. Because UNIMARC handles authorities differently, the link is not added to the XSLT. Test plan: 1) Set OPACXSLTDetailsDisplay to 'default' 2) View a record that has some headings that are linked to authority records in the OPAC (easiest way to find a record like that is to edit a record and add some headings using the thesaurus plugin) 3) Observe the cute little magnifying glass links to the authority. Revised version of the patch adds a space between the heading and the magnifying glass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11480|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 11519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11519&action=edit [SIGNED-OFF] Bug 8210: add links to authorities to headings in OPAC At the moment, there is no way to get to an authority record from a bib record that uses it other than doing a new search on the authority file. This patch adds a link (a cute little magnifying glass) to linked authority records on the OPAC detail view for MARC21 and NORMARC with XSLT enabled. A follow-up patch will add the link to regular mode. Because UNIMARC handles authorities differently, the link is not added to the XSLT. Test plan: 1) Set OPACXSLTDetailsDisplay to 'default' 2) View a record that has some headings that are linked to authority records in the OPAC (easiest way to find a record like that is to edit a record and add some headings using the thesaurus plugin) 3) Observe the cute little magnifying glass links to the authority. Revised version of the patch adds a space between the heading and the magnifying glass. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch works nicely. If a library does not like to see the magnifying glass/link to the authority, it's easy to disable it by adding the line .authlink {display:none;} to OpacUserCSS. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 11584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11584&action=edit Bug 8210: add links to authorities in normal mode headings Cherry-picked from BibLibre's work on bug 5888: opac-detail subject/author links improvements Added a link to opac-authoritiesdetail.pl when possible. Only affects 'Normal view'. Does not affect XSLT display. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Second patch requires an additional signoff. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5888 Depends on|5888 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- I like the little icon! Works well, signed off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11584|0 |1 is obsolete| | --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11591&action=edit Bug 8210: add links to authorities in normal mode headings Cherry-picked from BibLibre's work on bug 5888: opac-detail subject/author links improvements Added a link to opac-authoritiesdetail.pl when possible. Only affects 'Normal view'. Does not affect XSLT display. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |mtj@kohaaloha.com --- Comment #8 from Mason James <mtj@kohaaloha.com> ---
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Jared, i get some conflicts applying both patches to master (ce03893) can you rebase, then ping me for QA? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11519|0 |1 is obsolete| | Attachment #11591|0 |1 is obsolete| | --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12261&action=edit Bug 8210: add links to authorities to headings in OPAC At the moment, there is no way to get to an authority record from a bib record that uses it other than doing a new search on the authority file. This patch adds a link (a cute little magnifying glass) to linked authority records on the OPAC detail view for MARC21 and NORMARC with XSLT enabled. A follow-up patch will add the link to regular mode. Because UNIMARC handles authorities differently, the link is not added to the XSLT. Test plan: 1) Set OPACXSLTDetailsDisplay to 'default' 2) View a record that has some headings that are linked to authority records in the OPAC (easiest way to find a record like that is to edit a record and add some headings using the thesaurus plugin) 3) Observe the cute little magnifying glass links to the authority. Revised version of the patch adds a space between the heading and the magnifying glass. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch works nicely. If a library does not like to see the magnifying glass/link to the authority, it's easy to disable it by adding the line .authlink {display:none;} to OpacUserCSS. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 --- Comment #10 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12262&action=edit Bug 8210: add links to authorities in normal mode headings Cherry-picked from BibLibre's work on bug 5888: opac-detail subject/author links improvements Added a link to opac-authoritiesdetail.pl when possible. Only affects 'Normal view'. Does not affect XSLT display. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |mtj@kohaaloha.com --- Comment #11 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #8)
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
patch looks good, passing QA… $ koha-qa.pl -c 2 testing 2 commit(s) (applied to commit ce03893) * f0af280 Bug 8210: add links to authorities in normal mode headings C4/Biblio.pm koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt * 2a60d49 Bug 8210: add links to authorities to headings in OPAC koha-tmpl/opac-tmpl/prog/en/css/opac.css koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl koha-tmpl/opac-tmpl/prog/en/xslt/NORMARCslim2OPACDetail.xsl * C4/Biblio.pm OK * koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt OK * koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl OK * koha-tmpl/opac-tmpl/prog/en/xslt/NORMARCslim2OPACDetail.xsl OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_10 --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master I don't understand why you say: Because UNIMARC handles authorities differently, the link is not added to the XSLT. In UNIMARC, the $9 also contains the authority. The templates <xsl:template name="tag_7xx"> and <xsl:call-template name="tag_subject"> in UNIMARCslimUtils.xsl could be used for that unless I'm missing something. Your opinion ? (& follow-up welcomed ;-) ) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org