https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 161997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161997&action=edit Bug 36063: Add holds to pull info to staff interface main page To test: 1. APPLY PATCH, restart_all 2. Make some holds 3. Go to the staff interface home page, you should see 'New holds to pull: X'. 4. Check those holds in so they are waiting. Now they should not be counted against the number you see on the staff main page. 5. Log in as a staff member with Staff access but without circulate_remaining_permissions. 6. You should not see the 'New holds to pull: X' line. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36064 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 [Bug 36064] Add Holds with cancellation requests info to intranet-main page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161997|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 162000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162000&action=edit Bug 36063: Add holds to pull info to staff interface main page To test: 1. APPLY PATCH, restart_all 2. Make some holds 3. Go to the staff interface home page, you should see 'New holds to pull: X'. 4. Check those holds in so they are waiting. Now they should not be counted against the number you see on the staff main page. 5. Log in as a staff member with Staff access but without circulate_remaining_permissions. 6. You should not see the 'New holds to pull: X' line. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Christopher Brannon from comment #3)

I placed a couple holds for the patron. One that was available at the current logged in library, and one that was only at another library. Both holds show up in the counter. I never liked the holds to pull list, because in this case it shows everything regardless of location. The counter should only be based on the logged in library, and you should either base it off the holds queue or, if you are going to use the holds to pull list, filter the list for the current library.

Personally, we hide this list because of the above reason. The queue for the logged in library would be more reliable.

I would expect both to always show up. Since the Holds to pull report ( pendingreserves.pl ) cannot be filtered by branch I would not expect this to filter by branch either. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Christopher Brannon from comment #5)

Which is why I recommend basing this off the holds queue. This is what I am doing via jQuery right now. This is also consistent with how the rest of the alerts work. Staff don't need to be looking at alerts that don't concern them.

I filed Bug 36073, as it would be good to add this for the 'Holds queue' as well. I don't love the idea of adding a sys pref to show or hide each of these from the main page and it can be hidden with CSS if needed. Setting this back to 'Signed off'. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- In my system with custom test data I'm seeing a mismatch between the count on the home page and the number of holds returned by pendingreserves.pl. I see that there is a lot of extra filtering going on in that script, so I wonder if the simple 'Koha::Holds->search( found => undef )' is not counting too many holds. The other issue I see is that pendingreserves.pl has a default date range which makes the user's experience of what the home page reports different from what they see on that page by default. In my system the home page reports 59 pending holds, pendingreserves.pl reports zero holds by default, and with an all-inclusive date range returns 31 holds. - I think the home page count should definitely use the same (non-date) limits, but should it also use the same date limits? - Alternatively, should we remove the default date limit on pendingreserves.pl? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190830&action=edit Bug 36063: Add local_holds_to_pull and adjust filters -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162000|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190834|0 |1 is obsolete| | --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190843&action=edit Bug 36063: Add local_holds_to_pull and adjust filters To test: 1. APPLY PATCH, restart_all 2. Make some holds 3. Go to the staff interface home page, you should see 'New holds to pull: X'. 4. Check those holds in so they are waiting. Now they should not be counted against the number you see on the staff main page. 5. Log in as a staff member with Staff access but without circulate_remaining_permissions. 6. You should not see the 'New holds to pull: X' line. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190843|0 |1 is obsolete| | --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190844&action=edit Bug 36063: Add local_holds_to_pull and adjust filters To test: 1. APPLY PATCH, restart_all 2. Make some holds 3. Go to the staff interface home page, you should see 'New holds to pull: X'. 4. Check those holds in so they are waiting. Now they should not be counted against the number you see on the staff main page. 5. Log in as a staff member with Staff access but without circulate_remaining_permissions. 6. You should not see the 'New holds to pull: X' line. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190846|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 190848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190848&action=edit Bug 36063: Add local_holds_to_pull and adjust filters To test: 1. APPLY PATCH, restart_all 2. Make some holds 3. Go to the staff interface home page, you should see 'New holds to pull: X'. 4. Check those holds in so they are waiting. Now they should not be counted against the number you see on the staff main page. 5. Log in as a staff member with Staff access but without circulate_remaining_permissions. 6. You should not see the 'New holds to pull: X' line. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add holds to pull info to |Add holds to pull |staff interface start page |notification to staff | |interface home page Text to go in the|This enhancement adds |This enhancement adds a release notes|"Holds to pull: All |"Holds to pull: All |libraries: X" to the staff |libraries: X" notification |interface home page. |to the staff interface home | |page. |Notes: | |- This only shows if the |Notes: |staff patron has the right |- This only shows if the |permissions. |staff patron has the right |- Currently it shows the |permissions. |holds to pull for all |- Currently it only shows |libraries, and doesn't show |the holds to pull for all |the number for the library |libraries, and doesn't show |you are logged in as |the number for the library | |you are logged in as -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick@bywatersolutions.com --- Comment #17 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- - Commit title seems to be squashed? - $reserves_to_pull_from - maybe $date_to_pull_holds_from - not clear its a date with current name - 'item.homebranch' => C4::Context->userenv()->{'branch'}, - in a floating system this feels inaccurate - maybe it should be holding branch? And what about items in transit? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- This is great :D Note that it is related to Bug 36073 but it may be pushed independently right ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 --- Comment #20 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201466&action=edit Bug 36063: Add local_holds_to_pull and adjust filters To test: 1. APPLY PATCH, restart_all 2. Make some holds 3. Go to the staff interface home page, you should see 'New holds to pull: X'. 4. Check those holds in so they are waiting. Now they should not be counted against the number you see on the staff main page. 5. Log in as a staff member with Staff access but without circulate_remaining_permissions. 6. You should not see the 'New holds to pull: X' line. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 --- Comment #22 from David Nind <david@davidnind.com> --- Created attachment 201470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201470&action=edit Bug 36063: Add local_holds_to_pull and adjust filters To test: 1. APPLY PATCH, restart_all 2. Make some holds 3. Go to the staff interface home page, you should see 'New holds to pull: X'. 4. Check those holds in so they are waiting. Now they should not be counted against the number you see on the staff main page. 5. Log in as a staff member with Staff access but without circulate_remaining_permissions. 6. You should not see the 'New holds to pull: X' line. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- This is a really nice idea, but unfortunately it's still missing a lot of cases that the Holds to Pull page accounts for: - It should exclude suspended holds - The Holds to Pull page only lists distinct biblio records that have active, pending holds, so for this to match, it would also need to count only the distinct biblio records, not the total number of holds - The Holds to Pull page also excludes holds that aren't currently fillable by any available items (whether due to status or circ rules) - It should account for item groups (see pendingreserves.pl lines 186-187) Finally, $local_holds_to_pull isn't catching bib-level holds, even if the only available item is at the current branch. It's only catching item-level holds, because that's the only case where a pending hold will have an assigned itemnumber that would come up in the join. -- You are receiving this mail because: You are watching all bug changes.