[Bug 38472] New: exportColumns hard-coded in patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38472 Bug ID: 38472 Summary: exportColumns hard-coded in patron categories Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 36640 categories.js has exportColumns: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12], It must use .noExport instead of the IDs. We are building the column list depending on syspref so the ID cannot be hard-coded. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 [Bug 36640] Upgrade DataTables from 1.13.6 to 2.x -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38472 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38436 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38472 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|36640 |26553 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26553 [Bug 26553] Remove KohaTable (columns_settings.inc) and use kohaTable (datatables.js) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 [Bug 36640] Upgrade DataTables from 1.13.6 to 2.x -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38472 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38472 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177260&action=edit Bug 38472: Remove kohaTable's exportColumns option We hardcode the id of the columns to export, we should use .noExport instead on the columns we do not want to export. Test plan: Confirm that the columns exported on the acqui/basket, admin/categories and admin/restrictions pages are the same with and without this patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38472 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38472 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177260|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177276&action=edit Bug 38472: Remove kohaTable's exportColumns option We hardcode the id of the columns to export, we should use .noExport instead on the columns we do not want to export. Test plan: Confirm that the columns exported on the acqui/basket, admin/categories and admin/restrictions pages are the same with and without this patch. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38472 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177277&action=edit Bug 38472: (follow-up) Adding and removing a few noExport classes I think only the "Actions" column on the restrictions page should be excluded from export. On the acquisitions basket page we need it on the "Place hold" column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38472 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38472 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177276|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 177308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177308&action=edit Bug 38472: Remove kohaTable's exportColumns option We hardcode the id of the columns to export, we should use .noExport instead on the columns we do not want to export. Test plan: Confirm that the columns exported on the acqui/basket, admin/categories and admin/restrictions pages are the same with and without this patch. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38472 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177277|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 177309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177309&action=edit Bug 38472: (follow-up) Adding and removing a few noExport classes I think only the "Actions" column on the restrictions page should be excluded from export. On the acquisitions basket page we need it on the "Place hold" column. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38472 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Summary|exportColumns hard-coded in |exportColumns hard-coded in |patron categories |patron categories, patron | |restriction types, and | |basket tables --- Comment #6 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Before applying the patches (and without the dependencies), use the 'Export' option for these tables: . Administration > Patrons and circulation > Patron categories . Administration > Patrons and circulation > Patron restriction types . Acquisitions > [Vendor] > [A basket for a vendor with an order] (You need to add an order to a basket) 2. Look at the columns exported in the files and compare to the columns shown in the browser for the tables - they don't match up. 3. Apply the patches (and dependencies). 4. Refresh the pages and export the tables again. 5. Note that: - The columns in the exported files match what is shown for the tables - The columns you would expect to be exported are exported, and columns such as Actions (Patron categories and Patron restriction types) or Place hold, Modify and Cancel order (for a basket) are not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38472 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38472 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177308|0 |1 is obsolete| | --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177322&action=edit Bug 38472: Remove kohaTable's exportColumns option We hardcode the id of the columns to export, we should use .noExport instead on the columns we do not want to export. Test plan: Confirm that the columns exported on the acqui/basket, admin/categories and admin/restrictions pages are the same with and without this patch. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38472 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177309|0 |1 is obsolete| | --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177323&action=edit Bug 38472: (follow-up) Adding and removing a few noExport classes I think only the "Actions" column on the restrictions page should be excluded from export. On the acquisitions basket page we need it on the "Place hold" column. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38472 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Passed QA |BLOCKED --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- PQA here, but I will also set to BLOCKED until the dependencies can move. I signed off on both of them, so cannot QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38472 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38472 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177322|0 |1 is obsolete| | Attachment #177323|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179120&action=edit Bug 38472: Remove kohaTable's exportColumns option We hardcode the id of the columns to export, we should use .noExport instead on the columns we do not want to export. Test plan: Confirm that the columns exported on the acqui/basket, admin/categories and admin/restrictions pages are the same with and without this patch. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38472 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179121&action=edit Bug 38472: (follow-up) Adding and removing a few noExport classes I think only the "Actions" column on the restrictions page should be excluded from export. On the acquisitions basket page we need it on the "Place hold" column. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38472 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38472 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38472 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38472 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 26553 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38472 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #14 from David Nind <david@davidnind.com> --- Bug fix, no changes required to the manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38472 Bug 38472 depends on bug 26553, which changed state. Bug 26553 Summary: Remove KohaTable (columns_settings.inc) and use kohaTable (datatables.js) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26553 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org