[Bug 12692] New: Markup improvements to holds awaiting pickup report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12692 Bug ID: 12692 Summary: Markup improvements to holds awaiting pickup report Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/circ/waitingreserves.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Proposed changes: - add output of subtitle - correct output of email address - fix some formatting issues - output library name instead of code -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12692 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12523 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12692 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12692 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 30469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30469&action=edit Bug 12692 - Markup improvements to holds awaiting pickup report This patch makes some minor updates to the output of the holds awaiting pickup report. To test you should have several holds which are marked as "waiting," including some which have been waiting longer than the number of days specified in the ReservesMaxPickUpDelay system preference. - Go to Circulation -> Holds awaiting pickup - In both the "waiting" and "over" tabs, confirm that titles display any associated subtitle - Confirm that library name is shown instead of library code - Confirm that the patron name mailto: link works correctly -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12692 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12692 --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 32734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32734&action=edit Bug 12692 - Markup improvements to holds awaiting pickup report This patch makes some minor updates to the output of the holds awaiting pickup report. To test you should have several holds which are marked as "waiting," including some which have been waiting longer than the number of days specified in the ReservesMaxPickUpDelay system preference. - Go to Circulation -> Holds awaiting pickup - In both the "waiting" and "over" tabs, confirm that titles display any associated subtitle - Confirm that library name is shown instead of library code - Confirm that the patron name mailto: link works correctly Signed-off-by: Frederic Demians <f.demians@tamil.fr> Works as described: subtitle displayes (if mapping defined), library name instead of code, and email as clickable mailto. Remark 1: As for bug 13083, subtitle display is not as good in UNIMARC than in MARC21, since subtitle is not separated from title by ':'. Remark 2: 'subtitle' field is retrieved from a field mapping. Taking a look at C4::Biblio::GetRecordValue, one see that the fieldmapping is directly queried. There isn't any caching system, like for frameworks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12692 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30469|0 |1 is obsolete| | CC| |frederic@tamil.fr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12692 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12692 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32734|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32737&action=edit [PASSED QA] Bug 12692 - Markup improvements to holds awaiting pickup report This patch makes some minor updates to the output of the holds awaiting pickup report. To test you should have several holds which are marked as "waiting," including some which have been waiting longer than the number of days specified in the ReservesMaxPickUpDelay system preference. - Go to Circulation -> Holds awaiting pickup - In both the "waiting" and "over" tabs, confirm that titles display any associated subtitle - Confirm that library name is shown instead of library code - Confirm that the patron name mailto: link works correctly Signed-off-by: Frederic Demians <f.demians@tamil.fr> Works as described: subtitle displayes (if mapping defined), library name instead of code, and email as clickable mailto. Remark 1: As for bug 13083, subtitle display is not as good in UNIMARC than in MARC21, since subtitle is not separated from title by ':'. Remark 2: 'subtitle' field is retrieved from a field mapping. Taking a look at C4::Biblio::GetRecordValue, one see that the fieldmapping is directly queried. There isn't any caching system, like for frameworks. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described and passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12692 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org