https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32045 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org --- Comment #2 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- I think this might actually be due to the item type from the staged file not being correctly used to meet the itype requirement on the Item Information tab. I was getting the same error you pasted on trying to add one of three records from a MARC file before I touched anything on the accounting tab (following the test plan on bug 32166). When I selected an item type, the error cleared and the order saved. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32045 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 143905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143905&action=edit Bug 32045: Use bootstrap tabs to select item tab When the form to add orders from a staged file is validated, we use toptabs functionality to switch to the item tab if there are missing fields. The display now uses bootstrap tabs, so the JS is throwing an error: Uncaught Error: cannot call methods on tabs prior to initialization; attempted to call method 'option' This patch simply switches the call to switch tabs To test: 1 - Stage a file for import 2 - Either use Marc(Item)FieldsToOrder to populate the orders or select a budget on the third tab 3 - View the second tab, items info, confirm itemtype is required, but don't populate it 4 - Attempt to save order, nothing happens 5 - Check the JS console (F12) 6 - Note the error: Uncaught Error: cannot call methods on tabs prior to initialization; attempted to call method 'option' 7 - Apply patch 8 - Cancel and add from staged file again 9 - Select a budget and save 10 - You now get an error popup: Some required item subfields are not set 11 - Confirm after the error you are shown the items tab 12 - Select itemtype 13 - Save 14 - Confirm orders added successfully -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32045 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32045 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143905|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143909&action=edit Bug 32045: Use bootstrap tabs to select item tab When the form to add orders from a staged file is validated, we use toptabs functionality to switch to the item tab if there are missing fields. The display now uses bootstrap tabs, so the JS is throwing an error: Uncaught Error: cannot call methods on tabs prior to initialization; attempted to call method 'option' This patch simply switches the call to switch tabs To test: 1 - Stage a file for import 2 - Either use Marc(Item)FieldsToOrder to populate the orders or select a budget on the third tab 3 - View the second tab, items info, confirm itemtype is required, but don't populate it 4 - Attempt to save order, nothing happens 5 - Check the JS console (F12) 6 - Note the error: Uncaught Error: cannot call methods on tabs prior to initialization; attempted to call method 'option' 7 - Apply patch 8 - Cancel and add from staged file again 9 - Select a budget and save 10 - You now get an error popup: Some required item subfields are not set 11 - Confirm after the error you are shown the items tab 12 - Select itemtype 13 - Save 14 - Confirm orders added successfully Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32045 --- Comment #6 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Katrin Fischer from comment #5)

Thx for investigating!

Thank you for filing a bug that helped explain why the test plan for something else was giving me trouble :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32045 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |m.de.rooy@rijksmuseum.nl --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QAing -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32045 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32045 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.