https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105280|0 |1 is obsolete| | --- Comment #2 from Mason James <mtj@kohaaloha.com> --- Created attachment 105282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105282&action=edit Bug 25591 - Update debian/control for debian 10 this patch updates the debian/control for koha 20.05 on debian 10 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24167 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24167 [Bug 24167] We should support installation on Debian 10 [OMNIBUS] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update debian/control for |Update list-deps for Debian |debian 10 |10 and Ubuntu 20.04 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- What is the test plan? Just having the packages install successfully? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105312|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 105326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105326&action=edit Bug 25591 - Update list-deps for Debian 10 and Ubuntu 20.04 This patch removes version-specific packages from the debian/control file, which fixes a bug where koha-common can only be installed on the debian version that the package was built on Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105334|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 105336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105336&action=edit list-deps-debian9-master-with-25591 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 105338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105338&action=edit list-deps-debian10-master-with-25591 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 105340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105340&action=edit list-deps-ubuntu20.04-master-with-25591 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #19)

In case that helps reviewing, here attached are the results of my attempt to sign off. The list-deps was generated with and without the patch on Debian 9, Debian 10, Ubuntu 20.04.

There are sorted and trailing space was removed to clean the diffs.

As expected, packages perl-modules-5.XX and libperl5.XX aren't in the list anymore.

That's the only difference, no sign of collateral damage.

Thanks, Victor. I think the patch is incorrect, in the sense that what we need is to map perl dependencies to Debian package providing it. So in order to support more Debian versions, the generated output should have pipe-separated values for those libraries that map into perl-modules or perl-modules-<version>. so we *should* expect a line containing: perl-modules | perl-modules-5.22 | perl-modules-5.24 | perl-modules-5.28 | perl-modules-5.30 unless there's syntax for specifying regexps in module names, I belive we should stick with the current approach for this release, and clean things next. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This needs to be run in the lowest supported Debian version. So stretch stuffs are to be pulled in this case. Then we patch for higher versions. This is what we are doing in list-deps. And sometimes the resulting control file might be patched for simplicity. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 --- Comment #23 from Mason James <mtj@kohaaloha.com> --- (In reply to Tomás Cohen Arazi from comment #20)

so we *should* expect a line containing:

perl-modules | perl-modules-5.22 | perl-modules-5.24 | perl-modules-5.28 | perl-modules-5.30

hi Tomas, i did some experimenting and discovered that while explicitly listing all versions of perl-modules-5.XX in the control file, does work ...the control file can be simplified to just listing the 'perl-modules' virtual package debian will correctly pull the correct perl-modules-5.XX package, when installing perl-modules i've tested the simplified control file by building a package with it (on deb9), and successfully installing the package on deb9, deb10, deb11 and ubuntu 1804, 1910, 2004, 2010 you can test the package by running... # docker run -ti debian:testing bash echo 'deb [trusted=yes] http://apt.kohaaloha.com/koha-nightly dev main' > /etc/apt/sources.list.d/koha.list apt update apt install koha-common dpkg -l | grep koha-common ii koha-common 20.05.00.000~git+d9.20200523231519.38b762ea-1 all integrated (physical) library management system -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 105397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105397&action=edit Bug 25591: Update list-deps for Debian 10 and Ubuntu 20.04 This patch removes version-specific packages from the debian/control file, which fixes a bug where koha-common can only be installed on the debian version that the package was built on Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 --- Comment #26 from Mason James <mtj@kohaaloha.com> --- Created attachment 105408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105408&action=edit Bug 25591 - add libcpan-meta-perl to debina/control.in file this patch fixes an installation error on deb9 Can't locate object method "phases" via package "CPAN::Meta::Prereqs" at /usr/share/koha/lib/C4/Installer/PerlModules.pm line 55. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105397|0 |1 is obsolete| | --- Comment #28 from Mason James <mtj@kohaaloha.com> --- Created attachment 105450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105450&action=edit Bug 25591: Update list-deps for Debian 10 and Ubuntu 20.04 update list-deps for libcpan-meta-perl package -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25640 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25640 [Bug 25640] [OMNIBUS] Ubuntu 20.04 support -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 --- Comment #31 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Should it be backported to 20.05? Because it seems to be only in master. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Bug 25591 depends on bug 25607, which changed state. Bug 25607 Summary: Wrong behaviour about perl versions in list-deps https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25607 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.01 |20.11.00, 20.05.01, released in| |19.11.07 Status|Pushed to stable |Pushed to oldstable --- Comment #34 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.07, as recommended for Bug 22522 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #36 from Mason James <mtj@kohaaloha.com> --- (In reply to Aleisha Amohia from comment #34)

backported to 19.11.x for 19.11.07, as recommended for Bug 22522

this has been resolved now, closing -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26109 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 --- Comment #39 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Mason James from comment #37)

it will fix 19.05 installation errors on... deb 8, 10, 11 ubuntu 16.04, 18.04, 20.04, 20.10

😱😱😱 okay that's a big deal.

ps: i have applied this patch to the last 3 19.05.x package releases

Thanks a lot! Ok backporting. Rats! Conflict which I can't resolve: Next is the conflict part in the diff3 conflict style. Here is the structure: <<<<<<< HEAD here is the code in 19.05.x before the cherry-pick ||||||| parent of 248978bc62... Bug 25591: Update list-deps for Debian 10 and Ubuntu 20.04 here is the code in 19.11.x before the patch ======= here is the code in 19.11.x after the patch

...

...

...

...

...

> 248978bc62... Bug 25591: Update list-deps for Debian 10 and Ubuntu 20.04

<<<<<<< HEAD my $modules = C4::Installer::PerlModules->new(); my $prereqs = $modules->prereqs; foreach my $phase ($prereqs->phases) { foreach my $type ($prereqs->types_in($phase)) { my $reqs = $prereqs->requirements_for($phase, $type); ||||||| parent of 248978bc62... Bug 25591: Update list-deps for Debian 10 and Ubuntu 20.04 # Remove packages that are required/essential and always installed on # a Debian system. Debian packages should not have unversioned # dependencies on such packages. foreach my $line (@temp) { if ( $line ne "perl-base" ) { @lines = ( @lines, $line ); } } if ( exists $overrides{$module} ) { print "$overrides{$module}\n"; } elsif ( scalar(@lines) == 1 && $lines[0] ne "" ) { my $pkg = $lines[0]; print "$pkg\n"; } elsif ( scalar(@lines) > 1 ) { foreach my $pkg (@lines) { print " | " if ( $pkg ne $lines[0] ); print "$pkg"; print " | $pkg" . "-5.22" if ( $pkg eq "perl-modules" ); print " | $pkg" . "-5.24" if ( $pkg eq "perl-modules" ); } print "\n"; } elsif ( scalar(@temp) != 0 ) { ======= # Remove packages that are required/essential and always installed on # a Debian system. Debian packages should not have unversioned # dependencies on such packages. # skip perl-base and problematic version specific libperl* and # perl-module* packages (they get installed as deps. anyway) foreach my $line (@temp) { if ( $line ne "perl-base" and $line !~ /^libperl5\./ and $line !~ /^perl-modules-5\./ ) { @lines = ( @lines, $line ); } } if ( exists $overrides{$module} ) { print "$overrides{$module}\n"; } elsif ( scalar(@lines) == 1 && $lines[0] ne "" ) { my $pkg = $lines[0]; print "$pkg\n"; } elsif ( scalar(@lines) > 1 ) { foreach my $pkg (@lines) { print " | " if ( $pkg ne $lines[0] ); print "$pkg"; } print "\n"; } elsif ( scalar(@temp) != 0 ) {

...

...

...

...

...

> 248978bc62... Bug 25591: Update list-deps for Debian 10 and Ubuntu 20.04

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.