https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25760 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |15422 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25760 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105907&action=edit Bug 25760: (bug 15422 follow-up) Display record with hold ratio == 1 If the hold ratio is 1 (ie. number of holds == number of copies), we should display it if it's the value in the filter. Test plan: 1. Create bibliographic records with 1, 2 and 3 items 2. Place 1 hold on each of them 3. Go to the Hold ratios report and search with ratio = 1, 2 then 3 4. Place another hold on each of the record 5. Repeat 3 6. Make sure there is no regression in the test plan of bug 15422 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25760 Agnes Rivers-Moore <arm@hanover.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm@hanover.ca --- Comment #3 from Agnes Rivers-Moore <arm@hanover.ca> --- Kelly is right - we tested the same. This report is suddenly using "greater than" instead of "Greater than or equal" for any ratio value. It used to work correctly - that is, if you enter a ratio of 1 you get all titles with holds, ratio of 2 you get all titles with two or more holds per copy and so on. Hint from Equinox staff as a workaround for now - enter less than one (0.9) as the ratio to get all holds. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25760 --- Comment #5 from Agnes Rivers-Moore <arm@hanover.ca> --- Regret, just a librarian, not sysadmin. I will ask Equinox support if they can. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25760 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110053|0 |1 is obsolete| | --- Comment #7 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 110062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110062&action=edit Bug 25760: (follow-up) Restore use of ceil The ceiling function here ensures that partial copies are counted as full copies i.e. if we need half a book to reach the ratio, we should report 1 book, not 0 Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25760 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110062|0 |1 is obsolete| | --- Comment #9 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 110064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110064&action=edit Bug 25760: (follow-up) Restore use of ceil The ceiling function here ensures that partial copies are counted as full copies i.e. if we need half a book to reach the ratio, we should report 1 book, not 0 Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25760 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- This doesn't work - Titles with 1 item and any holds will show up for all ratios: ceil( 1/x - 1) = 1 True for positive integers x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25760 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 114978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114978&action=edit Bug 25760: [Alternate] (bug 15422 follow-up) Display record with hold ratio greater than or equal to the value entered On bug 15422 we made it so that only holds with copies to buy to acheive the holds ratio showed Users have reported that they want to see record where there are 0 copies to buy i.e. the holds ration matches the value entered This patch changes the criteria for returning holds to be if the ratio for a given title is equal to or greater then the ratio specified in the form I also renamed 'ratiocalc' to 'copies_to_buy' since that is what is contains Test plan: 1. Create bibliographic records with 1, 2 and 3 items 2. Place 1 hold on each of them 3. Go to the Hold ratios report and search with ratio = 1, 2 then 3 4. You expect to see: the title with 1 item with ratio 1 nothing otherwise 5. Place another hold on each of the record 6. Repeat 3 you expect to see: titles with 1 or 2 items with ratio 1 title with 1 item for ratio 2 nothing with ratio 3 7. Place another hold on each of the record 8. Repeat 3 you expect to see: titles with 1 or 2 or 3 items with ratio 1 title with 1 item or 2 items for ratio 2 nothing with ratio 3 9. Make sure there is no regression in the test plan of bug 15422 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25760 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110064|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25760 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@bugs.koha-c |nick@bywatersolutions.com |ommunity.org | QA Contact|nick@bywatersolutions.com | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25760 Frank Hansen <frank.hansen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114978|0 |1 is obsolete| | --- Comment #14 from Frank Hansen <frank.hansen@ub.lu.se> --- Created attachment 119324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119324&action=edit Bug 25760: [Alternate] (bug 15422 follow-up) Display record with hold ratio greater than or equal to the value entered On bug 15422 we made it so that only holds with copies to buy to acheive the holds ratio showed Users have reported that they want to see record where there are 0 copies to buy i.e. the holds ration matches the value entered This patch changes the criteria for returning holds to be if the ratio for a given title is equal to or greater then the ratio specified in the form I also renamed 'ratiocalc' to 'copies_to_buy' since that is what is contains Test plan: 1. Create bibliographic records with 1, 2 and 3 items 2. Place 1 hold on each of them 3. Go to the Hold ratios report and search with ratio = 1, 2 then 3 4. You expect to see: the title with 1 item with ratio 1 nothing otherwise 5. Place another hold on each of the record 6. Repeat 3 you expect to see: titles with 1 or 2 items with ratio 1 title with 1 item for ratio 2 nothing with ratio 3 7. Place another hold on each of the record 8. Repeat 3 you expect to see: titles with 1 or 2 or 3 items with ratio 1 title with 1 item or 2 items for ratio 2 nothing with ratio 3 9. Make sure there is no regression in the test plan of bug 15422 Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se> I was able to apply the patch and test it. Some comments. When I adding the third hold on each record in step 7, It will result in the following result: titles with 1 or 2 or 3 items with ratio 1 title with 1 items with ratio 2 because the title with 2 items will get a ratio of 1.50 and not 2. title with 1 items with with ratio 3 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25760 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119324|0 |1 is obsolete| | --- Comment #15 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 119385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119385&action=edit Bug 25760: [Alternate] (bug 15422 follow-up) Display record with hold ratio greater than or equal to the value entered On bug 15422 we made it so that only holds with copies to buy to acheive the holds ratio showed Users have reported that they want to see record where there are 0 copies to buy i.e. the holds ration matches the value entered This patch changes the criteria for returning holds to be if the ratio for a given title is equal to or greater then the ratio specified in the form I also renamed 'ratiocalc' to 'copies_to_buy' since that is what is contains Test plan: 1. Create bibliographic records with 1, 2 and 3 items 2. Place 1 hold on each of them 3. Go to the Hold ratios report and search with ratio = 1, 2 then 3 4. You expect to see: the title with 1 item with ratio 1 nothing otherwise 5. Place another hold on each of the record 6. Repeat 3 you expect to see: titles with 1 or 2 items with ratio 1 title with 1 item for ratio 2 nothing with ratio 3 7. Place another hold on each of the record 8. Repeat 3 you expect to see: titles with 1 or 2 or 3 items with ratio 1 title with 1 item or 2 items for ratio 2 nothing with ratio 3 9. Make sure there is no regression in the test plan of bug 15422 Comments from Frank Hansen: Some comments. When I adding the third hold on each record in step 7, It will result in the following result: titles with 1 or 2 or 3 items with ratio 1 title with 1 items with ratio 2 because the title with 2 items will get a ratio of 1.50 and not 2. title with 1 items with with ratio 3 Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25760 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Holds Ratio report is not |Holds ratio report is not |reporting on records with 1 |reporting on records with 1 |hold |hold -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25760 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119385|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 120750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120750&action=edit Bug 25760: [Alternate] (bug 15422 follow-up) Display record with hold ratio greater than or equal to the value entered On bug 15422 we made it so that only holds with copies to buy to acheive the holds ratio showed Users have reported that they want to see record where there are 0 copies to buy i.e. the holds ration matches the value entered This patch changes the criteria for returning holds to be if the ratio for a given title is equal to or greater then the ratio specified in the form I also renamed 'ratiocalc' to 'copies_to_buy' since that is what is contains Test plan: 1. Create bibliographic records with 1, 2 and 3 items 2. Place 1 hold on each of them 3. Go to the Hold ratios report and search with ratio = 1, 2 then 3 4. You expect to see: the title with 1 item with ratio 1 nothing otherwise 5. Place another hold on each of the record 6. Repeat 3 you expect to see: titles with 1 or 2 items with ratio 1 title with 1 item for ratio 2 nothing with ratio 3 7. Place another hold on each of the record 8. Repeat 3 you expect to see: titles with 1 or 2 or 3 items with ratio 1 title with 1 item or 2 items for ratio 2 nothing with ratio 3 9. Make sure there is no regression in the test plan of bug 15422 Comments from Frank Hansen: Some comments. When I adding the third hold on each record in step 7, It will result in the following result: titles with 1 or 2 or 3 items with ratio 1 title with 1 items with ratio 2 because the title with 2 items will get a ratio of 1.50 and not 2. title with 1 items with with ratio 3 Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25760 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25760 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.06 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #20 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.06 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25760 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #22 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.