[Bug 20080] New: Test for utf8mb4 encoding and collation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20080 Bug ID: 20080 Summary: Test for utf8mb4 encoding and collation Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: QA tools Assignee: jonathan.druart@bugs.koha-community.org Reporter: tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20080 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@bugs.koha-c |tomascohen@gmail.com |ommunity.org | Depends on| |18336 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Bug 18336 introduces the use of a different collation and encoding. The QA tools should be adapted if that bug gets its patches pushed to master. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20080 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20080 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 70861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70861&action=edit Bug 20080: Test for utf8mb4 encoding and collation Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20080 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset@hotmail.com --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Lacks test plan, and I did try to figure it out. I figure something about prove t/Perl.t in qa-test-tools, but I think there is a data/4/sql and/or data/5/sql file which may affect this, but I keep getting failures. I'm not sure what I'm doing wrong. Easier for you to explain how to prove this works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20080 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Those tests are failing in master already. So, to test: To test: - Apply this patch - Change kohastructure.sql with a fake commit creating a table "the old way" - Run: $ kshell k$ qa -c 1 -v 2 => SUCCESS: The QA script gives an error, due to bad encoding/collation - Add a new commit fixing the encoding/collation - Run: $ kshell k$ qa -c 2 -v 2 => SUCCESS: No encoding/collation problems reported! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20080 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20080 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70861|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 70957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70957&action=edit Bug 20080: Test for utf8mb4 encoding and collation Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20080 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 70958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70958&action=edit Bug 20080: Followup: corrected unless/if logic Changed unless to if, because unless was the wrong logic. TEST PLAN --------- 1) Run the following commands on a kohadev box: cd ~/qa-test-tools git pull git checkout -b bug_20080 origin/master git bz apply 20080 cd ~/kohaclone git pull git checkout -b bug_20080 origin/master git bz apply 18336 2) Edit ~/kohaclone/installer/data/mysql/kohastructure.sql changing CHARSET and COLLATE on a table to just utf8, instead of the utf8mb variation it is. 3) Run the following commands: git add installer/data/mysql/kohastructure.sql git commit -- doesn't matter what the commit message is. 4) Run the following commands: kshell qa -v 2 -c 1 -- this should fail with a collation problem. 5) Edit ~/kohaclone/installer/data/mysql/kohastructure.sql changing CHARSET and COLLATE on a table back to the utf8mb variation it was. 6) Run the following commands: kshell qa -v 2 -c 2 -- this should pass Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20080 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, have a problem with this one: An error occurred : Use of uninitialized value $_ in concatenation (.) or string at /home/vagrant/qa-test-tools/QohA/File/Specific/Kohastructure.pm line 39. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20080 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- ../qa-test-tools/koha-qa.pl -v 2 -c 9 testing 9 commit(s) (applied to f34dcf3 'Bug 18789: (follow-up) Fix page title') Processing files before patches |================> | 4 / 6 (66.67%) An error occurred : Use of uninitialized value $_ in concatenation (.) or string at /home/vagrant/qa-test-tools/QohA/File/Specific/Kohastructure.pm line 39. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20080 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |FIXED --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Issues regarding the QA tools are handled in the Gitlab repository: https://gitlab.com/koha-community/qa-test-tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20080 Bug 20080 depends on bug 18336, which changed state. Bug 18336 Summary: Add support for Unicode supplementary characters https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20080 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- These patches were wrong, the issue should have been fixed by https://gitlab.com/koha-community/qa-test-tools/issues/1 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org