http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14376 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14376 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14376 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40095|0 |1 is obsolete| | --- Comment #4 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 40131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40131&action=edit Bug 14376: Allow the librarian to choose a patron when entering a purchase suggestion. Sometimes librarians are creating purchase suggestions that came from patrons which didn't use the opac (but sent an email, or told the librarian verbally...) This patch allows the librarian to change the creator of the purchase suggestion when entering it. This way, the patron will be able to receive notifications during the purchase suggestion workflow. Test plan: - Create a new suggestion - Edit the input "By" from "Suggestion creation" - Check that autocomplete works. - Submit the suggestion with a user different than the logged-in librarian. - Check that the correct user is recorded for this suggestion. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14376 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Indranil, I think I don't fully understand the problem. It is already possible to add suggestions for a patron from their patron account in the staff client - this would just make it a bit more convenient I guess, as yu don't have to search for the patron first (less clicks). Maybe logging it would be enough? I feel like adding a column for 'how the suggestion was made' should be a separate enhancement request. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14376 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om Assignee|koha-bugs@lists.koha-commun |matthias.meusburger@biblibr |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14376 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #9 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- This patch adds logging support. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14376 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14376 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- This is not really user friendly. 1/ The input is too short and does not contain all the data (at least in my case). 2/ The text displayed after you have chosen a patron is not the same as when you arrive on the page. 3/ There are already several way to search for a patron, no need to introduce a new one. You could add an edit button and use it the same way as when we add users to a basket (popup), or the button will display the input with the autocompletion. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14376 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #14 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- About your second point Jonathan, this new patch make the dynamic patron information more consistent with the original one. However, I did not add the category description in ysearch.pl on purpose, because I have concerns about performances issues if added. Please tell me how you feel about that. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14376 Vinod <mishravk79@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mishravk79@gmail.com --- Comment #16 from Vinod <mishravk79@gmail.com> --- So whats final decision? i think there must be option to choose at least suggester name by searching their ID, so the order reports must also include suggester name along with their ID as well as other titles details. It has been added in 3.20 to notify the multiple patron on receiving the book so i thing may serve the purpose or in same way it can be made. In purchase suggestion the default (staff who enters the data) must be lifted and option must be given to choose the requester by name/ID. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14376 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Matthias, I've taken a look at the code and the GUI, but there are some small and some bigger things bothering me: 1) Display of patron names (trivial) + .append( "<a>" + item.surname + ", " + item.firstname + ", " + item.branch + "</a>" ) Please also think about the case where the patron has no firstname (organisations for example) 2) Logging + my $member = GetMember(borrowernumber => $$suggestion_only{'suggestedby'}); + logaction('ACQUISITIONS', 'MODIFY', undef, 'Suggestion title: ' . $$suggestion_only{'title'} . ", creator: " . + $member->{'surname'} . ', ' . + $member->{'firstname'} . ' (' . + $member->{'cardnumber'} . ')' ); a) I think we need to make more clear about which action in acquisitions this entry is about. I'd suggest to either add a new module 'SUGGESTIONS' or to be more clear about the action: 'MODIFY SUGG' or similar. b) For privacy reasons I am also quite uncomfortable about adding the name in plain text to the logs. We don't need this information if we reference the borrowernumber instead and it will also be better for privacy. For me this is a (blocker). c) Why are you leaving the object undef? I feel like this should be the suggestion id. Then we could just have the borrowernumber in the description. All other information can easily be found. d) I think the new logging needs to be covered by a system preference to be consistent with current practice. -- Don't misunderstand me - I really think we should do more nice logging! But I think we should try to avoid some of the problems we had with it in the past. One idea might even be to add a new column to action_logs to be able to store another id in a better way (user, object, affected_user?) 3) GUI I'd prefer the way patron search is done in other places taking place in a separate pop-up or modal. Because it offers a better overview for libraries with a lot of patrons and better options to limit search. An example would be the way it's done for searching patrons to be notified about an order (when creating an order line). -- You are receiving this mail because: You are watching all bug changes.