[Bug 28662] New: Not possible to log out of patron account in OPAC with JavaScript disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28662 Bug ID: 28662 Summary: Not possible to log out of patron account in OPAC with JavaScript disabled Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Depends on: 27445 While testing the patches from bug 27445 I noticed that there is no log out option visible when using the OPAC with Javascript disabled. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27445 [Bug 27445] OPAC header tweaks for non-JavaScript users -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28662 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.11 |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28662 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28662 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 122619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122619&action=edit Bug 28662: Not possible to log out of patron account in OPAC with JavaScript disabled This patch adds a "Log out" link to the OPAC header which is hidden by CSS when JavaScript is enabled. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Log in to the OPAC with JavaScript disabled in your browser. - In the header next to the logged-in user's name there should be a "Log out." link. - Confirm that it logs the user out. - Enable JavaScript and repeat the process to confirm that the new logout link doesn't appear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28662 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28662 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122619|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 122756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122756&action=edit Bug 28662: Not possible to log out of patron account in OPAC with JavaScript disabled This patch adds a "Log out" link to the OPAC header which is hidden by CSS when JavaScript is enabled. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Log in to the OPAC with JavaScript disabled in your browser. - In the header next to the logged-in user's name there should be a "Log out." link. - Confirm that it logs the user out. - Enable JavaScript and repeat the process to confirm that the new logout link doesn't appear. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28662 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #0)
While testing the patches from bug 27445 I noticed that there is no log out option visible when using the OPAC with Javascript disabled.
Since so much functionality depends on javascript/jquery, I am wondering if we still should take care of these things? Surely, logging out is very fundamental. But more in general? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28662 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28662 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122756|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122867&action=edit Bug 28662: Not possible to log out of patron account in OPAC with JavaScript disabled This patch adds a "Log out" link to the OPAC header which is hidden by CSS when JavaScript is enabled. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Log in to the OPAC with JavaScript disabled in your browser. - In the header next to the logged-in user's name there should be a "Log out." link. - Confirm that it logs the user out. - Enable JavaScript and repeat the process to confirm that the new logout link doesn't appear. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28662 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28662 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Marcel de Rooy from comment #3)
Since so much functionality depends on javascript/jquery, I am wondering if we still should take care of these things? Surely, logging out is very fundamental. But more in general?
We have always tried to provide a usable experience to users of the OPAC without JavaScript. I think it's time to re-evaluate that choice, but we should probably begin that process in a dev meeting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28662 Bug 28662 depends on bug 27445, which changed state. Bug 27445 Summary: OPAC header tweaks for non-JavaScript users https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27445 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28662 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28662 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28662 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.03 released in| | CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28662 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ah dependency Bug 27445 is not in 21.05.x but this one is. In any case I dont push to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org