[Bug 12552] New: Forward slash in payment note causes error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12552 Bug ID: 12552 Summary: Forward slash in payment note causes error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com A forward slash (/) in a payment note will trigger the following error: usi_escape: Unmatched [ in regex; marked by <-- HERE in m/([ <-- HERE ])/ at (eval 133) line 1. The issue is the use of uri_escape at line 174 of members/pay.pl, where a forward slash is a reserved character. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12552 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- I cannot reproduce the issue, I suspect the issue may be URI::Escape version 3.30. I'm running version 3.31 and do not see the issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12552 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12552 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Forward slash in payment |Odd error caused by URI |note causes error |Escape -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12552 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- I don't know the source of the error ( and thus cannot reproduce it on demand ) but it doesn't appear to be the forward slash after all. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12552 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12552 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40245&action=edit Bug 12552 - Odd error caused by URI Escape uri_escape: Unmatched [ in regex; marked by <-- HERE in m/([ <-- HERE ])/ at (eval 133) line 1. The issue is the use of uri_escape at line 174 of members/pay.pl Test Plan: 1) Apply this patch 2) Attempt to pay a fine with the "Pay" button 3) No regressions should be noted -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12552 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12552 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Upping importance because this bug can prevent payment of fines. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12552 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- I should also note I've seen this bug multiple times but cannot reproduce on a test system. However, the patch does indeed fix the issue on production systems I've applied it to. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12552 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |Failed QA --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Problem. I entered $_ as my note, and once saved, the note portion displayed as \$_. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12552 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could this be related to bug 8686 - version of URI::Escape? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12552 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Katrin Fischer from comment #7)
Could this be related to bug 8686 - version of URI::Escape?
I was chatting with Kyle on IRC about this yesterday. I don't think it is. http://irc.koha-community.org/koha/2015-06-17#i_1689562 17:53 - 19:52 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12552 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Failed QA |RESOLVED --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- I believe the issue is no longer related to URI::Escape. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org