[Bug 36772] New: OPAC Self checkout accepts wrong or partial barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36772 Bug ID: 36772 Summary: OPAC Self checkout accepts wrong or partial barcodes Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: bibliothek@th-wildau.de QA Contact: testopia@bugs.koha-community.org When using the opac trusted checkout feature it is possible to enter non existant or partial barcodes to check out items. Testplan: a) set System preference OpacTrustedCheckout to Allow b) go to http://localhost:8080/ and login with koha / koha c) click Self Checkout in navigation bar d) enter barcode 1234 e) result is: Item '39999000011234' was checked out Expected behaviour: The selfcheck should show an error that barcode 1234 is not existing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36772 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36772 --- Comment #1 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 166118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166118&action=edit Bug 36772: OPAC Self checkout accepts wrong or partial barcodes When using the opac trusted checkout feature it is possible to enter non existant or partial barcodes to check out items. Testplan: a) set System preference OpacTrustedCheckout to Allow b) go to http://localhost:8080/ and login with koha / koha c) click Self Checkout in navigation bar d) enter barcode 1234 e) result: Item '39999000011234' was checked out apply patch and reload the page a) now enter barcode 1234 b) result: Item '1234' not found c) enter 39999000011234 d) result: Item '39999000011234' was checked out -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36772 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36772 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166118|0 |1 is obsolete| | --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 166119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166119&action=edit Bug 36772: OPAC Self checkout accepts wrong or partial barcodes When using the opac trusted checkout feature it is possible to enter non existant or partial barcodes to check out items. Testplan: a) set System preference OpacTrustedCheckout to Allow b) go to http://localhost:8080/ and login with koha / koha c) click Self Checkout in navigation bar d) enter barcode 1234 e) result: Item '39999000011234' was checked out apply patch and reload the page a) now enter barcode 1234 b) result: Item '1234' not found c) enter 39999000011234 d) result: Item '39999000011234' was checked out Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36772 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166119|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166629&action=edit Bug 36772: OPAC Self checkout accepts wrong or partial barcodes When using the opac trusted checkout feature it is possible to enter non existant or partial barcodes to check out items. Testplan: a) set System preference OpacTrustedCheckout to Allow b) go to http://localhost:8080/ and login with koha / koha c) click Self Checkout in navigation bar d) enter barcode 1234 e) result: Item '39999000011234' was checked out apply patch and reload the page a) now enter barcode 1234 b) result: Item '1234' not found c) enter 39999000011234 d) result: Item '39999000011234' was checked out Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36772 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Doh, this is a mistake on my part, thanks for the fix Jan. All works as intended now, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36772 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC Self checkout accepts |OPAC self checkout accepts |wrong or partial barcodes |wrong or partial barcodes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36772 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36772 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36772 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.06 released in| | Status|Pushed to main |Pushed to stable --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36772 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org