[Bug 14605] New: The description on pay/write off individual fine is wrong
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605 Bug ID: 14605 Summary: The description on pay/write off individual fine is wrong Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: philippe.blouin@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When paying a fine, the description is built out of the borrower's type and title, instead of the actual fine's description. This has two causes: the information was not passed, and then it was overriden by some line << #workaround for Bug 4041 to get rid of duplicated code in circ-menu.tt, use circ-menu.inc instad $template->param(%$borrower);
which basically replace the accountline's description with the borrower's ?!?! Anyway, steps to reproduce: 1) in the staff, go to a user with a fine to pay. a) if none, go to a user and Fines>>"Create manual invoice" with a distinctive description. 2) In Fines>>Pay fines, click the "Pay" button on the line of the fine. 3) This will take you a "Pay an individual fine" screen, where the description will look like "Staff Mrs", for the category and title of the borrower. Apply the patch, and do it again. Voilà. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605 --- Comment #1 from Blou <philippe.blouin@inlibro.com> --- Created attachment 41208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41208&action=edit Bug 14605 - Corrects the individual fine's description When paying a fine, the description is built out of the borrower's type and title, instead of the actual fine's description. STEPS: 1) in the staff, go to a user with a fine to pay. a) if none, go to a user and Fines>>"Create manual invoice" with a distinctive description. 2) In Fines>>Pay fines, click the "Pay" button on the line of the fine. 3) This will take you a "Pay an individual fine" screen, where the description will look like "Staff Mrs", for the category and title of the borrower. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |philippe.blouin@inlibro.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net Status|Needs Signoff |In Discussion --- Comment #2 from Mirko Tietgen <mirko@abunchofthings.net> --- It looks like »Description« and »Account type« were mixed up. When I apply the patch, I have the fine description in »Description«, but also in »Account type«. I suppose this is where the user category should go. Can you confirm and adjust the patch? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605 --- Comment #3 from Blou <philippe.blouin@inlibro.com> --- Created attachment 41216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41216&action=edit display after patch I do not reproduce your issue, unless I'm misunderstanding. In "Account type", I only get the "F" as I had before. I checked again the diff's code, and can't see how it would have modified the account_type display. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605 --- Comment #4 from Mirko Tietgen <mirko@abunchofthings.net> --- (In reply to Blou from comment #3)
I do not reproduce your issue, unless I'm misunderstanding. In "Account type", I only get the "F" as I had before.
Maybe I don't understand what the account type column is actually for. I assumed it is for the patron category (which accidentally ended up in description before your patch). I left F as description before and thought it is the same now in both fields. After I used a different description, I see the fields have different contents. I am still not sure what account type is supposed to mean though. If it is the type of invoice, it would probably be better to display the description (Fine), not the code (F), and label the column »Invoice type«? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41208|0 |1 is obsolete| | --- Comment #5 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 41218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41218&action=edit Bug 14605 - Corrects the individual fine's description When paying a fine, the description is built out of the borrower's type and title, instead of the actual fine's description. STEPS: 1) in the staff, go to a user with a fine to pay. a) if none, go to a user and Fines>>"Create manual invoice" with a distinctive description. 2) In Fines>>Pay fines, click the "Pay" button on the line of the fine. 3) This will take you a "Pay an individual fine" screen, where the description will look like "Staff Mrs", for the category and title of the borrower. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I would say that the expected behavior was to display the description (what you did) and the title of the biblio, don't you think? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- And what about existing rows in the DB? Do you think it's possible to update them? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org