[Bug 24221] New: Convert OPACMySummaryNote system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 Bug ID: 24221 Summary: Convert OPACMySummaryNote system preference to news block Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 22880 Building on 22318, the OPACMySummaryNote system preference should be converted to a Koha news block. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 [Bug 22880] Convert opacheader system preference to news block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26050 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26050 [Bug 26050] [OMNIBUS] Convert system preferences to news block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Depends on| |27451 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27451 [Bug 27451] Split opac_news.lang into two distinct fields for location and language -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 Bug 24221 depends on bug 27451, which changed state. Bug 27451 Summary: Split opac_news.lang into two distinct fields for location and language https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27451 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 131204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131204&action=edit Bug 24221: Move OPACMySummaryNote to HTML customizations in additional-contents To test: 1- Before applying the patch add some content to the system preference OPACMySummaryNote 2- Apply patch 3- restart_all and updatedatabase 4. Go to additional-content.pl ( HTML customizations ) 5. You should now see your content from the system preference under OpacMySummaryNote in HTML customizations 6. Try searching for the system preference, OPACMySummaryNote. It has been removed and you should not be able to find it. 7. Try changing/removing/adding content from OpacMySummaryNote in HTML customizations 8. Make sure your edits are reflected when you look at the user summary page Note: The system preference was named OPACMySummaryNote but in to be more consitent with how we have named other additional_contents I have renamed this OpacMySummaryNote. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |lucas@bywatersolutions.com Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 shi-yao.wang@inLibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shi-yao.wang@inLibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from shi-yao.wang@inLibro.com --- Patch doesn't apply. At step 7, content doesn't appear when saving the new entry in Additional contents. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to shi-yao.wang from comment #2)
Patch doesn't apply. At step 7, content doesn't appear when saving the new entry in Additional contents.
This patch does cleanly apply to current master. As for step 7, I suspect your not adding a title. When I do not add a title to an HTML customization the content does not appear, that is probably a bug but I would request that you file separate bug report. Thanks for testing! Resetting this to NSO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 shi-yao.wang@inLibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131204|0 |1 is obsolete| | --- Comment #4 from shi-yao.wang@inLibro.com --- Created attachment 131581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131581&action=edit Bug 24221: Move OPACMySummaryNote to HTML customizations in additional-contents To test: 1- Before applying the patch add some content to the system preference OPACMySummaryNote 2- Apply patch 3- restart_all and updatedatabase 4. Go to additional-content.pl ( HTML customizations ) 5. You should now see your content from the system preference under OpacMySummaryNote in HTML customizations 6. Try searching for the system preference, OPACMySummaryNote. It has been removed and you should not be able to find it. 7. Try changing/removing/adding content from OpacMySummaryNote in HTML customizations 8. Make sure your edits are reflected when you look at the user summary page Note: The system preference was named OPACMySummaryNote but in to be more consitent with how we have named other additional_contents I have renamed this OpacMySummaryNote. Signed-off-by: shiyao <shiyao@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 shi-yao.wang@inLibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Shiyao, I have created a new bug report for the problem you were experiencing: See Bug 30272 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131581|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132013&action=edit Bug 24221: Move OPACMySummaryNote to HTML customizations in additional-contents To test: 1- Before applying the patch add some content to the system preference OPACMySummaryNote 2- Apply patch 3- restart_all and updatedatabase 4. Go to additional-content.pl ( HTML customizations ) 5. You should now see your content from the system preference under OpacMySummaryNote in HTML customizations 6. Try searching for the system preference, OPACMySummaryNote. It has been removed and you should not be able to find it. 7. Try changing/removing/adding content from OpacMySummaryNote in HTML customizations 8. Make sure your edits are reflected when you look at the user summary page Note: The system preference was named OPACMySummaryNote but in to be more consitent with how we have named other additional_contents I have renamed this OpacMySummaryNote. Signed-off-by: shiyao <shiyao@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132014&action=edit Bug 24221: Improve atomic update Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Like other conversions, I've added to DBRev" : No OpacMySummaryNote preference found. Value was empty or update has already been run. I add a follow-up to remove the HTML id, like done in Bug 28927 "Fix id opacmainuserblock used twice in OPAC" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 132264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132264&action=edit Bug 24221: (follow-up) Remove id opac-my-summary-note Like in other conversions to news block, we do not need an HTML id in the template, one is created by PROCESS koha_news_block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |OPACMySummaryNote system release notes| |preference is converted to | |a news block. | | | |Note that | |its HTML id is now | |'OpacMySummaryNote' instead | |of 'opac-my-summary-note'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/665 Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org