[Bug 24769] New: DataTable error on patron hold page when hold placed using ILS-DI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 Bug ID: 24769 Summary: DataTable error on patron hold page when hold placed using ILS-DI Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org Created attachment 99820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99820&action=edit Screenshots - DataTable error on patron hold page when hold placed using ILS-DI After placing a hold for a patron using ILS-DI an error occurs on the staff interface. After the hold is placed used ILS-DI, when clicking on the holds tab on a patron's details page: - an error message pops up; and - it no longer lists any holds. To replicate: 1) Place a hold for a patron. 2) Check the patron's details page and holds tab, the hold is listed. 3) Enable the ILS-DI system preference. 4) Use ILS-DI to place a hold for a patron, for example: http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=19&bib_id=12&request_location='27.0.0.1' (where: 19 = a patron id and bib_id = 12 a bibliographical record) 5) On the staff client go to Patrons > [Patron hold placed for] > Details > Holds tab. 6) An error is displayed in a pop-up window: DataTables warning: table id=holds-table - Ajax error. For more information about this error, please see http://datatables.net/tn/7 7) After clicking on OK for the error message, the holds tab no longer lists any holds - even though 2 should be listed. This occurs on master, but doesn't occur on 19.11.x It was discovered when testing bug 17229. See the attached screenshots. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 --- Comment #1 from David Nind <david@davidnind.com> --- Error also showed up when testing bug 23531 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 --- Comment #2 from David Nind <david@davidnind.com> --- Error also happening on bug 22806 before patch applied. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 --- Comment #3 from David Nind <david@davidnind.com> --- Error also happening on bug 11999 before patch applied. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 --- Comment #4 from David Nind <david@davidnind.com> --- Error also occurring after applying the patches for bug 24718 That is not an ILS-DI related bug, so seems wider. Will change title to reflect this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|DataTable error on patron |DataTable error on patron |hold page when hold placed |hold page when hold placed |using ILS-DI |(ILS-DI and other bugs) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 --- Comment #5 from David Nind <david@davidnind.com> --- (In reply to David Nind from comment #4)
Error also occurring after applying the patches for bug 24718
That is not an ILS-DI related bug, so seems wider.
Will change title to reflect this.
Aleisha solved resolved this with a follow-up patch to resolve the JavaScript error, but it still exists for holds placed using ILS-DI. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14711 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by commit 11b44869d95c47a7e6daec8dcb124762a9ee0026 Bug 14711: Change prototype for AddReserve - pass a hashref Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 [Bug 14711] Make C4::Reserves::AddReserves take a hashref in parameters -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103636&action=edit Bug 24769: (bug 14711 follow-up) Fix typo in parameter name for AddReserve The parameter is branchcode, not branch. Test plan: Place a hold on a biblio using ILSDI Check that the branchcode is correctly filled with the patron's library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Keywords| |rel_20_05_candidate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103636|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103637&action=edit Bug 24769: (bug 14711 follow-up) Fix typo in parameter name for AddReserve The parameter is branchcode, not branch. Test plan: Place a hold on a biblio using ILSDI Check that the branchcode is correctly filled with the patron's library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103638&action=edit Bug 24769: (bug 14711 follow-up 2) Fix typo in parameter name for AddReserve This patch fixes 2 other occurrences. The first one is in POD of AddReserve, the other one fixes SIP code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103637|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 103643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103643&action=edit Bug 24769: (bug 14711 follow-up) Fix typo in parameter name for AddReserve The parameter is branchcode, not branch. Test plan: Place a hold on a biblio using ILSDI Check that the branchcode is correctly filled with the patron's library Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103638|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 103644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103644&action=edit Bug 24769: (bug 14711 follow-up 2) Fix typo in parameter name for AddReserve This patch fixes 2 other occurrences. The first one is in POD of AddReserve, the other one fixes SIP code Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 --- Comment #12 from David Nind <david@davidnind.com> --- Thanks Jonathan for writing the patches to fix this! This is the test plan I used: 1) Place a hold for a patron. 2) Check the patron's details page and holds tab, the hold is listed. 3) Enable the ILS-DI system preference (ILS-DI). 4) Use ILS-DI to place a hold for a patron, for example: http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=19&bib_id=12&request_location='127.0.0.1' (where: 19 = a patron id and bib_id = 12 a bibliographical record) 5) On the staff client go to Patrons > [Patron hold placed for] > Details > Holds tab. 6) An error is displayed in a pop-up window: DataTables warning: table id=holds-table - Ajax error. For more information about this error, please see http://datatables.net/tn/7 7) After clicking on OK for the error message, the holds tab no longer lists any holds - even though 2 should be listed. 8) Go to the holds history for the patron and note that the Library for the hold placed using ILS-DI is blank. 9) Go to the bibliographical record and then holds - click update hold(s). Go to the patron's details page and click on the holds tab - this now displays correctly. 10) Apply the patch. 11) Repeat steps 4-5 (place a hold for another item). 12) The list of holds for the patron should display as expected with no errors. 13) Sign-off! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103643|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103644|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 104296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104296&action=edit Bug 24769: Regression tests When regressions are found, we introduce regression tests :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 104297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104297&action=edit Bug 24769: (bug 14711 follow-up) Fix typo in parameter name for AddReserve The parameter is branchcode, not branch. Test plan: Place a hold on a biblio using ILSDI Check that the branchcode is correctly filled with the patron's library Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 104298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104298&action=edit Bug 24769: (bug 14711 follow-up 2) Fix typo in parameter name for AddReserve This patch fixes 2 other occurrences. The first one is in POD of AddReserve, the other one fixes SIP code Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104296|0 |1 is obsolete| | --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 104300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104300&action=edit Better tests... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes a problem release notes| |introduced by another patch | |in this release cycle. The | |patron's hold page now | |correctly lists holds where | |holds are placed using | |ILS-DI (and in some other | |situations). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #18 from Joy Nelson <joy@bywatersolutions.com> --- not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org