[Bug 37641] New: Add syspref to make claim returned note mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37641 Bug ID: 37641 Summary: Add syspref to make claim returned note mandatory Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: wainuiwitikapark@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com A syspref is required to be able to set if you want the note when making a claim to be mandatory -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37641 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |wainuiwitikapark@catalyst.n |ity.org |et.nz Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37641 --- Comment #1 from wainuiwitikapark@catalyst.net.nz --- Created attachment 170302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170302&action=edit Bug 37641: Add syspref to make claim returned note mandatory To test: 1) Make sure ClaimReturnedLostValue syspref is set 2) Check out an item 3) Go to the account of the borrower who checked out the patron 4) Go to the checkouts table 5) There should be a column "Return claims" with a button "Claims returned" 6) Click the "Claims returned" button 7) Notice the pop up 8) Don't write anything in the note 9) Submit - make the claim 10) Notice it will let you make the claim without putting any notes in 11) Apply patch 12) Enable syspref ClaimReturnedMandatoryNote 13) Do steps 2-9 again 14) Notice it will not let you make the claim without putting any notes in it 15) Extra testing - Disable syspref ClaimReturnedMandatoryNote, run through steps 2-10 Sponsored-by: Pymble Ladies' College -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37641 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170302|0 |1 is obsolete| | --- Comment #2 from wainuiwitikapark@catalyst.net.nz --- Created attachment 170304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170304&action=edit Bug 37641: Add syspref to make claim returned note mandatory To test: 1) Make sure ClaimReturnedLostValue syspref is set 2) Check out an item 3) Go to the account of the borrower who checked out the patron 4) Go to the checkouts table 5) There should be a column "Return claims" with a button "Claims returned" 6) Click the "Claims returned" button 7) Notice the pop up 8) Don't write anything in the note 9) Submit - make the claim 10) Notice it will let you make the claim without putting any notes in 11) Apply patch 12) Enable syspref ClaimReturnedMandatoryNote 13) Do steps 2-9 again 14) Notice it will not let you make the claim without putting any notes in it 15) Extra testing - Disable syspref ClaimReturnedMandatoryNote, run through steps 2-10 Sponsored-by: Pymble Ladies' College -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37641 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |wainuiwitikapark@catalyst.n | |et.nz Assignee|wainuiwitikapark@catalyst.n |koha-bugs@lists.koha-commun |et.nz |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37641 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- 1. I learned with RequirePaymentType that it is far too easy to circumnavigate a disabled attribute with browser dev tools. See Bug 33176. If you're adding a system preference to enforce the note field then I think it should be checked in the script. 2. Currently there is nothing stopping me from adding the required note via the modal and then going to the Claims tab, editing/deleting the note. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37641 --- Comment #4 from wainuiwitikapark@catalyst.net.nz --- (In reply to Lucas Gass from comment #3) Kia ora Lucas, thanks for your message!
1. I learned with RequirePaymentType that it is far too easy to circumnavigate a disabled attribute with browser dev tools. See Bug 33176. If you're adding a system preference to enforce the note field then I think it should be checked in the script.
Which script is that? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37641 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37641 mteal@greenvillelibrary.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mteal@greenvillelibrary.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org