http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12683 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simith.doliveira@inlibro.co | |m Summary|Use NOLoginInstructions to |Use NoLoginInstructions to |customize text for OPAC |customize text for OPAC |user/pass information |user/pass information -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12683 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com, | |francois.charbonnier@inlibr | |o.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12683 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 30447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30447&action=edit [Signed-off] Bug 12683 - Use NoLoginInstructions to customize text for OPAC user/pass information Enable staff to setting a text for OPAC user/pass information Modified: C4/Auth.pm koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc -add a text to the popup login page koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-main.tt -add a text to the main login page Testing: I Apply the patch 0) Search NoLoginInstructions preference 1) Add/modify a text 2) Open OPAC main page 3) Validate the text added under Login button 4) Click in "Log in to your account" link 5) Validate the text added under input password (popup) Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12683 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12683 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: In case you click on Log in to your account in the top bar, a login popup appears. In that case the NoLoginInstructions are next to the password and not below the password as suggested. This is just a small design thing, but it does not look good. Failed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12683 --- Comment #4 from simith.doliveira@inlibro.com --- Created attachment 30736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30736&action=edit Popup correction patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12683 --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 30739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30739&action=edit [Signed-off] Popup correction patch. Button in pop-up displays now as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12683 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12683 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30447|0 |1 is obsolete| | Attachment #30739|0 |1 is obsolete| | --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 30750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30750&action=edit Bug 12683 - Use NoLoginInstructions to customize text for OPAC user/pass information Enable staff to setting a text for OPAC user/pass information Modified: C4/Auth.pm koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc -add a text to the popup login page koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-main.tt -add a text to the main login page Testing: I Apply the patch 0) Search NoLoginInstructions preference 1) Add/modify a text 2) Open OPAC main page 3) Validate the text added under Login button 4) Click in "Log in to your account" link 5) Validate the text added under input password (popup) Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) Patch behaves as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12683 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 30839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30839&action=edit Bug 12683: (followup) use the Koha.Preference plugin and add ids It is kosher now to use the Koha template toolkit plugin for retrieving system preferences values. This followup does that. It also changes the class for ids, for people considering this patch introduces too much noise on the home screen being able to control its visibility. Regards To+ Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12683 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl --- Comment #10 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- (In reply to Tomás Cohen Arazi from comment #8)

Created attachment 30839 [details] [review] Bug 12683: (followup) use the Koha.Preference plugin and add ids

It is kosher now to use the Koha template toolkit plugin for retrieving system preferences values. This followup does that.

I agree it's kinda kosher that way ;) but the problem is, for a current master such a change seems to introduce rather nasty side effects regarding UFT-8 characters encoding in great many OPAC pages; see bug 12411 for details. -- You are receiving this mail because: You are watching all bug changes.