https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30721 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 134786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134786&action=edit Bug 30721: Markup error in detail page's component parts tab This patch adds a missing </div> to the bibliographic detail page template in the section for showing component parts. Some comments are added to clarify the markup structure. To test you should have a record in your catalog with component parts. Bug 11175 provides one you can import if necessary: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78023 To see the error, go to the staff interface, locate the record in question and view the detail page. Under the Components tag, scroll to the bottom. You will see content from "later" tabs at the bottom, e.g. "There is no order for this bibliographic record" or "No images have been uploaded for this bibliograhpic record yet." Apply the patch and reload the page. The tabs should still look correct, and now the tab content should be correctly isolated. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30721 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134786|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 134800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134800&action=edit Bug 30721: Markup error in detail page's component parts tab This patch adds a missing </div> to the bibliographic detail page template in the section for showing component parts. Some comments are added to clarify the markup structure. To test you should have a record in your catalog with component parts. Bug 11175 provides one you can import if necessary: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78023 To see the error, go to the staff interface, locate the record in question and view the detail page. Under the Components tag, scroll to the bottom. You will see content from "later" tabs at the bottom, e.g. "There is no order for this bibliographic record" or "No images have been uploaded for this bibliograhpic record yet." Apply the patch and reload the page. The tabs should still look correct, and now the tab content should be correctly isolated. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30721 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30721 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134800|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134949&action=edit Bug 30721: Markup error in detail page's component parts tab This patch adds a missing </div> to the bibliographic detail page template in the section for showing component parts. Some comments are added to clarify the markup structure. To test you should have a record in your catalog with component parts. Bug 11175 provides one you can import if necessary: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78023 To see the error, go to the staff interface, locate the record in question and view the detail page. Under the Components tag, scroll to the bottom. You will see content from "later" tabs at the bottom, e.g. "There is no order for this bibliographic record" or "No images have been uploaded for this bibliograhpic record yet." Apply the patch and reload the page. The tabs should still look correct, and now the tab content should be correctly isolated. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30721 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30721 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ping RMaint :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30721 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30721 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes.