[Bug 12476] New: GetMember should probably take a hashref rather than a hash as a parameter
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12476 Bug ID: 12476 Summary: GetMember should probably take a hashref rather than a hash as a parameter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com I'm not a Perl expert, but we usually use hashrefs for parameters rather than hashes (and Google wisdom says that hashrefs are faster and more flexible than hashes). GetMember currently takes a hash but it would probably be an idea to use a hashref instead. Of course, we use GetMember in quite a few places already so it wouldn't be a trivial change, and it might be a case of over optimisation. Worth reporting in any case though. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12476 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Worth adding that we have a coding guideline related to this already: "PERL16: Hashrefs should be used as arguments" http://wiki.koha-community.org/wiki/Coding_Guidelines -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org