[Bug 19808] New: Data corruption causing an Internal Server Error when seeing a record' s details. Which have reviews from deleted borrowers.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 Bug ID: 19808 Summary: Data corruption causing an Internal Server Error when seeing a record's details. Which have reviews from deleted borrowers. Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: victor.grousset@biblibre.com QA Contact: testopia@bugs.koha-community.org Found by Joubu. ===== Cause ===== plack-error.log:
Can't call method "title" on an undefined value at /home/koha/src/opac/opac-detail.pl line 847.
code:
# setting some borrower info into this hash $review->{title} = $patron->title;
db:
CONSTRAINT `reviews_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE CASCADE,
The reviews are kept even if the user was deleted BZ 15839 is suspected to have introduced this bug. ===== Fix ===== The first step is to fix the 500 error. And then study the relevance of "on delete set null". And take care of the existing data. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|oleonard@myacpl.org |victor.grousset@biblibre.co | |m Status|NEW |ASSIGNED --- Comment #1 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- @Joubu: Is everything correct? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Victor Grousset/tuxayo from comment #1)
@Joubu: Is everything correct?
Yep, we will only take care of the existing data if we decide to remove the reviews from deleted patrons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.11 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Data corruption causing an |Reviews from deleted |Internal Server Error when |patrons make opac-detail |seeing a record's details. |explodes |Which have reviews from | |deleted borrowers. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Reviews from deleted |Reviews from deleted |patrons make opac-detail |patrons make opac-detail |explodes |explode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 --- Comment #3 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- ===== Going further ===== Another bug caused by the root issue: When a patron leaves a comment/review on a record And this patron is deleted Then the "Comments pending approval" page (staff:/cgi-bin/koha/reviews/reviewswaiting.pl) throws a 500 error «Can't call method "surname" on an undefined value at /home/koha/src/reviews/reviewswaiting.pl line 76.» -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 --- Comment #4 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- ===== Going further ===== (In reply to Victor Grousset/tuxayo from comment #3)
===== Going further =====
Another bug caused by the root issue: When a patron leaves a comment/review on a record And this patron is deleted Then the "Comments pending approval" page (staff:/cgi-bin/koha/reviews/reviewswaiting.pl) throws a 500 error «Can't call method "surname" on an undefined value at /home/koha/src/reviews/reviewswaiting.pl line 76.»
Just trying to go the approved comments (staff:/cgi-bin/koha/reviews/reviewswaiting.pl?status=1) also triggers the same error. This case is more likely to happen than the above. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 --- Comment #5 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Created attachment 69824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69824&action=edit Fix opac-detail being broken by a review from a deleted patron And other display issues when the patron was NULL. Which allows to keep the review even if it has no patron. Because it might be useful. For example when disconnected, the borrowernumber is null. So the comments from deleted patrons were displayed as if the disconnected user wrote them. So it had the edit button... And fix borrowernumber not being passed to the template when OpacStarRatings was false. Test plan 1. Log in as a patron 2. Leave a comment/review on a record 3. Librarian: approve this comment 4. Delete the borrower 5. See the record (opac:/cgi-bin/koha/opac-detail.pl?biblionumber=RELEVANT_BIB_NUMBER) 6. Then you should see an error 7. Apply this patch 8. Refresh the page 9. Then you should see the record page with the comment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|ASSIGNED |Needs Signoff --- Comment #6 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Thanks Julian Maurice for the help to fix all the tricky cases and clean the code :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Can't call method "title" on an undefined value at /home/koha/src/opac/opac-detail.pl line 847. Successfully duplicated on old-school git install (not kohadevbox). (In reply to Victor Grousset/tuxayo from comment #3)
===== Going further =====
Another bug caused by the root issue: When a patron leaves a comment/review on a record And this patron is deleted Then the "Comments pending approval" page (staff:/cgi-bin/koha/reviews/reviewswaiting.pl) throws a 500 error «Can't call method "surname" on an undefined value at /home/koha/src/reviews/reviewswaiting.pl line 76.»
Did you bug report this? Because your patch only fixes the 847 issue in opac-detail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69824|0 |1 is obsolete| | --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 69828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69828&action=edit Bug 19808: Fix opac-detail breaking on a review from a deleted patron And other display issues when the patron was NULL. Which allows to keep the review even if it has no patron. Because it might be useful. For example when disconnected, the borrowernumber is null. So the comments from deleted patrons were displayed as if the disconnected user wrote them. So it had the edit button... And fix borrowernumber not being passed to the template when OpacStarRatings was false. Test plan 1. Log in as a patron 2. Leave a comment/review on a record 3. Librarian: approve this comment 4. Delete the borrower 5. See the record (opac:/cgi-bin/koha/opac-detail.pl?biblionumber=RELEVANT_BIB_NUMBER) 6. Then you should see an error 7. Apply this patch 8. Refresh the page 9. Then you should see the record page with the comment Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |josef.moravec@gmail.com --- Comment #9 from Josef Moravec <josef.moravec@gmail.com> --- Are you going to address the issue on reviews/reviewswaiting.pl too? If not please make a bug report for it. Thanks Marking as Failed QA = waiting for answer here ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- As I alluded to in comment #7 based on comment #4's observation. (In reply to Josef Moravec from comment #9)
Are you going to address the issue on reviews/reviewswaiting.pl too?
If so, awaiting patch.
If not please make a bug report for it.
-- and add it to the See Also.
Thanks
-- Ditto. :)
Marking as Failed QA = waiting for answer here ;)
I'm torn. The title doesn't suggest it will be fixed here. However, there is no link to a bug elsewhere. I'll leave the status as is. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Assignee|victor.grousset@biblibre.co |jonathan.druart@bugs.koha-c |m |ommunity.org --- Comment #11 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- (In reply to M. Tompsett from comment #7)
Did you bug report this? Because your patch only fixes the 847 issue in opac-detail.pl
(In reply to Josef Moravec from comment #9)
Are you going to address the issue on reviews/reviewswaiting.pl too? If not please make a bug report for it. Thanks
Thanks for following up on that part. The idea was to write somewhere these findings to not forget to do something about that. I planned to open a separate bug for this as it's wasn't the same priority. So I only have the time handle the first part. After a discussion with Joubu, it's better to fix the rest in the same bug. So here you go (changing status and assignee). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69828|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69853&action=edit Bug 19808: Handle deleted reviewers gracefully - opac-detail And other display issues when the patron was NULL. Which allows to keep the review even if it has no patron. Because it might be useful. For example when disconnected, the borrowernumber is null. So the comments from deleted patrons were displayed as if the disconnected user wrote them. So it had the edit button... And fix borrowernumber not being passed to the template when OpacStarRatings was false. Test plan 1. Log in as a patron 2. Leave a comment/review on a record 3. Librarian: approve this comment 4. Delete the borrower 5. See the record (opac:/cgi-bin/koha/opac-detail.pl?biblionumber=RELEVANT_BIB_NUMBER) 6. Then you should see an error 7. Apply this patch 8. Refresh the page 9. Then you should see the record page with the comment Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69854&action=edit Bug 19808: (follow-up) Handle deleted reviewers gracefully - opac-detail Make the tests easier to read -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69855&action=edit Bug 19808: Handle deleted reviewers gracefully - opac-showreview Test plan: - Create reviews - Delete some reviewers - Enable OpacShowRecentComments - Go to opac/opac-showreviews.pl - Go to opac-showreviews.pl?format=rss -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69856&action=edit Bug 19808: Handle deleted reviewers gracefully - reviews/reviewswaiting.pl Test plan: - Create reviews - Delete some reviewers - Go to Home › Tools › Comments › Comments awaiting moderation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 --- Comment #16 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 69856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69856 Bug 19808: Handle deleted reviewers gracefully - reviews/reviewswaiting.pl Review of attachment 69856: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19808&attachment=69856) ----------------------------------------------------------------- ::: reviews/reviewswaiting.pl @@ +67,4 @@
} )->unblessed;
+for my $review ( @$reviews ) {
Love the explicit $review instead of $_ code. @@ +72,1 @@
# setting some borrower info into this hash
Think the comment is misplaced. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Reviews from deleted |Reviews from deleted |patrons make opac-detail |patrons make few scripts to |explode |explode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 --- Comment #17 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- BTW any idea why it doesn't seem to affect 16.11? A least for the explosion part. It still shows "Your comment" + the edit button when the patron is deleted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15839 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Koha::Reviews is used since bug 15839 (in 16.11.x), but the patron's info are still retrieved from GetMember. Since bug 17829 (17.11) they are using Koha::Patrons (which means we cannot call a method on an undefined object) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 [Bug 15839] Move the reviews related code to Koha::Reviews -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17829 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 [Bug 17829] Move GetMember to Koha::Patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 16:15 < oleonard> greenjimll: I was just testing that too but got interrupted. Looks okay to me except that in the OPAC the comment labels don't look right when there is no patron 16:15 < oleonard> Instead of "Added 2016-12-19 by John Smith" it says "Added" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69926&action=edit Bug 19808: Do not display 'Added' alone It seems that reviews.datereviewed ends with NULL in DB. It is caused by another issue that will be fixed on another bug report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15839 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #20)
Created attachment 69926 [details] [review] Bug 19808: Do not display 'Added' alone
It seems that reviews.datereviewed ends with NULL in DB. It is caused by another issue that will be fixed on another bug report.
See bug 15839 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69853|0 |1 is obsolete| | Attachment #69854|0 |1 is obsolete| | Attachment #69855|0 |1 is obsolete| | Attachment #69856|0 |1 is obsolete| | Attachment #69926|0 |1 is obsolete| | --- Comment #22 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Created attachment 69934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69934&action=edit [SIGNED-OFF] Bug 19808: Handle deleted reviewers gracefully - opac-detail And other display issues when the patron was NULL. Which allows to keep the review even if it has no patron. Because it might be useful. For example when disconnected, the borrowernumber is null. So the comments from deleted patrons were displayed as if the disconnected user wrote them. So it had the edit button... And fix borrowernumber not being passed to the template when OpacStarRatings was false. Test plan 1. Log in as a patron 2. Leave a comment/review on a record 3. Librarian: approve this comment 4. Delete the borrower 5. See the record (opac:/cgi-bin/koha/opac-detail.pl?biblionumber=RELEVANT_BIB_NUMBER) 6. Then you should see an error 7. Apply this patch 8. Refresh the page 9. Then you should see the record page with the comment Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 --- Comment #23 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Created attachment 69935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69935&action=edit [SIGNED-OFF] Bug 19808: (follow-up) Handle deleted reviewers gracefully - opac-detail Make the tests easier to read Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 --- Comment #24 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Created attachment 69936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69936&action=edit [SIGNED-OFF] Bug 19808: Handle deleted reviewers gracefully - opac-showreview Test plan: - Create reviews - Delete some reviewers - Enable OpacShowRecentComments - Go to opac/opac-showreviews.pl - Go to opac-showreviews.pl?format=rss Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 --- Comment #25 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Created attachment 69937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69937&action=edit [SIGNED-OFF] Bug 19808: Handle deleted reviewers gracefully - reviews/reviewswaiting.pl Test plan: - Create reviews - Delete some reviewers - Go to Home › Tools › Comments › Comments awaiting moderation Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 --- Comment #26 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Created attachment 69938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69938&action=edit [SIGNED-OFF] Bug 19808: Do not display 'Added' alone It seems that reviews.datereviewed ends with NULL in DB. It is caused by another issue that will be fixed on another bug report. Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69934|0 |1 is obsolete| | Attachment #69935|0 |1 is obsolete| | Attachment #69936|0 |1 is obsolete| | Attachment #69937|0 |1 is obsolete| | Attachment #69938|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 69989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69989&action=edit Bug 19808: Handle deleted reviewers gracefully - opac-detail And other display issues when the patron was NULL. Which allows to keep the review even if it has no patron. Because it might be useful. For example when disconnected, the borrowernumber is null. So the comments from deleted patrons were displayed as if the disconnected user wrote them. So it had the edit button... And fix borrowernumber not being passed to the template when OpacStarRatings was false. Test plan 1. Log in as a patron 2. Leave a comment/review on a record 3. Librarian: approve this comment 4. Delete the borrower 5. See the record (opac:/cgi-bin/koha/opac-detail.pl?biblionumber=RELEVANT_BIB_NUMBER) 6. Then you should see an error 7. Apply this patch 8. Refresh the page 9. Then you should see the record page with the comment Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 69990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69990&action=edit Bug 19808: (follow-up) Handle deleted reviewers gracefully - opac-detail Make the tests easier to read Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 69991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69991&action=edit Bug 19808: Handle deleted reviewers gracefully - opac-showreview Test plan: - Create reviews - Delete some reviewers - Enable OpacShowRecentComments - Go to opac/opac-showreviews.pl - Go to opac-showreviews.pl?format=rss Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 69992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69992&action=edit Bug 19808: Handle deleted reviewers gracefully - reviews/reviewswaiting.pl Test plan: - Create reviews - Delete some reviewers - Go to Home › Tools › Comments › Comments awaiting moderation Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 69993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69993&action=edit Bug 19808: Do not display 'Added' alone It seems that reviews.datereviewed ends with NULL in DB. It is caused by another issue that will be fixed on another bug report. Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick@bywatersolutions.com --- Comment #33 from Nick Clemens <nick@bywatersolutions.com> --- All but last patch (translation) have been pushed to stable for 17.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #34 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Bug 17829 not in 17.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org