[Bug 43547] New: Update and Run SQL button runs report before updating
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43547 Bug ID: 43547 Summary: Update and Run SQL button runs report before updating Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: lisette@bywatersolutions.com Target Milestone: --- To recreate: - save and run a report "SELECT * FROM items LIMIT 1" - confirm you are shown 1 item - edit report, change your limit to 2 - click Update and run SQL - confirm you are shown just 1 item - click Show SQL code, confirm it still shows "LIMIT 1" - click Run report - page reloads, now shows 2 items -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43547 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16631 CC| |lucas@bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16631 [Bug 16631] Limit listing of reports using patron library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43547 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43547 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- update_sql() runs a previously stored version of $report -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43547 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43547 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 206079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206079&action=edit Bug 43547: set when doing update_sql to ensure right stored version of report is used To test: 1- save and run a report "SELECT * FROM items LIMIT 1" 2- confirm you are shown 1 item 3- edit report, change your limit to 2 4- click Update and run SQL 5- confirm you are shown just 1 item 6- click Show SQL code, confirm it still shows "LIMIT 1" 7- click Run report 8- page reloads, now shows 2 items 9- APPLY PATCH and restart_all 10- Try steps 1 -5 again 11- Now at step 6 the SQL code should show 'LIMIT 2' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43547 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43547 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43547 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206356&action=edit Bug 43547: set when doing update_sql to ensure right stored version of report is used To test: 1- save and run a report "SELECT * FROM items LIMIT 1" 2- confirm you are shown 1 item 3- edit report, change your limit to 2 4- click Update and run SQL 5- confirm you are shown just 1 item 6- click Show SQL code, confirm it still shows "LIMIT 1" 7- click Run report 8- page reloads, now shows 2 items 9- APPLY PATCH and restart_all 10- Try steps 1 -5 again 11- Now at step 6 the SQL code should show 'LIMIT 2' Signed-off-by: Marisha Sullivan <msullivan@holdenfg.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43547 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43547 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206079|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43547 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43547 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206356|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43547 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 208426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208426&action=edit Bug 43547: set when doing update_sql to ensure right stored version of report is used To test: 1- save and run a report "SELECT * FROM items LIMIT 1" 2- confirm you are shown 1 item 3- edit report, change your limit to 2 4- click Update and run SQL 5- confirm you are shown just 1 item 6- click Show SQL code, confirm it still shows "LIMIT 1" 7- click Run report 8- page reloads, now shows 2 items 9- APPLY PATCH and restart_all 10- Try steps 1 -5 again 11- Now at step 6 the SQL code should show 'LIMIT 2' Signed-off-by: Marisha Sullivan <msullivan@holdenfg.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43547 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Pushed to main for 26.11 with consent from Pedro whilst he's on annual leave -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43547 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43547 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Fixes a problem where the release notes| |'Update and run' button for | |reports was fetching a | |stored version of the | |report from before the | |update. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org