[Bug 20621] New: Add ability for Koha::Object objects to update themselves with database generated value automatically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20621 Bug ID: 20621 Summary: Add ability for Koha::Object objects to update themselves with database generated value automatically Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Koha objects should, on store() update themselves from the db if the database creates any of the columns. That way we don't have to call discard_changes() manually. This patch has no particular use yet, but I wanted to put it here for posterity. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20621 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- See https://wiki.koha-community.org/wiki/Koha_Objects#store_doesn.27t_return_the... for details. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20621 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20621 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20621 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 74555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74555&action=edit Bug 20621: Add ability for Koha::Object objects to update themselves with database generated value automatically Koha objects should, on store() update themselves from the db if the database creates any of the columns. That way we don't have to call discard_changes() manually. See https://wiki.koha-community.org/wiki/Koha_Objects#store_doesn.27t_return_the... for details. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20621 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22741 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20621 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20621 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #3 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Ahhh ok that is why in unit tests we see for example in t/db_dependent/Members.t : $borrowernumber = Koha::Patron->new( \%data )->store->borrowernumber; my $patron = Koha::Patrons->find( $borrowernumber ); discard_changes() has a disturbing name i feel. Should it use get_from_storage ? my $patron = Koha::Patron->new( \%data )->store->get_from_storage; In my opinion store() should update the object, that is a common behavior in any ORM i think. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20621 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Fridolin SOMERS from comment #3)
Ahhh ok that is why in unit tests we see for example in t/db_dependent/Members.t : $borrowernumber = Koha::Patron->new( \%data )->store->borrowernumber; my $patron = Koha::Patrons->find( $borrowernumber );
discard_changes() has a disturbing name i feel.
Should it use get_from_storage ? my $patron = Koha::Patron->new( \%data )->store->get_from_storage;
In my opinion store() should update the object, that is a common behavior in any ORM i think.
My understanding is that get_from_storage has more overhead than discard_changes, though they have the same end result. get_from_storage creates and entirely new object, where discard_changes simply updates the existing object. https://metacpan.org/pod/DBIx::Class::Row#get_from_storage -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20621 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27630 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20621 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- "Needs Signoff" => what is needed to do for signoff? I guess for QA we need an automated test, right? So it's needed and having it run as a signoff would be enough. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20621 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Needs Signoff |RESOLVED --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Victor Grousset/tuxayo from comment #5)
"Needs Signoff" => what is needed to do for signoff?
I guess for QA we need an automated test, right? So it's needed and having it run as a signoff would be enough.
This is so old it still checks wantarray. I do not believe it is worth pursuing at this time. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org