[Bug 30434] New: Convert catalog merge page tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30434 Bug ID: 30434 Summary: Convert catalog merge page tabs to Bootstrap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 29226 Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in the catalog merge template with Bootstrap. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30434 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30434 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 132868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132868&action=edit Bug 30434: Convert catalog merge page tabs to Bootstrap This patch updates the catalog merge template so that it uses Bootstrap tabs instead of jQueryUI. Some JavaScript is modified to accommodate the new DOM structure. The patch also makes a minor HTML correction, adding a missing "</ol>". To test, apply the patch and search the catalog in the staff client. - In the search results, check the checkbox for two records. - Choose Edit -> Merge records. - Click next to accept the merge reference selection. - On the next page you should see two tabs under "Source records." Confirm that they work correctly. - All checkboxes in the first tab should be checked by default. - Confirm that tag and subfield selection still works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30434 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132868|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 133278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133278&action=edit Bug 30434: Convert catalog merge page tabs to Bootstrap This patch updates the catalog merge template so that it uses Bootstrap tabs instead of jQueryUI. Some JavaScript is modified to accommodate the new DOM structure. The patch also makes a minor HTML correction, adding a missing "</ol>". To test, apply the patch and search the catalog in the staff client. - In the search results, check the checkbox for two records. - Choose Edit -> Merge records. - Click next to accept the merge reference selection. - On the next page you should see two tabs under "Source records." Confirm that they work correctly. - All checkboxes in the first tab should be checked by default. - Confirm that tag and subfield selection still works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30434 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133278|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133482&action=edit Bug 30434: Convert catalog merge page tabs to Bootstrap This patch updates the catalog merge template so that it uses Bootstrap tabs instead of jQueryUI. Some JavaScript is modified to accommodate the new DOM structure. The patch also makes a minor HTML correction, adding a missing "</ol>". To test, apply the patch and search the catalog in the staff client. - In the search results, check the checkbox for two records. - Choose Edit -> Merge records. - Click next to accept the merge reference selection. - On the next page you should see two tabs under "Source records." Confirm that they work correctly. - All checkboxes in the first tab should be checked by default. - Confirm that tag and subfield selection still works correctly. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30434 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All works as expected.. being bold and going straight for PQA here as it's a simple patch and I can't find any regressions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30434 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30434 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30434 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30434 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30434 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33591 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org