[Bug 29778] New: Deleted additional_contents remain visible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Bug ID: 29778 Summary: Deleted additional_contents remain visible Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org We have had 2 reports about this on the mailing list from 3 different people so far. It was not possible yet to determine the cause: https://lists.katipo.co.nz/pipermail/koha/2021-December/057161.html https://lists.katipo.co.nz/pipermail/koha/2021-December/057186.html I've tried to replicate on master, but no luck so far. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |critical --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have managed to find the steps to make this bug visible: 1) Install an additional language, like de-DE 2) Activate language 3) Add a new HTML customization entry * Fill in default and Englis * Fill in the additional installed language * Save 4) Verify the contents show as they should 5) Delete the entry 6) Verify the content remain for the additional language This can also be verified by running: select * from additional_contents; In my case I deleted everything else and now only this entry remains that is not visible from the GUI: +-------+---------------------+---------------------+-------------------+------------+-------+---------+-------+--------------+---------------------+----------------+--------+----------------+ | idnew | category | code | location | branchcode | title | content | lang | published_on | updated_on | expirationdate | number | borrowernumber | +-------+---------------------+---------------------+-------------------+------------+-------+---------+-------+--------------+---------------------+----------------+--------+----------------+ | 7 | html_customizations | OpacMainUserBlock_6 | OpacMainUserBlock | NULL | test | test | de-DE | 2022-01-02 | 2022-01-02 01:46:58 | NULL | NULL | 51 | +-------+---------------------+---------------------+-------------------+------------+-------+---------+-------+--------------+---------------------+----------------+--------+----------------+ Updating severity as this means people have no way to change or remove unwanted content - we need to fix this and also include a database update. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Deleted additional_contents |Deleting |remain visible |additional_contents is | |incomplete and leaves | |entries for additional | |languages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Deleting |Deleting |additional_contents is |additional_contents leaves |incomplete and leaves |entries for additional |entries for additional |languages |languages | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128957&action=edit Bug 29778: Prevent orphan additional contents When deleting a content, only the main one (lang="default") is removed, which leads to orphan contents in the DB that are still displayed on the UI. Test plan: 0. Don't apply this patch 1. Create some contents, translate them in different languages 2. Delete some of them => Note that they are still displayed on the UI and that the entries with lang!="default" are still in the DB 3. Apply this patch 4. Repeat 1 5. Run updatedatabase 6. Delete from of the contents => Note that the orphan entries created before you applied the patch have been removed and that the "delete" behaviour is now working correnctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart+koha@gmail. | |com CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29782 CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I'm getting this error when running updatedatabase: ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Table 'additional_contents' is specified twice, both as a target for 'DELETE' and as a separate source for data at /kohadevbox/koha/C4/Installer.pm line 738 My "About" page says: MySQL version: mysql Ver 15.1 Distrib 10.3.31-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129038&action=edit Bug 29778: Remove DBMS error ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Table 'additional_contents' is specified twice, both as a target for 'DELETE' and as a separate source for data at /kohadevbox/koha/C4/Installer.pm line 738 Happened on MariaDB 10.1 and 10.3, not 10.6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128957|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 129040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129040&action=edit Bug 29778: Prevent orphan additional contents When deleting a content, only the main one (lang="default") is removed, which leads to orphan contents in the DB that are still displayed on the UI. Test plan: 0. Don't apply this patch 1. Create some contents, translate them in different languages 2. Delete some of them => Note that they are still displayed on the UI and that the entries with lang!="default" are still in the DB 3. Apply this patch 4. Repeat 1 5. Run updatedatabase 6. Delete from of the contents => Note that the orphan entries created before you applied the patch have been removed and that the "delete" behaviour is now working correnctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129038|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 129041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129041&action=edit Bug 29778: Remove DBMS error ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Table 'additional_contents' is specified twice, both as a target for 'DELETE' and as a separate source for data at /kohadevbox/koha/C4/Installer.pm line 738 Happened on MariaDB 10.1 and 10.3, not 10.6 Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29805 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 [Bug 29805] Database update fails in MySQL 5.7 because it's missing REGEXP_REPLACE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29828 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24387 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 [Bug 24387] Rename News tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129040|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 129218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129218&action=edit Bug 29778: Prevent orphan additional contents When deleting a content, only the main one (lang="default") is removed, which leads to orphan contents in the DB that are still displayed on the UI. Test plan: 0. Don't apply this patch 1. Create some contents, translate them in different languages 2. Delete some of them => Note that they are still displayed on the UI and that the entries with lang!="default" are still in the DB 3. Apply this patch 4. Repeat 1 5. Run updatedatabase 6. Delete from of the contents => Note that the orphan entries created before you applied the patch have been removed and that the "delete" behaviour is now working correnctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129041|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 129219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129219&action=edit Bug 29778: Remove DBMS error ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Table 'additional_contents' is specified twice, both as a target for 'DELETE' and as a separate source for data at /kohadevbox/koha/C4/Installer.pm line 738 Happened on MariaDB 10.1 and 10.3, not 10.6 Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Bug 29828 shows another vector of creating database entries for additional contents that are not visible in the GUI - ideally we should have fixes for both in the next releases! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #9)
Bug 29828 shows another vector of creating database entries for additional contents that are not visible in the GUI - ideally we should have fixes for both in the next releases!
Please backport with this comment in mind! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.02 released in| | CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |andrew@bywatersolutions.com --- Comment #13 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency, not backported to 21.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Just mentioning that this dbrev can be quite nasty for people having some custom records in the former news table. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org