[Bug 12600] New: Duplicated use statement in Search.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12600 Bug ID: 12600 Summary: Duplicated use statement in Search.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: colin.campbell@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org There are two use C4::Charset statements in C4::Search.pm one buried deep in the code for no reason it should be removed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12600 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |colin.campbell@ptfs-europe. | |com --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 29811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29811&action=edit Proposed patch Test: search,pm still compiles after patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12600 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|enhancement |trivial --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> --- amended to flag this as a trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12600 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29811|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 30153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30153&action=edit [SIGNED-OFF] Bug 12600: remove duplicate use statement from code A use C4::Charset was added deep in the body of the code we have already imported it at the top of the file (the by convention normal place) As use is executed at compile time specifying it in the code body does not serve a useful purpose and detracts from the readability of an already overly complex subroutine. Remove the superfluous statement also removed the tabs introduced to the surrounding lines by the same commit Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Search still works, no errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12600 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30153|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30161&action=edit [PASSED QA] Bug 12600: remove duplicate use statement from code A use C4::Charset was added deep in the body of the code we have already imported it at the top of the file (the by convention normal place) As use is executed at compile time specifying it in the code body does not serve a useful purpose and detracts from the readability of an already overly complex subroutine. Remove the superfluous statement also removed the tabs introduced to the surrounding lines by the same commit Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Search still works, no errors. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12600 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Colin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12600 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_4_candidate Status|Pushed to Master |Pushed to Stable CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.4. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org