[Bug 16988] New: Suspending a hold with AutoResumeSuspendedHolds disabled results in error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16988 Bug ID: 16988 Summary: Suspending a hold with AutoResumeSuspendedHolds disabled results in error Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Unless AutoResumeSuspendedHolds is enabled, attempting to suspend a hold from reserve/request.pl results in the following error: The given date (undefined) does not match the date format (us) at /home/vagrant/kohaclone/Koha/DateUtils.pm line 152. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16988 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16988 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16988 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 53755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53755&action=edit Bug 16988 - Suspending a hold with AutoResumeSuspendedHolds disabled results in error iUnless AutoResumeSuspendedHolds is enabled, attempting to suspend a hold from reserve/request.pl results in the following error: The given date (undefined) does not match the date format (us) at /home/vagrant/kohaclone/Koha/DateUtils.pm line 152. Test Plan: 1) Enable SuspendHoldsIntranet 2) Disable AutoResumeSuspendedHolds 3) Attempt to suspend or unsuspend a hold 4) Note the error 5) Apply this patch 6) Repeat step 3 7) The hold should suspend or resume correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16988 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16988 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53755|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 53773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53773&action=edit Bug 16988 - Suspending a hold with AutoResumeSuspendedHolds disabled results in error iUnless AutoResumeSuspendedHolds is enabled, attempting to suspend a hold from reserve/request.pl results in the following error: The given date (undefined) does not match the date format (us) at /home/vagrant/kohaclone/Koha/DateUtils.pm line 152. Test Plan: 1) Enable SuspendHoldsIntranet 2) Disable AutoResumeSuspendedHolds 3) Attempt to suspend or unsuspend a hold 4) Note the error 5) Apply this patch 6) Repeat step 3 7) The hold should suspend or resume correctly Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Megan Wianecki <mwianecki@mtpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16988 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16988 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53773|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53832&action=edit Bug 16988 - Suspending a hold with AutoResumeSuspendedHolds disabled results in error iUnless AutoResumeSuspendedHolds is enabled, attempting to suspend a hold from reserve/request.pl results in the following error: The given date (undefined) does not match the date format (us) at /home/vagrant/kohaclone/Koha/DateUtils.pm line 152. Test Plan: 1) Enable SuspendHoldsIntranet 2) Disable AutoResumeSuspendedHolds 3) Attempt to suspend or unsuspend a hold 4) Note the error 5) Apply this patch 6) Repeat step 3 7) The hold should suspend or resume correctly Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Megan Wianecki <mwianecki@mtpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16988 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the November 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16988 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Pushed to Master |Pushed to Stable --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.03. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16988 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org