[Bug 42463] New: Deleting a SMS provider should use text() rather than html()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42463 Bug ID: 42463 Summary: Deleting a SMS provider should use text() rather than html() Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org When deleting a SMS provider, the HTML is used instead of the text. If the HTML includes escaped characters then you end up with a funny looking message. For instance, deleting a SMS provider called "This & That" says the following: Are you sure you want to delete This & That? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42463 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42463 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 198121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198121&action=edit Bug 42463: Use text instead of HTML for confirm message This change uses the text instad of the HTML for the delete SMS provider confirm message. Test plan: 0. Apply the patch 1. Go to Administration, click System preferences, search for SMSSendDriver 2. Set SMSSendDriver to "Email" 3. Go to administration 4. Click on "SMS cellular providers" 5. Click "New SMS provider" 6. For "Name" and "Domain" write: This & That 7. Click Submit 8. Click "Delete" for the new provider 9. Note that the message says "Are you sure you want to delete This & That?" 10. Click "OK" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42463 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42463 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42463 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198121|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42463 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 198206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198206&action=edit Bug 42463: Use text instead of HTML for confirm message This change uses the text instad of the HTML for the delete SMS provider confirm message. Test plan: 0. Apply the patch 1. Go to Administration, click System preferences, search for SMSSendDriver 2. Set SMSSendDriver to "Email" 3. Go to administration 4. Click on "SMS cellular providers" 5. Click "New SMS provider" 6. For "Name" and "Domain" write: This & That 7. Click Submit 8. Click "Delete" for the new provider 9. Note that the message says "Are you sure you want to delete This & That?" 10. Click "OK" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42463 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42463 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198206|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42463 --- Comment #3 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 198295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198295&action=edit Bug 42463: Use text instead of HTML for confirm message This change uses the text instad of the HTML for the delete SMS provider confirm message. Test plan: 0. Apply the patch 1. Go to Administration, click System preferences, search for SMSSendDriver 2. Set SMSSendDriver to "Email" 3. Go to administration 4. Click on "SMS cellular providers" 5. Click "New SMS provider" 6. For "Name" and "Domain" write: This & That 7. Click Submit 8. Click "Delete" for the new provider 9. Note that the message says "Are you sure you want to delete This & That?" 10. Click "OK" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42463 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42463 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42463 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42463 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42463 --- Comment #5 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42463 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #6 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 25.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org