[Bug 27868] New: Adding the Expiration Date to the Holds Awaiting Pickup report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 Bug ID: 27868 Summary: Adding the Expiration Date to the Holds Awaiting Pickup report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: andrew@bywatersolutions.com, bwsdonna@gmail.com, gmcharlt@gmail.com Looking ahead to the passing of bug 8367, it would be nice to have the Hold's expiration date be visible on the Holds Awaiting Pickup Report. When different item types will have the potential to have different expiration dates, it would be a nice column to have in this report to easily see what has expired and what is about to expire. But overall, I do think that a Date Expiration column would greatly help libraries with this current report, Holds Awaiting Pickup. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- +100. On this page (waitingreserves.pl), we show the user the waitingdate (the date on which the item went to the hold shelf) and tell the user what the pickup delay value is, thereby very strongly implying that expirationdate will always equal waitingdate+pickup delay. Actually, there are a bunch of ways the expiration date can end up being something else. We should show the expirationdate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 128334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128334&action=edit Bug 27868: Add expiration date to holds awaiting pickup To test: 1. Have some holds awaiting pickup, also have some holds that have been waiting longer than the ReservesMaxPickUpDelay is set to. 2. Go to /cgi-bin/koha/circ/waitingreserves.pl 3. There is no expiration date 4. Apply patch and restart_all 5. Now there should be a Expiration date column, make sure you can see it in both Holds waiting and Holds waiting over X days 6. Make sure all the columns Waiting Since, Date hold placed, and expiration date still sort correctly 6. Go to Table settings, and make sure all the columns hide correctly for both of the holds_awaiting_pickup tables ( holdst & holdso ) Note: This patch also corrects 2 other small problems 1. Corrects a problem where the table settings did not account for the checkbox column at the beginnning of each table 2. Removes the title-string class and uses data-order to sort Waiting Since, Date hold placed, and expiration date ( see Bug 27934 ) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128334|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 128382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128382&action=edit Bug 27868: Add expiration date to holds awaiting pickup To test: 1. Have some holds awaiting pickup, also have some holds that have been waiting longer than the ReservesMaxPickUpDelay is set to. 2. Go to /cgi-bin/koha/circ/waitingreserves.pl 3. There is no expiration date 4. Apply patch and restart_all 5. Now there should be a Expiration date column, make sure you can see it in both Holds waiting and Holds waiting over X days 6. Make sure all the columns Waiting Since, Date hold placed, and expiration date still sort correctly 6. Go to Table settings, and make sure all the columns hide correctly for both of the holds_awaiting_pickup tables ( holdst & holdso ) Note: This patch also corrects 2 other small problems 1. Corrects a problem where the table settings did not account for the checkbox column at the beginnning of each table 2. Removes the title-string class and uses data-order to sort Waiting Since, Date hold placed, and expiration date ( see Bug 27934 ) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128382|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129095&action=edit Bug 27868: Add expiration date to holds awaiting pickup To test: 1. Have some holds awaiting pickup, also have some holds that have been waiting longer than the ReservesMaxPickUpDelay is set to. 2. Go to /cgi-bin/koha/circ/waitingreserves.pl 3. There is no expiration date 4. Apply patch and restart_all 5. Now there should be a Expiration date column, make sure you can see it in both Holds waiting and Holds waiting over X days 6. Make sure all the columns Waiting Since, Date hold placed, and expiration date still sort correctly 6. Go to Table settings, and make sure all the columns hide correctly for both of the holds_awaiting_pickup tables ( holdst & holdso ) Note: This patch also corrects 2 other small problems 1. Corrects a problem where the table settings did not account for the checkbox column at the beginnning of each table 2. Removes the title-string class and uses data-order to sort Waiting Since, Date hold placed, and expiration date ( see Bug 27934 ) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice improvement, works as expected.. PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement makes each release notes| |hold's expiration date | |visible on the Holds | |Awaiting Pickup page. Since | |this is the date Koha uses | |to decide when a waiting | |hold should expire and be | |cancelled, making it | |visible decreases | |confusion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The checkbox column addition here needs backporting to 21.11 series.. it's a bug that was introduced by bug 23678 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30970 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org