[Bug 39957] New: Fix JS error on credit and debit types administration pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39957 Bug ID: 39957 Summary: Fix JS error on credit and debit types administration pages Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@gmail.com Depends on: 39810 +++ This bug was initially created as a clone of Bug #39810 +++ When you're not adding or editing a credit or debit type there is a JS error in the console. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39810 [Bug 39810] Use select2 to select library limitations in credit and debit type administration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39957 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Same for the files changed in Bug 39099, itemtypes.tt, categories.js, and authorised_values.tt. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39957 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39957 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 182696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182696&action=edit Bug 39957: Fix JS error on credit and debit types administration pages This patch fixes an JS error in several administration pages, introduced by Bug 39099 and 39810. We can't access a DOM node without checking for its existence first. To test, apply the patch and go to Administration. - Check the following pages: - Authorized values - Credit types - Debit types - Item types - Patron categories. - On each page check the JavaScript console on the initial page. There should be no errors. - Check the add/edit page for each and confirm that the library limitation Select2 widget works correctly. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39957 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39099 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39099 [Bug 39099] Use select2 to select library limitations in item types, patron categories, and authorized values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39957 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39957 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182696|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 182709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182709&action=edit Bug 39957: Fix JS error on credit and debit types administration pages This patch fixes an JS error in several administration pages, introduced by Bug 39099 and 39810. We can't access a DOM node without checking for its existence first. To test, apply the patch and go to Administration. - Check the following pages: - Authorized values - Credit types - Debit types - Item types - Patron categories. - On each page check the JavaScript console on the initial page. There should be no errors. - Check the add/edit page for each and confirm that the library limitation Select2 widget works correctly. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39957 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Both before and after the patch, on the patron categories and item types pages (after clearing the browser cache, and a flush_memcached, restart_all), but not all the time, I get: - [Violation] 'setTimeout' handler took 55ms 2. Also, on both those pages, this error appears if you don't do anything else on the page for a period of time: . "Unchecked runtime.lastError: A listener indicated an asynchronous response by returning true, but the message channel closed before a response was received" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39957 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39957 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39957 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- This fix clearly shows that the code should not be duplicated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39957 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39957 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Dependencies not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39957 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #7 from David Nind <david@davidnind.com> --- Bug fix, no change required to the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org