[Bug 5959] New: Add search link for analytics to serial records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5959 Bug #: 5959 Summary: Add search link for analytics to serial records Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: MARC Bibliographic data support AssignedTo: katrin.fischer@bsz-bw.de ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha-bugs@lists.koha-community.org CC: ian.walls@bywatersolutions.com This will work similar to 'Show volumes' links from traced series records and set records. A link to search for analytics linked to serials. A new syspref will be added: UseControlNumber. This syspref will make it possible to determine, if $w and Controlnumber are used for linking of records in the catalog. If not, the search links will not use control numbers but keywords. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5959 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-03-27 21:49:20 UTC --- Created attachment 3446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3446 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5959 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5959 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-03-28 09:34:30 UTC --- ../5959.patch:254: trailing whitespace. error: patch failed: C4/XSLT.pm:131 error: C4/XSLT.pm: patch does not apply error: patch failed: kohaversion.pl:16 error: kohaversion.pl: patch does not apply Is it perhaps an idea to put functionality and installation into 2 patches?? The installation patch is not that interesting for testing and gets often much sooner out of date? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5959 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-03-28 09:40:34 UTC --- I think the installation part needs testing too. ;) I think the problem here is, that another XSLT change was pushed shortly before I sent my patch. I will rebase and resent, the conflicts should not be too hard to fix. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5959 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-03-29 07:44:31 UTC --- Created attachment 3494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3494 Rebased patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5959 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3446|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5959 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-03-30 14:06:14 UTC --- (In reply to comment #3)
I think the installation part needs testing too. ;) I think the problem here is, that another XSLT change was pushed shortly before I sent my patch. I will rebase and resent, the conflicts should not be too hard to fix.
Install part should obviously be tested too, of course. But if you split functionality and installation, you will not be rebasing every two days ;) Please note that your patch does not even apply already any more on current master due to db revs. Will look to the functional part now.. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5959 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcamins@cpbibliography.com --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2011-03-30 14:07:06 UTC --- I have rebased and am signing off on this. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5959 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5959 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3494|0 |1 is obsolete| | --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2011-03-30 14:17:07 UTC --- Created attachment 3525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3525 Signed-off patch Signed-off patch, rebased to latest Master. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5959 --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-03-30 14:18:59 UTC --- Comment on attachment 3525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3525 Signed-off patch Attachment is not viewable in your browser because its MIME type (application/octet-stream) is not one that your browser is able to display. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5959 --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2011-03-30 14:21:11 UTC --- Created attachment 3527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3527 Signed-off patch (reposted) Marcel, I think I may be cursed. Reposting signed-off patch. Regards, Jared -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5959 --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-03-30 15:08:07 UTC --- (In reply to comment #9)
Created attachment 3527 [details] Signed-off patch (reposted) Marcel, I think I may be cursed. Reposting signed-off patch. Regards, Jared
Patch applies fine now. Thanks. Only still wonder about the analytics stuff. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5959 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Signed Off |Patch Pushed --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> 2011-04-01 07:26:34 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5959 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #12 from Nicole C. Engard <nengard@gmail.com> 2011-04-01 13:12:15 UTC --- Can someone please explain to me what this does for the manual? I need small words here :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5959 lculber@mdah.state.ms.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lculber@mdah.state.ms.us --- Comment #13 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-04-04 08:10:22 UTC --- This bug is mentioned in: Bug 5959: Add search link for analytics to serial records http://lists.koha-community.org/pipermail/koha-patches/2011-March/014242.htm... Bug 5959: Add search link for analytics to serial records http://lists.koha-community.org/pipermail/koha-patches/2011-March/014355.htm... --- Comment #14 from lculber@mdah.state.ms.us 2011-04-28 19:00:11 UTC --- I realize I am coming in late aboutthis, but we just noticed that we hadn't taken the indicators into consideration about whether the links should even display. Had anyone else looked at the indicators? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5959 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-01-06 15:35:45 UTC --- This works on master. The links can be removed from display using CSS: .analytics {display: none;} Linda - you are right, indicators are not taken into account here. Could you open a separate bug with some more information perhaps? I can try to look into it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org