[Bug 37238] New: Add table settings to itemsearch results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Bug ID: 37238 Summary: Add table settings to itemsearch results Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Itemsearch results has grown to be a very large table, table settings should be added. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13965#c3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 168409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168409&action=edit Bug 37238: Add column configuration to item search results table To test: 1. APPLY PATCH 2. Do an item search that will return results. 3. To the right of the table notice thee Columns, Export, Configure buttons 4. Use the Columns button to hide and show various columns, make sure it works right. 5. Use the Export button to try and export the table in various file formats. You should only see visible columns in your export. 6. Go to Admin -> Table settings, make sure you can hide columns properly from there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13965 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13965 [Bug 13965] Add date last seen on item search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168409|0 |1 is obsolete| | --- Comment #2 from Sam Lau <samalau@gmail.com> --- Created attachment 168411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168411&action=edit Bug 37238: Add column configuration to item search results table To test: 1. APPLY PATCH 2. Do an item search that will return results. 3. To the right of the table notice thee Columns, Export, Configure buttons 4. Use the Columns button to hide and show various columns, make sure it works right. 5. Use the Export button to try and export the table in various file formats. You should only see visible columns in your export. 6. Go to Admin -> Table settings, make sure you can hide columns properly from there. Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 23565 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- I'm getting inconsistent behavior from the column header search fields. Sometimes they work, sometimes they incorrectly filter out all results, and sometimes I get a 500 error: C4::Items::SearchItems(): DBI Exception: DBD::mysql::st execute failed: Column 'itemnumber' in where clause is ambiguous at /kohadevbox/koha/catalogue/itemsearch.pl line 252 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 DBIx::Class::Exception::throw('DBIx::Class::Exception', 'DBI Exception: DBD::mysql::st execute failed: Column \'itemnumber\' in where clause is ambiguous', 0) called at /usr/share/perl5/DBIx/Class/Schema.pm line 1118 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Owen Leonard from comment #4)
I'm getting inconsistent behavior from the column header search fields. Sometimes they work, sometimes they incorrectly filter out all results, and sometimes I get a 500 error:
C4::Items::SearchItems(): DBI Exception: DBD::mysql::st execute failed: Column 'itemnumber' in where clause is ambiguous at /kohadevbox/koha/catalogue/itemsearch.pl line 252 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 DBIx::Class::Exception::throw('DBIx::Class::Exception', 'DBI Exception: DBD::mysql::st execute failed: Column \'itemnumber\' in where clause is ambiguous', 0) called at /usr/share/perl5/DBIx/Class/Schema.pm line 1118
Thanks Owen. For the 500 error, I am reproducing that without my patch applied. It seems specific to the itemnumber column? It also seems like many of the columns, but not all, are incorrectly filtering without this patch applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37249 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37249 [Bug 37249] Item search column filtering broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 168483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168483&action=edit Bug 37238: Replace jquery.dataTables.columnFilter.js with native DataTables function -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- I fixed the 500 error when using itemnumber filtering on Bug 37249. The follow-up patch here make filtering work when columns are hidden. I did notice that when filtering things like Item type, Home library, currently library, damaged, lost, ect. it requires the user to know the code. The description doesn't work. This seems to be true with or without my patch. The same seems to true when filtering dates. You must use the ISO date or else filtering doesn't work. This is also true with or without this patchset. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catrina@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Anni Rajala <anni.rajala@turku.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |anni.rajala@turku.fi --- Comment #8 from Anni Rajala <anni.rajala@turku.fi> --- Noticed a couple of issues while testing and thus changed status to Failed QA: 1. On the item results page, the filters have been relocated to the bottom of the results list when they should be at the top. 2. After making changes to the table settings, the changes didn't apply until I logged in again to Koha. I think this is different from how the table settings act otherwise? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 170785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170785&action=edit Bug 37238: Move filters from tfoot to thead -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Anni Rajala from comment #8)
Noticed a couple of issues while testing and thus changed status to Failed QA:
1. On the item results page, the filters have been relocated to the bottom of the results list when they should be at the top. 2. After making changes to the table settings, the changes didn't apply until I logged in again to Koha. I think this is different from how the table settings act otherwise?
Anni, thanks for testing. I did move the filters from the footer into the header. However I cannot recreate your 2nd problem. For me the column configuration/Table settings are working. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170785|0 |1 is obsolete| | --- Comment #11 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 171037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171037&action=edit Bug 37238: Move filters from tfoot to thead Signed-off-by: Eric Garcia <cubingguy714@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 --- Comment #12 from Anni Rajala <anni.rajala@turku.fi> --- (In reply to Lucas Gass from comment #10)
(In reply to Anni Rajala from comment #8)
Noticed a couple of issues while testing and thus changed status to Failed QA:
1. On the item results page, the filters have been relocated to the bottom of the results list when they should be at the top. 2. After making changes to the table settings, the changes didn't apply until I logged in again to Koha. I think this is different from how the table settings act otherwise?
Anni, thanks for testing. I did move the filters from the footer into the header.
However I cannot recreate your 2nd problem. For me the column configuration/Table settings are working.
I was going to try if I could recreate the 2nd problem, but after applying the batch, I keep getting error ("Unsupported format html at /kohadevbox/koha/catalogue/itemsearch.pl line 100) when trying to search something in item search. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33729 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33729 [Bug 33729] Add a column for dateaccessioned to item search results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |jonathan.druart@gmail.com --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- This will conflict badly with bug 33484 but I am willing to help to get it pushed ASAP so that I can write on top of it. Please rebase. CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should this be "patch doesn't apply"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168411|0 |1 is obsolete| | --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 173414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173414&action=edit Bug 37238: Add column configuration to item search results table To test: 1. APPLY PATCH 2. Do an item search that will return results. 3. To the right of the table notice thee Columns, Export, Configure buttons 4. Use the Columns button to hide and show various columns, make sure it works right. 5. Use the Export button to try and export the table in various file formats. You should only see visible columns in your export. 6. Go to Admin -> Table settings, make sure you can hide columns properly from there. Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168483|0 |1 is obsolete| | --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 173415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173415&action=edit Bug 37238: Replace jquery.dataTables.columnFilter.js with native DataTables function -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171037|0 |1 is obsolete| | --- Comment #17 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 173416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173416&action=edit Bug 37238: Move filters from tfoot to thead Signed-off-by: Eric Garcia <cubingguy714@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #13)
This will conflict badly with bug 33484 but I am willing to help to get it pushed ASAP so that I can write on top of it.
Please rebase.
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt
Rebased. However, there is no reason this need to take precedence over Bug 33484. I can always come back to this later and re-do on top of Bug 33484. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Adding a RM_priority keyword here as this blocks other patches and is a much needed usability fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- 1. There is an input in the first and last columns (checkbox and actions) 2. When I click on an input to give it the focus, a request is made to sort the column 3. This table is absolutely not ready for the "save state" feature (from bug 33484). We need to make it an exception: * Remove the 2 'save state' options from the Table settings admin page for this table. * Remove the "Copy shareable link" button * Bypass the save/load state callback functions for this table That will lead to some ugly code I have hardly tried to avoid on bug 33484 :D Or we remove what has been done on bug 14322 and adjust this table to make it work with the "save state" feature. I would move this to in discussion and see what we do next. I can help! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173415|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173416|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 --- Comment #21 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #20)
1. There is an input in the first and last columns (checkbox and actions)
2. When I click on an input to give it the focus, a request is made to sort the column
These problems should now both be fixed by obsoleting my follow-ups. Please have a look now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 --- Comment #22 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 173740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173740&action=edit Bug 37238: (follow-up) Deal with table state, remove sharable link -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 --- Comment #23 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #20)
1. There is an input in the first and last columns (checkbox and actions)
2. When I click on an input to give it the focus, a request is made to sort the column
3. This table is absolutely not ready for the "save state" feature (from bug 33484). We need to make it an exception: * Remove the 2 'save state' options from the Table settings admin page for this table. * Remove the "Copy shareable link" button * Bypass the save/load state callback functions for this table
That will lead to some ugly code I have hardly tried to avoid on bug 33484 :D
Or we remove what has been done on bug 14322 and adjust this table to make it work with the "save state" feature.
I would move this to in discussion and see what we do next. I can help!
I added a follow-up to make an exception for this table. We already have a sharable link from Bug 14322. I am happy to proceed in another direction if you want to try to implement the work from Bug 33484, Jonathan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED Assignee|lucas@bywatersolutions.com |jonathan.druart@gmail.com --- Comment #24 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Lucas Gass (lukeg) from comment #21)
(In reply to Jonathan Druart from comment #20)
1. There is an input in the first and last columns (checkbox and actions)
2. When I click on an input to give it the focus, a request is made to sort the column
These problems should now both be fixed by obsoleting my follow-ups. Please have a look now.
Well it's actually for this change that I needed this for bug 36640 :D No worries, I will deal with that later. (In reply to Lucas Gass (lukeg) from comment #23)
(In reply to Jonathan Druart from comment #20)
1. There is an input in the first and last columns (checkbox and actions)
2. When I click on an input to give it the focus, a request is made to sort the column
3. This table is absolutely not ready for the "save state" feature (from bug 33484). We need to make it an exception: * Remove the 2 'save state' options from the Table settings admin page for this table. * Remove the "Copy shareable link" button * Bypass the save/load state callback functions for this table
That will lead to some ugly code I have hardly tried to avoid on bug 33484 :D
Or we remove what has been done on bug 14322 and adjust this table to make it work with the "save state" feature.
I would move this to in discussion and see what we do next. I can help!
I added a follow-up to make an exception for this table. We already have a sharable link from Bug 14322.
It's not correct. If you don't have save_state in the config you still want to offer the ability to share the state with the link. I will submit a follow-up.
I am happy to proceed in another direction if you want to try to implement the work from Bug 33484, Jonathan.
Yes, we should. But not here, not now :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38304 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38304 [Bug 38304] Remove SaveState options for OPAC tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173414|0 |1 is obsolete| | Attachment #173740|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173765&action=edit Bug 37238: Add column configuration to item search results table To test: 1. APPLY PATCH 2. Do an item search that will return results. 3. To the right of the table notice thee Columns, Export, Configure buttons 4. Use the Columns button to hide and show various columns, make sure it works right. 5. Use the Export button to try and export the table in various file formats. You should only see visible columns in your export. 6. Go to Admin -> Table settings, make sure you can hide columns properly from there. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 --- Comment #26 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173766&action=edit Bug 37238: Add exception for itemsearch Item search has its own way to share the link, we should not deal with the state (and the work from bug 33484) on this page. It will certainly need to be adjusted to work like the other tables, but it's something for later. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #27 from Jonathan Druart <jonathan.druart@gmail.com> --- Lucas, are you happy with the patches? If so please PQA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36640 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 [Bug 36640] Upgrade DataTables from 1.13.6 to 2.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13965, 33729 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13965 [Bug 13965] Add date last seen on item search https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33729 [Bug 33729] Add a column for dateaccessioned to item search results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 --- Comment #28 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173768&action=edit Bug 37238: Remove the global search It does not work, we should not display the input. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 --- Comment #29 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Lucas Gass (lukeg) from comment #6)
Created attachment 168483 [details] [review] Bug 37238: Replace jquery.dataTables.columnFilter.js with native DataTables function
For the record, this is now done on bug 36640, see commit "Bug 36640: Fix itemsearch" on the remote branch there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173765|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173785&action=edit Bug 37238: Add column configuration to item search results table To test: 1. APPLY PATCH 2. Do an item search that will return results. 3. To the right of the table notice thee Columns, Export, Configure buttons 4. Use the Columns button to hide and show various columns, make sure it works right. 5. Use the Export button to try and export the table in various file formats. You should only see visible columns in your export. 6. Go to Admin -> Table settings, make sure you can hide columns properly from there. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173766|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173786&action=edit Bug 37238: Add exception for itemsearch Item search has its own way to share the link, we should not deal with the state (and the work from bug 33484) on this page. It will certainly need to be adjusted to work like the other tables, but it's something for later. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173768|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173787&action=edit Bug 37238: Remove the global search It does not work, we should not display the input. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 --- Comment #33 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Looking generally good here.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 --- Comment #34 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Thanks for the help here, Jonathan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38331 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38331 [Bug 38331] Add date accessioned column to itemsearch results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Really happy to see the collaboration and this feature in general. I think it will be one of these seemingly "small" things, that will really help libraries in their day to day. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate, |release-notes-needed |RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |The item search results release notes| |table is now configurable | |via the table settings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Bug 37238 depends on bug 38304, which changed state. Bug 38304 Summary: Remove SaveState options for OPAC tables https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38304 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38935 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38935 [Bug 38935] "Actions" column not translatable in itemsearch.tt -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org