[Bug 40739] New: Setting TransfersBlockCirc to 'Don't block' does not allow for scanning to continue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40739 Bug ID: 40739 Summary: Setting TransfersBlockCirc to 'Don't block' does not allow for scanning to continue Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com To recreate: 1. Set TransfersBlockCirc to 'Don't block' 2. Check in some items not from your library to initiate a transfer. 3. See the modal pop-op, "Transfer to home library" 4. However, you cannot continue to scan the next item unless you first dismiss the modal. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40739 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40739 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40739 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38842 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38842 [Bug 38842] Add reusable modal wrapper -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40739 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- This seems to have been lost with Bug 38842. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40739 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40739 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 186051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186051&action=edit Bug 40739: Use correct block/noblock class in item-transfer-modal To test: 1. Set TransfersBlockCirc to 'Don't block' 2. Check in some items not from your library to initiate a transfer. 3. See the modal pop-op, "Transfer to home library" 4. However, you cannot continue to scan the next item unless you first dismiss the modal. 5. APPLY PATCH 6. Try again, this time at step 4 the barcode input should have focus and you'll be able to scan the next item. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40739 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40739 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40739 --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Setting to major because this can impact workflows quite badly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40739 Kathleen <kkosiec@santabarbaraca.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkosiec@santabarbaraca.gov Status|Needs Signoff |In Discussion --- Comment #4 from Kathleen <kkosiec@santabarbaraca.gov> --- This is definitely affecting our workflow for items returning home. Staff either have to click on the pop up or use "ALT + Y" to bypass the screen. Previously, we could bypass if we scanned another item. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40739 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186051|0 |1 is obsolete| | --- Comment #5 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 186081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186081&action=edit Bug 40739: Use correct block/noblock class in item-transfer-modal To test: 1. Set TransfersBlockCirc to 'Don't block' 2. Check in some items not from your library to initiate a transfer. 3. See the modal pop-op, "Transfer to home library" 4. However, you cannot continue to scan the next item unless you first dismiss the modal. 5. APPLY PATCH 6. Try again, this time at step 4 the barcode input should have focus and you'll be able to scan the next item. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40739 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov Depends on|38842 |38714 Status|In Discussion |Passed QA QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Keywords| |regression --- Comment #6 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Moving this straight to PQA; it's a trivial fix for a major regression. I think the cause was 8e7f5556 (bug 38714), though: [% IF Koha.Preference('TransfersBlockCirc') %] - <div id="item-transfer-modal" class="modal modal-lg block audio-alert-action" data-bs-backdrop="static" data-bs-keyboard="false"> + [% SET div_class='block' %] [% ELSE %] - <div id="item-transfer-modal" class="modal modal-lg noblock audio-alert-action"> + [% SET div_class='noblock' %] [% END %] + <div id="item-transfer-modal" class="modal modal-lg block audio-alert-action" [% IF Koha.Preference('TransfersBlockCirc') %]data-bs-backdrop="static" data-bs-keyboard="false"[% END %]> Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714 [Bug 38714] Adjust templates for prettier https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38842 [Bug 38842] Add reusable modal wrapper -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40739 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186081|0 |1 is obsolete| | --- Comment #7 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 186099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186099&action=edit Bug 40739: Use correct block/noblock class in item-transfer-modal To test: 1. Set TransfersBlockCirc to 'Don't block' 2. Check in some items not from your library to initiate a transfer. 3. See the modal pop-op, "Transfer to home library" 4. However, you cannot continue to scan the next item unless you first dismiss the modal. 5. APPLY PATCH 6. Try again, this time at step 4 the barcode input should have focus and you'll be able to scan the next item. Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40739 --- Comment #8 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Thanks for catching that, Lucas! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40739 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40739 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40739 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch fixes a bug release notes| |where setting | |TransfersBlockCirc to | |'Don't block' did not allow | |scanning to continue after | |the modal pop-up was | |displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40739 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40739 --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40739 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Bug 38714 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org