[Bug 40933] New: Add sms support under Add message feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 Bug ID: 40933 Summary: Add sms support under Add message feature Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: lari.taskula@hypernova.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Staff interface -> Patron details -> Add Message Current options are: Staff - Internal note OPAC Email - email addresses of patron Add: SMS - sms number of patron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 --- Comment #1 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 187226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187226&action=edit Bug 40933: Add the ability to send custom SMS messages to a patron To test: 1. Make sure SMSSendDriver system preference is enabled 2. In staff client, navigate to patron details of any patron 3. From the members menu toolbar, click "Add Message" 4. Under "Add a message for", select "SMS - sms number of patron" 5. Write a custom message 6. Click "Save" 7. Navigate to patron's Notices tab 8. Observe a new notice titled "SMS added by a librarian" 9. Click it 10. Observe the content you wrote in step 5 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lari.taskula@hypernova.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187226|0 |1 is obsolete| | --- Comment #2 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 188643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188643&action=edit Bug 40933: Add the ability to send custom SMS messages to a patron To test: 1. Make sure SMSSendDriver system preference is enabled 2. In staff client, navigate to patron details of any patron 3. From the members menu toolbar, click "Add Message" 4. Under "Add a message for", select "SMS - sms number of patron" 5. Write a custom message 6. Click "Save" 7. Navigate to patron's Notices tab 8. Observe a new notice titled "SMS added by a librarian" 9. Click it 10. Observe the content you wrote in step 5 Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |andrew@bywatersolutions.com --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- This is no longer adding "SMS added by a librarian" as the subject of the message. The lack of subject means there is no link to see the notice content in the patron's Notices tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32403 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Looking back at this, I've noticed that this code does not allow an SMS to be generating using an existing notice. When sending an email via Add Message, one can either type in email text directly or select a pre-defined letter_code. It would be ideal for SMS messages to match this functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add sms support under Add |Add SMS support under Add |message feature |message feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 --- Comment #5 from Magnus Enger <magnus@libriotech.no> --- (In reply to Andrew Fuerste-Henry from comment #4)
Looking back at this, I've noticed that this code does not allow an SMS to be generating using an existing notice. When sending an email via Add Message, one can either type in email text directly or select a pre-defined letter_code. It would be ideal for SMS messages to match this functionality.
I would say this is useful even without the option to choose a pre-defined letter_code. Maybe that could be left to a followup? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188643|0 |1 is obsolete| | --- Comment #6 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 191346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191346&action=edit Bug 40933: Add the ability to send custom SMS messages to a patron To test: 1. Make sure SMSSendDriver system preference is enabled 2. In staff client, navigate to patron details of any patron 3. From the members menu toolbar, click "Add Message" 4. Under "Add a message for", select "SMS - sms number of patron" 5. Write a custom message 6. Click "Save" 7. Navigate to patron's Notices tab 8. Observe a new notice titled "SMS added by a librarian" 9. Click it 10. Observe the content you wrote in step 5 11. Repeat steps 2-4 12. Select predefined patron notice. If you don't have one, navigate to Tools > Notices and slips > New notice > Patrons (custom message) and add content under sms delivery option 13. Repeat steps 6-7 14. Observe your custom message in the notices table 15. Observe your custom message content when you click the notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 --- Comment #7 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to Andrew Fuerste-Henry from comment #3)
This is no longer adding "SMS added by a librarian" as the subject of the message. The lack of subject means there is no link to see the notice content in the patron's Notices tab.
I could not reproduce this issue. Following the test plan gives me this subject. Can you give me the steps to reproduce it?
Looking back at this, I've noticed that this code does not allow an SMS to be generating using an existing notice. When sending an email via Add Message, one can either type in email text directly or select a pre-defined letter_code. It would be ideal for SMS messages to match this functionality.
Good idea. The library who requested this feature from us didn't need to use pre-defined templates, but I can see it being useful for others
I would say this is useful even without the option to choose a pre-defined letter_code. Maybe that could be left to a followup?
It was just a tiny change to implement that so I've squashed it into the original patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 --- Comment #8 from Lari Taskula <lari.taskula@hypernova.fi> --- Btw something to note, this is currently controlled only by SMSSendDriver preference and edit_borrowers userflags. Since SMS messages are often not free of charge, there could be libraries wanting to disable this feature but at the same time still have automatically generated sms notices enabled. Not sure if a separate preference is required to control this feature. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 --- Comment #9 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to Lari Taskula from comment #8)
Btw something to note, this is currently controlled only by SMSSendDriver preference and edit_borrowers userflags. Since SMS messages are often not free of charge, there could be libraries wanting to disable this feature but at the same time still have automatically generated sms notices enabled. Not sure if a separate preference is required to control this feature.
But in our case it was the other way around, sms notices are disabled but the librarian still wants the option to occasionally send a manual sms to the patron :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 --- Comment #10 from Magnus Enger <magnus@libriotech.no> --- (In reply to Lari Taskula from comment #8)
Btw something to note, this is currently controlled only by SMSSendDriver preference and edit_borrowers userflags. Since SMS messages are often not free of charge, there could be libraries wanting to disable this feature but at the same time still have automatically generated sms notices enabled. Not sure if a separate preference is required to control this feature.
I would say a pref to turn this on or off would be nice, but not necessary. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Lari Taskula from comment #7)
(In reply to Andrew Fuerste-Henry from comment #3)
This is no longer adding "SMS added by a librarian" as the subject of the message. The lack of subject means there is no link to see the notice content in the patron's Notices tab.
I could not reproduce this issue. Following the test plan gives me this subject. Can you give me the steps to reproduce it?
I cannot recreate this either and can't think of what I did differently last week. Apologies for the false alarm and thank you for adding in the template functionality! I'm going to try to get a librarian to sign of on this so I can QA it, but it all worked perfectly for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Lari Taskula from comment #7)
(In reply to Andrew Fuerste-Henry from comment #3)
This is no longer adding "SMS added by a librarian" as the subject of the message. The lack of subject means there is no link to see the notice content in the patron's Notices tab.
I could not reproduce this issue. Following the test plan gives me this subject. Can you give me the steps to reproduce it?
I cannot recreate this either and can't think of what I did differently last week. Apologies for the false alarm and thank you for adding in the template functionality! I'm going to try to get a librarian to sign of on this so I can QA it, but it all worked perfectly for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191346|0 |1 is obsolete| | --- Comment #13 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 191374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191374&action=edit Bug 40933: Add the ability to send custom SMS messages to a patron To test: 1. Make sure SMSSendDriver system preference is enabled 2. In staff client, navigate to patron details of any patron 3. From the members menu toolbar, click "Add Message" 4. Under "Add a message for", select "SMS - sms number of patron" 5. Write a custom message 6. Click "Save" 7. Navigate to patron's Notices tab 8. Observe a new notice titled "SMS added by a librarian" 9. Click it 10. Observe the content you wrote in step 5 11. Repeat steps 2-4 12. Select predefined patron notice. If you don't have one, navigate to Tools > Notices and slips > New notice > Patrons (custom message) and add content under sms delivery option 13. Repeat steps 6-7 14. Observe your custom message in the notices table 15. Observe your custom message content when you click the notice Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191374|0 |1 is obsolete| | --- Comment #14 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 191709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191709&action=edit Bug 40933: Add the ability to send custom SMS messages to a patron To test: 1. Make sure SMSSendDriver system preference is enabled 2. In staff client, navigate to patron details of any patron 3. From the members menu toolbar, click "Add Message" 4. Under "Add a message for", select "SMS - sms number of patron" 5. Write a custom message 6. Click "Save" 7. Navigate to patron's Notices tab 8. Observe a new notice titled "SMS added by a librarian" 9. Click it 10. Observe the content you wrote in step 5 11. Repeat steps 2-4 12. Select predefined patron notice. If you don't have one, navigate to Tools > Notices and slips > New notice > Patrons (custom message) and add content under sms delivery option 13. Repeat steps 6-7 14. Observe your custom message in the notices table 15. Observe your custom message content when you click the notice Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Charlie Arthur <carthur@slolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | Status|Signed Off |Passed QA --- Comment #15 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Adding a sign-off from Charlie and bumping my SO up to a PQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This new feature allows release notes| |staff with appropriate | |permissions, | |`send_messages_to_borrowers | |`, to send SMS messages | |patrons from the patron | |details pages. | | | |Notice templates can be | |defined, and used for | |defaults, using the | |`Patrons (custom message)` | |module. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 Indranil Das Gupta <indradg@l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg@l2c2.co.in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29393 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 [Bug 29393] Ability to send emails from patron details page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42083 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42083 [Bug 42083] Email and SMS messages from patron record should have distinct permissions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 --- Comment #17 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 Donna <bwsdonna@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna@gmail.com --- Comment #18 from Donna <bwsdonna@gmail.com> --- Could we please not backport? This is an enhancement, not a fix. It would be best if it only gets pushed to 26.05 with 42083. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Pushed to stable |Needs documenting --- Comment #19 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Not backporting to 25.05 as this is an enhancement. Happy to revisit if needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40933 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org