[Bug 43053] New: Vendor payment methods are not displaying correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43053 Bug ID: 43053 Summary: Vendor payment methods are not displaying correctly Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: matt.blenkinsop@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org Target Milestone: --- To recreate: 1) Add multiple vendor payment method authorised values 2) Create a vendor and add multiple payment methods 3) Click to edit, the payment method will be displaying one option of a "|" concatenated string -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43053 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Depends on| |38207 Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@openfifth.c |ity.org |o.uk Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38207 [Bug 38207] Add vendor payment methods -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43053 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 201877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201877&action=edit Bug 43053: Fix display of vendor payment methods Test plan: 1) Add multiple vendor payment method authorised values 2) Create a vendor and add multiple payment methods 3) Click to edit, the payment method will be displaying one option of a "|" concatenated string 4) Apply patch and run yarn js:build 5) Hard refresh the browser, the payment methods should now display correctly 6) Edit the payment methods and save, the saved changes should be correctly displayed on the vendor details page 7) Add a new vendor with multiple payment methods, it should save correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43053 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43053 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43053 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201877|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43053 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 202221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202221&action=edit Bug 43053: Fix display of vendor payment methods Test plan: 1) Add multiple vendor payment method authorised values 2) Create a vendor and add multiple payment methods 3) Click to edit, the payment method will be displaying one option of a "|" concatenated string 4) Apply patch and run yarn js:build 5) Hard refresh the browser, the payment methods should now display correctly 6) Edit the payment methods and save, the saved changes should be correctly displayed on the vendor details page 7) Add a new vendor with multiple payment methods, it should save correctly Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43053 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes issues when release notes| |adding "Payment methods" to | |a vendor's record | |(Acquisitions > Vendors > | |Ordering information > | |Payment method). Now values | |are correctly shown in the | |dropdown list, and you can | |add multiple values. | | | |Notes: | |1. The authorized values | |for VENDOR_PAYMENT_METHOD | |need a description for it | |to show in the dropdown | |list. | |2. You may need to hard | |refresh the page for | |changes and new values to | |show in the dropdown list | |on the vendor edit form. Severity|enhancement |normal --- Comment #3 from David Nind <david@davidnind.com> --- Have signed off. Probably other bugs: 1. If an authorized value doesn't have a description, should it default to showing the authorized value code instead? Otherwise, the option is mostly hidden. (Not marked as a required field when adding an authorized value.) 2. Is it a "feature" that you have to hard refresh the page or clear browser caches for any changes to the authorized values to show? Testing notes (using KTD): 1. Observed behaviour before the patch: - Need to add descriptions to authorized values - Needed to hard refresh page or clear browser cache for values to show up in the dropdown list - Looks like a multi-value field, but can only select 1 value, selecting another value replaces the existing value 2. Authorized value list to use is VENDOR_PAYMENT_METHOD. 3. If you don't add a description to the authorized value, you can't see it in the dropdown list (it is there and if you use your arrow key you can "see" a line and add it). 4. If you make changes to the authorized value category list, you have to do a hard browser page refresh or clear your browser cache for changes, including new values, to show up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43053 --- Comment #4 from David Nind <david@davidnind.com> --- Changed from an enhancement to a normal bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43053 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43053 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43053 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43053 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202221|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43053 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202788&action=edit Bug 43053: Add a Cypress test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43053 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202789&action=edit Bug 43053: Fix display of vendor payment methods Test plan: 1) Add multiple vendor payment method authorised values 2) Create a vendor and add multiple payment methods 3) Click to edit, the payment method will be displaying one option of a "|" concatenated string 4) Apply patch and run yarn js:build 5) Hard refresh the browser, the payment methods should now display correctly 6) Edit the payment methods and save, the saved changes should be correctly displayed on the vendor details page 7) Add a new vendor with multiple payment methods, it should save correctly Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43053 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202790&action=edit Bug 43053: Simplify code, only 1 return statement Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43053 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43053 --- Comment #8 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43053 Bug 43053 depends on bug 38207, which changed state. Bug 38207 Summary: Add vendor payment methods https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38207 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43053 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43053 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.04 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org