[Bug 26423] New: Cannot find patron with no cardnumber attached to hold, if HidePatronName system preference set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26423 Bug ID: 26423 Summary: Cannot find patron with no cardnumber attached to hold, if HidePatronName system preference set Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: minna.kivinen@hamk.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When system preference HidePatronName is set, there is showing only patron cardnumber when looking at title holds. If patron has no cardnumber, there is showing nothing. There is no way to find the patron attached to hold. There should be a link to patron even when no cardnumber. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26423 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 210377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210377&action=edit Bug 26423: Never render an empty patron link when HidePatronName is set When HidePatronName is enabled the cardnumber is shown in place of the patron's name, linked to their account. For patrons without a cardnumber the link was rendered with no text, so it was invisible and could not be clicked. Fall back to "A patron from <library>", still linked to the patron, in both patron-format.js ($patron_to_html) and patron-title.inc. The holds table passes the patron's home library so the label can be built even though the library is not embedded. To test: 1. Create a patron without a cardnumber (or clear one in the DB) and place a hold for them 2. Set HidePatronName to "Don't show" 3. Open the request page for the record (cgi-bin/koha/reserve/request.pl) 4. Without the patch the patron cell in the holds table is an empty link 5. Apply the patch, run `yarn js:build` and hard refresh 6. The cell now reads "A patron from <library>" and links to the patron 7. Confirm patrons with a cardnumber still show the cardnumber 8. Run: npx cypress run --spec t/cypress/integration/Patron/Format.ts Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26423 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26423 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42936 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org