https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39323 --- Comment #1 from Jason Robb <jrobb@sekls.org> --- This is the JS I'm using in the meantime to make the dropdown go away after an item is clicked: if (window.location.href.indexOf("borrowernumber=") > -1) { $('.dropdown-item').on('click', function() { $(this).parent().parent().removeClass('show'); }); } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39323 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39323 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179729&action=edit Bug 39323: Print dropdown in members toolbar should auto close The upgrade to Bootstrap 5 broke some code which was designed to close a dropdown menu: $(".btn-group").removeClass("open"); This doesn't work in Bootstrap 5. You have to use: $(".dropdown-menu").removeClass("show"); However, I found that in most cases this extra code wasn't needed if we adjust the way we do the click handlers. Using "e.preventDefault()" instead of "return false" seems to be the preferred practice. This patch also makes a minor change to CSS to fix a display issue with dropdown menus. To test apply the patch and rebuild the staff interface CSS. - Clear your browser cache if necessary. - Search the catalog and click "Edit record" on one of the results. - In the basic MARC editor click the dropdown menu on the "Save" button. - Test the three options there: "Save and view record", "Save and edit items", and "Save and continue editing". - In each case clicking one of those options should result in the menu closing before the page redirects. - The main "Save" button should still work correctly. - Perform a patron search which will return results. - Check one or more patrons in the result and then click the "Add to patron list" button. The dropdown menu should look consistent with other dropdowns. - View the detail page for one of the patron in your results. - Test each of the options under the "Print" dropdown menu. In each case the menu should close itself when you click one of the menu items. - Test the "Renew patron" and "Update child to adult patron" - Click "Search to hold" and perform a catalog search which will return results. - Check one or more results and test the "Place hold" dropdown menu items. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39323 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39323 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Please explain this deletion: diff --git a/koha-tmpl/intranet-tmpl/prog/js/catalog.js b/koha-tmpl/intranet-tmpl/prog/js/catalog.js - $("#addtoshelf").click(function () { - addToShelf(); - $(".btn-group").removeClass("open"); - return false; - }); -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39323 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Marcel de Rooy from comment #5)

Please explain this deletion:

There is no element with the id "addtoshelf" (nor even any instance of the string "addtoshelf") in the staff interface templates. The code should have been removed when the element was changed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39323 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180056|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 181248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181248&action=edit Bug 39323: Print dropdown in members toolbar should auto close The upgrade to Bootstrap 5 broke some code which was designed to close a dropdown menu: $(".btn-group").removeClass("open"); This doesn't work in Bootstrap 5. You have to use: $(".dropdown-menu").removeClass("show"); However, I found that in most cases this extra code wasn't needed if we adjust the way we do the click handlers. Using "e.preventDefault()" instead of "return false" seems to be the preferred practice. This patch also makes a minor change to CSS to fix a display issue with dropdown menus. To test apply the patch and rebuild the staff interface CSS. - Clear your browser cache if necessary. - Search the catalog and click "Edit record" on one of the results. - In the basic MARC editor click the dropdown menu on the "Save" button. - Test the three options there: "Save and view record", "Save and edit items", and "Save and continue editing". - In each case clicking one of those options should result in the menu closing before the page redirects. - The main "Save" button should still work correctly. - Perform a patron search which will return results. - Check one or more patrons in the result and then click the "Add to patron list" button. The dropdown menu should look consistent with other dropdowns. - View the detail page for one of the patron in your results. - Test each of the options under the "Print" dropdown menu. In each case the menu should close itself when you click one of the menu items. - Test the "Renew patron" and "Update child to adult patron" - Click "Search to hold" and perform a catalog search which will return results. - Check one or more results and test the "Place hold" dropdown menu items. Sponsored-by: Athens County Public Libraries Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39323 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39323 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please prioritize fixing Jenkins tests, we still want a lot of patches included for 25.05... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39323 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Follow-up pushed to main! -- You are receiving this mail because: You are watching all bug changes.