[Bug 27881] New: Markup error in masthead-langmenu.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27881 Bug ID: 27881 Summary: Markup error in masthead-langmenu.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 20168 masthead-langmenu.inc has a few instances of this error: <a class="dropdown-item"<a href="#" tabindex="-1" class="menu-inactive" role="menuitem"> Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27881 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27881 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 117873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117873&action=edit Bug 27881: Markup error in masthead-langmenu.inc Some markup errors were introduced into the masthead-langmenu include file by Bug 20168, presumably during the update to the dropdown menu markup: '<a class="dropdown-item" <a href="' ...resulting in validation errors like "Attribute <a not allowed on element a at this point." This patch correct the errors. To test you should have at least two languages enabled in the OPACLanguages system preference, opaclanguagesdisplay set to "allow," and OpacLangSelectorMode set to "top" or "both top and footer." - Apply the patch and view the OPAC. - The "Languages" menu at the top of the page should look correct and work correctly. - Validating the source of the page should return no errors related to the language menu's markup. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27881 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 27888 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27881 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As I filed a duplicate, least I can do is a sign-off... :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27881 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27881 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117873|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117877&action=edit Bug 27881: Markup error in masthead-langmenu.inc Some markup errors were introduced into the masthead-langmenu include file by Bug 20168, presumably during the update to the dropdown menu markup: '<a class="dropdown-item" <a href="' ...resulting in validation errors like "Attribute <a not allowed on element a at this point." This patch correct the errors. To test you should have at least two languages enabled in the OPACLanguages system preference, opaclanguagesdisplay set to "allow," and OpacLangSelectorMode set to "top" or "both top and footer." - Apply the patch and view the OPAC. - The "Languages" menu at the top of the page should look correct and work correctly. - Validating the source of the page should return no errors related to the language menu's markup. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27881 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117877|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118810&action=edit Bug 27881: Markup error in masthead-langmenu.inc Some markup errors were introduced into the masthead-langmenu include file by Bug 20168, presumably during the update to the dropdown menu markup: '<a class="dropdown-item" <a href="' ...resulting in validation errors like "Attribute <a not allowed on element a at this point." This patch correct the errors. To test you should have at least two languages enabled in the OPACLanguages system preference, opaclanguagesdisplay set to "allow," and OpacLangSelectorMode set to "top" or "both top and footer." - Apply the patch and view the OPAC. - The "Languages" menu at the top of the page should look correct and work correctly. - Validating the source of the page should return no errors related to the language menu's markup. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27881 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good catch, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27881 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27881 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27881 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This problem is also present in 20.11, I just verified on our test installation - could this be backported? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27881 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.05 released in| | --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27881 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |andrew@bywatersolutions.com --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency, not backported -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27881 Bug 27881 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27881 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34646 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34646 [Bug 34646] Two attributes class in OPAC masthead-langmenu.inc -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org